refactor: update configuration handling and directory creation

- Renamed `codacyDirectory` to `globalCacheDirectory` for clarity.
- Updated methods to create necessary directories during initialization and installation.
- Removed the old directory creation function in favor of a more streamlined approach.

Author: andrzej-janczak

cmd/init.go

@@ -29,11 +29,7 @@ var initCmd = &cobra.Command{
 	Run: func(cmd *cobra.Command, args []string) {
 		// Initialize configuration without creating directories
 		config.Init()
-
-		// Create necessary directories
-		if err := config.EnsureDirectories(); err != nil {
-			log.Fatal(err)
-		}
+		config.Config.CreateLocalCodacyDir()
 
 		if len(codacyRepositoryToken) == 0 {
 			fmt.Println("No project token was specified, skipping fetch configurations ")

cmd/install.go

@@ -1,9 +1,11 @@
 package cmd
 
 import (
+	"codacy/cli-v2/config"
 	cfg "codacy/cli-v2/config"
 	config_file "codacy/cli-v2/config-file"
 	"fmt"
+	"io"
 	"log"
 	"os"
 	"time"
@@ -30,6 +32,11 @@ var installCmd = &cobra.Command{
 		bold := color.New(color.Bold)
 		green := color.New(color.FgGreen)
 
+		// Create necessary directories
+		if err := config.Config.CreateCodacyDirs(); err != nil {
+			log.Fatal(err)
+		}
+
 		// Load config file
 		if err := config_file.ReadConfigFile(cfg.Config.ProjectConfigFile()); err != nil {
 			fmt.Println()
@@ -121,6 +128,12 @@ var installCmd = &cobra.Command{
 			}),
 		)
 
+		// Redirect all output to /dev/null during installation
+		oldStdout := os.Stdout
+		devNull, _ := os.Open(os.DevNull)
+		os.Stdout = devNull
+		log.SetOutput(io.Discard)
+
 		// Install runtimes first
 		for name, runtime := range cfg.Config.Runtimes() {
 			if !cfg.Config.IsRuntimeInstalled(name, runtime) {
@@ -145,6 +158,11 @@ var installCmd = &cobra.Command{
 			}
 		}
 
+		// Restore output
+		os.Stdout = oldStdout
+		devNull.Close()
+		log.SetOutput(os.Stderr)
+
 		// Print completion status
 		fmt.Println()
 		for name, runtime := range cfg.Config.Runtimes() {

config/config.go

@@ -11,7 +11,7 @@ import (
 
 type ConfigType struct {
 	homePath             string
-	codacyDirectory      string
+	globalCacheDirectory string
 	runtimesDirectory    string
 	toolsDirectory       string
 	localCodacyDirectory string
@@ -26,7 +26,7 @@ func (c *ConfigType) HomePath() string {
 }
 
 func (c *ConfigType) CodacyDirectory() string {
-	return c.codacyDirectory
+	return c.globalCacheDirectory
 }
 
 func (c *ConfigType) RuntimesDirectory() string {
@@ -84,9 +84,9 @@ func (c *ConfigType) AddTools(configs []plugins.ToolConfig) error {
 }
 
 func (c *ConfigType) setupCodacyPaths() {
-	c.codacyDirectory = filepath.Join(c.homePath, ".cache", "codacy")
-	c.runtimesDirectory = filepath.Join(c.codacyDirectory, "runtimes")
-	c.toolsDirectory = filepath.Join(c.codacyDirectory, "tools")
+	c.globalCacheDirectory = filepath.Join(c.homePath, ".cache", "codacy")
+	c.runtimesDirectory = filepath.Join(c.globalCacheDirectory, "runtimes")
+	c.toolsDirectory = filepath.Join(c.globalCacheDirectory, "tools")
 	c.localCodacyDirectory = ".codacy"
 
 	yamlPath := filepath.Join(c.localCodacyDirectory, "codacy.yaml")
@@ -99,8 +99,8 @@ func (c *ConfigType) setupCodacyPaths() {
 	}
 }
 
-func (c *ConfigType) createCodacyDirs() error {
-	if err := os.MkdirAll(c.codacyDirectory, 0777); err != nil {
+func (c *ConfigType) CreateCodacyDirs() error {
+	if err := os.MkdirAll(c.globalCacheDirectory, 0777); err != nil {
 		return fmt.Errorf("failed to create codacy directory: %w", err)
 	}
 
@@ -111,11 +111,13 @@ func (c *ConfigType) createCodacyDirs() error {
 	if err := os.MkdirAll(c.toolsDirectory, 0777); err != nil {
 		return fmt.Errorf("failed to create tools directory: %w", err)
 	}
+	return nil
+}
 
+func (c *ConfigType) CreateLocalCodacyDir() error {
 	if err := os.MkdirAll(c.localCodacyDirectory, 0777); err != nil {
 		return fmt.Errorf("failed to create local codacy directory: %w", err)
 	}
-
 	return nil
 }
 
@@ -131,11 +133,6 @@ func Init() {
 	Config.tools = make(map[string]*plugins.ToolInfo)
 }
 
-// EnsureDirectories creates all necessary Codacy directories if they don't exist
-func EnsureDirectories() error {
-	return Config.createCodacyDirs()
-}
-
 // IsRuntimeInstalled checks if a runtime is already installed
 func (c *ConfigType) IsRuntimeInstalled(name string, runtime *plugins.RuntimeInfo) bool {
 	// If there are no binaries, check the install directory