improve sarif

Author: andrzej-janczak

cmd/analyze.go

@@ -250,7 +250,7 @@ var analyzeCmd = &cobra.Command{
 
 		log.Println("Running all configured tools...")
 
-		if outputFormat == "sarif" {
+		if outputFormat == "sarif" && outputFile != "" {
 			// Create temporary directory for individual tool outputs
 			tmpDir, err := os.MkdirTemp("", "codacy-analysis-*")
 			if err != nil {

utils/sarif.go

@@ -43,9 +43,18 @@ type Driver struct {
 }
 
 type Rule struct {
-	ID               string                 `json:"id"`
-	ShortDescription MessageText            `json:"shortDescription"`
-	Properties       map[string]interface{} `json:"properties"`
+	ID               string         `json:"id"`
+	ShortDescription MessageText    `json:"shortDescription"`
+	Properties       RuleProperties `json:"properties"`
+}
+
+type RuleProperties struct {
+	Priority int      `json:"priority,omitempty"`
+	Ruleset  string   `json:"ruleset,omitempty"`
+	Tags     []string `json:"tags,omitempty"`
+	// Add other common properties that might be present
+	Precision        string `json:"precision,omitempty"`
+	SecuritySeverity string `json:"security-severity,omitempty"`
 }
 
 type Result struct {