fix: fix Lizard runner

Author: alerizzo

tools/lizard/lizardRunner.go

@@ -6,6 +6,8 @@ import (
 	"codacy/cli-v2/constants"
 	"codacy/cli-v2/domain"
 	"codacy/cli-v2/tools"
+	"codacy/cli-v2/utils/logger"
+	"github.com/sirupsen/logrus"
 	"encoding/json"
 	"fmt"
 	"os"
@@ -19,6 +21,7 @@ func RunLizard(workDirectory string, binary string, files []string, outputFile s
 	var patterns []domain.PatternDefinition
 	var errConfigs error
 
+
 	if exists {
 		// Configuration exists, read from file
 		patterns, errConfigs = ReadConfig(configFile)
@@ -36,6 +39,7 @@ func RunLizard(workDirectory string, binary string, files []string, outputFile s
 		return fmt.Errorf("no valid patterns found in configuration")
 	}
 
+
 	// Construct base command with lizard module
 	args := []string{"-m", "lizard", "-V"}
 
@@ -46,66 +50,77 @@ func RunLizard(workDirectory string, binary string, files []string, outputFile s
 		args = append(args, ".")
 	}
 
+
 	// For non-SARIF output, let Lizard handle file output directly
 	if outputFormat != "sarif" && outputFile != "" {
 		args = append(args, "-o", outputFile)
 	}
 
+
 	// Run the command
 	cmd := exec.Command(binary, args...)
 	cmd.Dir = workDirectory
-	cmd.Stderr = os.Stderr
+
 
 	var err error
+	var stderr bytes.Buffer
+	
+	cmd.Stderr = &stderr
+	
 	// For SARIF output, we need to capture and parse the output
 	if outputFormat == "sarif" {
 		var stdout bytes.Buffer
 		cmd.Stdout = &stdout
 
-		err = cmd.Run()
+		cmd.Run()
+
+		if stderr.Len() > 0 {
+			logger.Debug("Failed to run Lizard: ", logrus.Fields{
+				"error":  err.Error(),
+				"stderr": string(stderr.Bytes()),
+			})
+
+			return fmt.Errorf("failed to run Lizard: %w", err)
+		}
+
+		// Parse the output and generate issues
+		results, parseErr := parseLizardResults(stdout.String())
+		if parseErr != nil {
+			return fmt.Errorf("failed to parse Lizard output: %w", parseErr)
+		}
+		issues := generateIssuesFromResults(results, patterns)
+
+		// Convert issues to SARIF Report
+		sarifReport := convertIssuesToSarif(issues, patterns)
+		// Marshal SARIF Report report to Sarif
+		sarifData, err := json.MarshalIndent(sarifReport, "", "  ")
 		if err != nil {
-			// Lizard returns 1 when it finds issues, which is not a failure
-			if exitErr, ok := err.(*exec.ExitError); ok && exitErr.ExitCode() == 1 {
-				// Parse the output and generate issues
-				results, parseErr := parseLizardResults(stdout.String())
-				if parseErr != nil {
-					return fmt.Errorf("failed to parse Lizard output: %w", parseErr)
-				}
-
-				issues := generateIssuesFromResults(results, patterns)
-
-				// Convert issues to SARIF Report
-				sarifReport := convertIssuesToSarif(issues, patterns)
-
-				// Marshal SARIF Report report to Sarif
-				sarifData, err := json.MarshalIndent(sarifReport, "", "  ")
-				if err != nil {
-					return fmt.Errorf("failed to marshal SARIF report: %w", err)
-				}
-
-				// Write SARIF output to file if specified, else stdout
-				if outputFile != "" {
-					err = os.WriteFile(outputFile, sarifData, constants.DefaultFilePerms)
-					if err != nil {
-						return fmt.Errorf("failed to write SARIF output: %w", err)
-					}
-				} else {
-					fmt.Println(string(sarifData))
-				}
-
-				return nil
+			return fmt.Errorf("failed to marshal SARIF report: %w", err)
+		}
+
+		// Write SARIF output to file if specified, else stdout
+		if outputFile != "" {
+			err = os.WriteFile(outputFile, sarifData, constants.DefaultFilePerms)
+			if err != nil {
+				return fmt.Errorf("failed to write SARIF output: %w", err)
 			}
-			return fmt.Errorf("failed to run Lizard: %w", err)
+		} else {
+			fmt.Println(string(sarifData))
 		}
+
+		return nil
+
 	} else {
 		// For non-SARIF output, let Lizard handle stdout
 		cmd.Stdout = os.Stdout
 		err = cmd.Run()
-		if err != nil {
-			// Lizard returns 1 when it finds issues, which is not a failure
-			if exitErr, ok := err.(*exec.ExitError); ok && exitErr.ExitCode() == 1 {
-				return nil
-			}
+
+		if stderr.Len() > 0 {
+			logger.Debug("Failed to run Lizard: ", logrus.Fields{
+				"error":  err.Error(),
+				"stderr": string(stderr.Bytes()),
+			})
+
 			return fmt.Errorf("failed to run Lizard: %w", err)
 		}
 	}