pr review and fixed bug on creation of yaml file

Author: franciscoovazevedo

tools/language_config.go

@@ -7,6 +7,7 @@ import (
 	"net/http"
 	"os"
 	"path/filepath"
+	"slices"
 	"strings"
 	"time"
 
@@ -15,7 +16,7 @@ import (
 	"gopkg.in/yaml.v3"
 )
 
-const CodacyApiBase = "https://app.codacy.com"
+var CodacyApiBase = "https://app.codacy.com"
 
 // ToolLanguageInfo contains language and extension information for a tool
 type ToolLanguageInfo struct {
@@ -91,17 +92,26 @@ func CreateLanguagesConfigFile(apiTools []Tool, toolsConfigDir string, toolIDMap
 
 			// Filter languages based on repository languages
 			var filteredLanguages []string
+			var filteredExtensionsSet = make(map[string]struct{})
 			for _, lang := range langInfo.Languages {
-				// Convert both to lowercase for case-insensitive comparison
 				lowerLang := strings.ToLower(lang)
 				if extensions, exists := repositoryLanguages[lowerLang]; exists && len(extensions) > 0 {
 					filteredLanguages = append(filteredLanguages, lang)
+					for _, ext := range extensions {
+						filteredExtensionsSet[ext] = struct{}{}
+					}
 				}
 			}
+			filteredExtensions := make([]string, 0, len(filteredExtensionsSet))
+			for ext := range filteredExtensionsSet {
+				filteredExtensions = append(filteredExtensions, ext)
+			}
+			slices.Sort(filteredExtensions)
+			langInfo.Languages = filteredLanguages
+			langInfo.Extensions = filteredExtensions
 
 			// Only add tool if it has languages that exist in the repository
 			if len(filteredLanguages) > 0 {
-				langInfo.Languages = filteredLanguages
 				configTools = append(configTools, langInfo)
 			}
 		}
@@ -135,7 +145,6 @@ func CreateLanguagesConfigFile(apiTools []Tool, toolsConfigDir string, toolIDMap
 	return nil
 }
 
-// https://app.codacy.com/api/v3/organizations/gh/troubleshoot-codacy/repositories/eslint-test-examples/settings/languages
 func getRepositoryLanguages(apiToken string, provider string, organization string, repository string) (map[string][]string, error) {
 	client := &http.Client{
 		Timeout: 10 * time.Second,
@@ -212,6 +221,9 @@ func getRepositoryLanguages(apiToken string, provider string, organization strin
 				extSlice = append(extSlice, ext)
 			}
 
+			// Sort extensions for consistent ordering in the config file
+			slices.Sort(extSlice)
+
 			// Add to result map with lowercase key for case-insensitive matching
 			result[strings.ToLower(lang.Name)] = extSlice
 		}

tools/language_config_test.go

@@ -6,11 +6,13 @@ import (
 	"io"
 	"net/http"
 	"net/http/httptest"
+	"os"
 	"sort"
 	"testing"
 	"time"
 
 	"github.com/stretchr/testify/assert"
+	"gopkg.in/yaml.v3"
 )
 
 func TestGetRepositoryLanguages(t *testing.T) {
@@ -220,3 +222,96 @@ func TestGetRepositoryLanguages(t *testing.T) {
 		})
 	}
 }
+
+func TestCreateLanguagesConfigFile_ExtensionsFromRepository(t *testing.T) {
+	tempDir := t.TempDir()
+
+	// Mock API server for getRepositoryLanguages
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Content-Type", "application/json")
+		json.NewEncoder(w).Encode(map[string]interface{}{
+			"languages": []map[string]interface{}{
+				{
+					"name":           "JavaScript",
+					"codacyDefaults": []string{".js", ".jsx"},
+					"extensions":     []string{".js", ".vue"},
+					"enabled":        true,
+					"detected":       true,
+				},
+				{
+					"name":           "Python",
+					"codacyDefaults": []string{".py"},
+					"extensions":     []string{".testPy"},
+					"enabled":        true,
+					"detected":       true,
+				},
+				{
+					"name":           "Apex",
+					"codacyDefaults": []string{".cls"},
+					"extensions":     []string{".app", ".trigger"},
+					"enabled":        true,
+					"detected":       true,
+				},
+				{
+					"name":           "Scala",
+					"codacyDefaults": []string{".scala"},
+					"extensions":     []string{},
+					"enabled":        true,
+					"detected":       true,
+				},
+				{
+					"name":           "Ruby",
+					"codacyDefaults": []string{".rb"},
+					"extensions":     []string{".gemspec"},
+					"enabled":        true,
+					"detected":       true,
+				},
+			},
+		})
+	}))
+	defer server.Close()
+
+	// Patch CodacyApiBase to use the test server
+	oldBase := CodacyApiBase
+	CodacyApiBase = server.URL
+	defer func() { CodacyApiBase = oldBase }()
+
+	apiTools := []Tool{
+		{Uuid: "eslint-uuid"},
+		{Uuid: "pylint-uuid"},
+		{Uuid: "pmd-uuid"},
+	}
+	toolIDMap := map[string]string{
+		"eslint-uuid": "eslint",
+		"pylint-uuid": "pylint",
+		"pmd-uuid":    "pmd",
+	}
+
+	err := CreateLanguagesConfigFile(apiTools, tempDir, toolIDMap, "test-token", "gh", "org", "repo")
+	assert.NoError(t, err)
+
+	// Read and unmarshal the generated YAML
+	data, err := os.ReadFile(tempDir + "/languages-config.yaml")
+	assert.NoError(t, err)
+
+	var config LanguagesConfig
+	err = yaml.Unmarshal(data, &config)
+	assert.NoError(t, err)
+
+	// Check that extensions are correct for each tool
+	eslint := findTool(config.Tools, "eslint")
+	assert.ElementsMatch(t, []string{".js", ".jsx", ".vue"}, eslint.Extensions)
+	pylint := findTool(config.Tools, "pylint")
+	assert.ElementsMatch(t, []string{".py", ".testPy"}, pylint.Extensions)
+	pmd := findTool(config.Tools, "pmd")
+	assert.ElementsMatch(t, []string{".cls", ".app", ".trigger", ".scala", ".rb", ".gemspec"}, pmd.Extensions)
+}
+
+func findTool(tools []ToolLanguageInfo, name string) ToolLanguageInfo {
+	for _, t := range tools {
+		if t.Name == name {
+			return t
+		}
+	}
+	return ToolLanguageInfo{}
+}