fixed test

Author: franciscoovazevedo

cmd/analyze_integration_test.go

@@ -88,6 +88,11 @@ func TestCheckIfConfigExistsAndIsNeededBehavior(t *testing.T) {
 			// Mock config to use our temporary directory
 			config.Config = *config.NewConfigType(tmpDir, tmpDir, tmpDir)
 
+			// Create tools-configs directory since the function will try to create config files
+			toolsConfigDir := config.Config.ToolsConfigDirectory()
+			err = os.MkdirAll(toolsConfigDir, constants.DefaultDirPerms)
+			require.NoError(t, err)
+
 			// Execute the function - this tests it doesn't panic or return unexpected errors
 			err = checkIfConfigExistsAndIsNeeded(tt.toolName, tt.cliLocalMode)
 

cmd/analyze_test.go

@@ -324,7 +324,7 @@ func TestCheckIfConfigExistsAndIsNeeded(t *testing.T) {
 			apiToken:         "",
 			configFileExists: false,
 			expectError:      false,
-			description:      "Local mode should show message about adding config file",
+			description:      "Local mode should create config file if tools-configs directory exists",
 		},
 	}
 
@@ -346,11 +346,11 @@ func TestCheckIfConfigExistsAndIsNeeded(t *testing.T) {
 			if tt.configFileExists && constants.ToolConfigFileNames[tt.toolName] != "" {
 				// Use config.Config.ToolsConfigDirectory() to get the exact same path the function will use
 				toolsConfigDir := config.Config.ToolsConfigDirectory()
-				err := os.MkdirAll(toolsConfigDir, 0755)
+				err := os.MkdirAll(toolsConfigDir, constants.DefaultDirPerms)
 				require.NoError(t, err)
 
 				configPath := filepath.Join(toolsConfigDir, constants.ToolConfigFileNames[tt.toolName])
-				err = os.WriteFile(configPath, []byte("test config"), 0644)
+				err = os.WriteFile(configPath, []byte("test config"), constants.DefaultFilePerms)
 				require.NoError(t, err)
 
 				// Ensure the file was created and can be found
@@ -363,6 +363,13 @@ func TestCheckIfConfigExistsAndIsNeeded(t *testing.T) {
 				ApiToken: tt.apiToken,
 			}
 
+			// Ensure tools-configs directory exists if the function might try to create config files
+			if !tt.configFileExists && constants.ToolConfigFileNames[tt.toolName] != "" {
+				toolsConfigDir := config.Config.ToolsConfigDirectory()
+				err := os.MkdirAll(toolsConfigDir, constants.DefaultDirPerms)
+				require.NoError(t, err)
+			}
+
 			// Execute the function
 			err = checkIfConfigExistsAndIsNeeded(tt.toolName, tt.cliLocalMode)