test: Add tests to the tool configs generation PLUTO-1384

Author: machadoit

cmd/init.go

@@ -247,14 +247,7 @@ func buildRepositoryConfigurationFiles(token string) error {
 	}
 
 	// Filter out any tools that use configuration file
-	var configuredToolsWithUI []tools.Tool
-	for _, tool := range apiTools {
-		if !tool.Settings.UsesConfigFile {
-			configuredToolsWithUI = append(configuredToolsWithUI, tool)
-		} else {
-			fmt.Printf("Skipping config generation for %s - configured to use repo's config file\n", tool.Name)
-		}
-	}
+	configuredToolsWithUI := tools.FilterToolsByConfigUsage(apiTools)
 
 	// Create main config files with all enabled API tools
 	err = createConfigurationFiles(apiTools, false)

tools/getTools.go

@@ -138,3 +138,17 @@ type Tool struct {
 		UsesConfigFile bool `json:"hasConfigurationFile"`
 	} `json:"settings"`
 }
+
+// FilterToolsByConfigUsage filters out tools that use their own configuration files
+// Returns only tools that need configuration to be generated for them (UsesConfigFile = false)
+func FilterToolsByConfigUsage(tools []Tool) []Tool {
+	var filtered []Tool
+	for _, tool := range tools {
+		if !tool.Settings.UsesConfigFile {
+			filtered = append(filtered, tool)
+		} else {
+			fmt.Printf("Skipping config generation for %s - configured to use repo's config file\n", tool.Name)
+		}
+	}
+	return filtered
+}

tools/getTools_test.go

@@ -0,0 +1,144 @@
+package tools
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestFilterToolsByConfigUsage(t *testing.T) {
+	tests := []struct {
+		name          string
+		inputTools    []Tool
+		expectedCount int
+		expectedTools []string
+	}{
+		{
+			name: "tools with UsesConfigFile=true should be filtered out",
+			inputTools: []Tool{
+				{
+					Uuid: "eslint-uuid",
+					Name: "eslint",
+					Settings: struct {
+						Enabled        bool `json:"isEnabled"`
+						UsesConfigFile bool `json:"hasConfigurationFile"`
+					}{
+						Enabled:        true,
+						UsesConfigFile: true,
+					},
+				},
+				{
+					Uuid: "trivy-uuid",
+					Name: "trivy",
+					Settings: struct {
+						Enabled        bool `json:"isEnabled"`
+						UsesConfigFile bool `json:"hasConfigurationFile"`
+					}{
+						Enabled:        true,
+						UsesConfigFile: false,
+					},
+				},
+				{
+					Uuid: "pylint-uuid",
+					Name: "pylint",
+					Settings: struct {
+						Enabled        bool `json:"isEnabled"`
+						UsesConfigFile bool `json:"hasConfigurationFile"`
+					}{
+						Enabled:        true,
+						UsesConfigFile: false,
+					},
+				},
+			},
+			expectedCount: 2,
+			expectedTools: []string{"trivy", "pylint"},
+		},
+		{
+			name: "all tools using config should be filtered out",
+			inputTools: []Tool{
+				{
+					Uuid: "eslint-uuid",
+					Name: "eslint",
+					Settings: struct {
+						Enabled        bool `json:"isEnabled"`
+						UsesConfigFile bool `json:"hasConfigurationFile"`
+					}{
+						Enabled:        true,
+						UsesConfigFile: true,
+					},
+				},
+				{
+					Uuid: "trivy-uuid",
+					Name: "trivy",
+					Settings: struct {
+						Enabled        bool `json:"isEnabled"`
+						UsesConfigFile bool `json:"hasConfigurationFile"`
+					}{
+						Enabled:        true,
+						UsesConfigFile: true,
+					},
+				},
+			},
+			expectedCount: 0,
+			expectedTools: []string{},
+		},
+		{
+			name: "no tools using config should all pass through",
+			inputTools: []Tool{
+				{
+					Uuid: "eslint-uuid",
+					Name: "eslint",
+					Settings: struct {
+						Enabled        bool `json:"isEnabled"`
+						UsesConfigFile bool `json:"hasConfigurationFile"`
+					}{
+						Enabled:        true,
+						UsesConfigFile: false,
+					},
+				},
+				{
+					Uuid: "pylint-uuid",
+					Name: "pylint",
+					Settings: struct {
+						Enabled        bool `json:"isEnabled"`
+						UsesConfigFile bool `json:"hasConfigurationFile"`
+					}{
+						Enabled:        true,
+						UsesConfigFile: false,
+					},
+				},
+			},
+			expectedCount: 2,
+			expectedTools: []string{"eslint", "pylint"},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			// Use the actual function being tested
+			result := FilterToolsByConfigUsage(tt.inputTools)
+
+			// Verify the count matches
+			assert.Equal(t, tt.expectedCount, len(result),
+				"Expected %d tools after filtering, got %d", tt.expectedCount, len(result))
+
+			// Verify each expected tool is in the result
+			for _, expectedTool := range tt.expectedTools {
+				found := false
+				for _, tool := range result {
+					if tool.Name == expectedTool {
+						found = true
+						break
+					}
+				}
+				assert.True(t, found, "Expected tool %s not found in filtered results", expectedTool)
+			}
+
+			// Verify no tools with UsesConfigFile=true are in the result
+			for _, tool := range result {
+				assert.False(t, tool.Settings.UsesConfigFile,
+					"Tool %s with UsesConfigFile=true should not be in filtered results", tool.Name)
+			}
+		})
+	}
+}