review improve 2

Author: andrzej-janczak

tools/semgrepRunner.go

@@ -46,10 +46,10 @@ func RunSemgrep(workDirectory string, toolInfo *plugins.ToolInfo, files []string
 	cmd := exec.Command(semgrepPath, cmdArgs...)
 	cmd.Dir = workDirectory
 
-	// If output file is specified, create it and redirect output
-	var outputWriter *os.File
-	var err error
 	if outputFile != "" {
+		// If output file is specified, create it and redirect output
+		var outputWriter *os.File
+		var err error
 		outputWriter, err = os.Create(filepath.Clean(outputFile))
 		if err != nil {
 			return fmt.Errorf("failed to create output file: %w", err)

tools/semgrepRunner_test.go

@@ -2,7 +2,6 @@ package tools
 
 import (
 	"codacy/cli-v2/plugins"
-	"log"
 	"os"
 	"path/filepath"
 	"testing"
@@ -13,11 +12,11 @@ import (
 func TestRunSemgrepWithSpecificFiles(t *testing.T) {
 	homeDirectory, err := os.UserHomeDir()
 	if err != nil {
-		log.Fatal(err.Error())
+		t.Fatalf("Failed to get home directory: %v", err)
 	}
 	currentDirectory, err := os.Getwd()
 	if err != nil {
-		log.Fatal(err.Error())
+		t.Fatalf("Failed to get current directory: %v", err)
 	}
 
 	// Set up test directories and files