fix the languages-config file when discovery

Author: andrzej-janczak

cmd/config.go

@@ -235,11 +235,26 @@ var configDiscoverCmd = &cobra.Command{
 func updateLanguagesConfigForTools(detectedTools map[string]struct{}, toolsConfigDir string, defaultToolLangMap map[string]domain.ToolLanguageInfo) error {
 	langConfigPath := filepath.Join(toolsConfigDir, "languages-config.yaml")
 
-	// Build language configuration for detected tools
+	// Read existing languages config if it exists
 	var langConf domain.LanguagesConfig
+	if content, err := os.ReadFile(langConfigPath); err == nil {
+		if err := yaml.Unmarshal(content, &langConf); err != nil {
+			return fmt.Errorf("failed to parse existing languages-config.yaml: %w", err)
+		}
+	}
+
+	// Create a map of existing tools for quick lookup
+	existingTools := make(map[string]domain.ToolLanguageInfo)
+	for _, tool := range langConf.Tools {
+		existingTools[tool.Name] = tool
+	}
+
+	// Add detected tools that are not already present
 	for toolName := range detectedTools {
-		if toolInfo, exists := defaultToolLangMap[toolName]; exists {
-			langConf.Tools = append(langConf.Tools, toolInfo)
+		if _, alreadyExists := existingTools[toolName]; !alreadyExists {
+			if toolInfo, exists := defaultToolLangMap[toolName]; exists {
+				langConf.Tools = append(langConf.Tools, toolInfo)
+			}
 		}
 	}
 

integration-tests/config-discover/expected/tools-configs/languages-config.yaml

@@ -1,4 +1,7 @@
 tools:
+    - name: codacy-enigma-cli
+      languages: [Multiple]
+      extensions: []
     - name: dartanalyzer
       languages: [Dart]
       extensions: [.dart]
@@ -17,3 +20,6 @@ tools:
     - name: semgrep
       languages: [C, CPP, C#, Generic, Go, Java, JavaScript, JSON, Kotlin, Python, TypeScript, Ruby, Rust, JSX, PHP, Scala, Swift, Terraform]
       extensions: [.c, .cpp, .h, .hpp, .cs, .go, .java, .js, .json, .kt, .py, .ts, .rb, .rs, .jsx, .php, .scala, .swift, .tf, .tfvars]
+    - name: trivy
+      languages: [Multiple]
+      extensions: []

integration-tests/run.sh

@@ -434,6 +434,63 @@ cleanup_codacy() {
   fi
 }
 
+# Validate that languages-config.yaml exists and contains all tools from codacy.yaml
+validate_languages_config_contains_all_tools() {
+  local codacy_yaml=".codacy/codacy.yaml"
+  local languages_config=".codacy/tools-configs/languages-config.yaml"
+  
+  # Check that languages-config.yaml exists
+  if [ ! -f "$languages_config" ]; then
+    echo "❌ languages-config.yaml does not exist at $languages_config"
+    exit 1
+  fi
+  echo "✅ languages-config.yaml exists"
+  
+  # Extract tool names from codacy.yaml
+  if [ ! -f "$codacy_yaml" ]; then
+    echo "❌ codacy.yaml does not exist at $codacy_yaml"
+    exit 1
+  fi
+  
+  # Get tools from codacy.yaml (extract tool names before @ version, only from tools section)
+  codacy_tools=$(awk '
+    /^tools:/ { in_tools=1; next }
+    /^[a-zA-Z][^:]*:/ { in_tools=0 }
+    in_tools && /^\s*-\s+[a-zA-Z0-9_-]+@/ { 
+      gsub(/^\s*-\s*/, ""); 
+      gsub(/@.*$/, ""); 
+      print 
+    }
+  ' "$codacy_yaml" | sort || true)
+  
+  if [ -z "$codacy_tools" ]; then
+    echo "✅ No tools found in codacy.yaml, skipping validation"
+    return 0
+  fi
+  
+  echo "📋 Tools found in codacy.yaml:"
+  echo "$codacy_tools"
+  
+  # Check that each tool from codacy.yaml exists in languages-config.yaml
+  missing_tools=""
+  for tool in $codacy_tools; do
+    if ! grep -q "name: $tool" "$languages_config"; then
+      missing_tools="$missing_tools $tool"
+    fi
+  done
+  
+  if [ -n "$missing_tools" ]; then
+    echo "❌ The following tools from codacy.yaml are missing in languages-config.yaml:$missing_tools"
+    echo "=== Tools in codacy.yaml ==="
+    echo "$codacy_tools"
+    echo "=== Tools in languages-config.yaml ==="
+    grep "name:" "$languages_config" | sed 's/.*name: \(.*\)/\1/' | sort
+    exit 1
+  fi
+  
+  echo "✅ All tools from codacy.yaml are present in languages-config.yaml"
+}
+
 compare_files() {
   local expected_dir="$1"
   local actual_dir="$2"
@@ -568,9 +625,15 @@ EOF
     exit 1
   fi
 
+  # Check the languages-config.yaml is present and contains all tools which are in the codacy.yaml
+  validate_languages_config_contains_all_tools
+
   # Run config discover on the test directory - adding all tools
   "$CLI_PATH" config discover .
 
+  # Final validation: check that languages-config.yaml contains all tools from codacy.yaml
+  validate_languages_config_contains_all_tools
+  
   compare_files "expected" ".codacy" "Test $test_name"
 
   echo "✅ Test $test_name completed successfully"