refactor: make config.init not create files

Author: andrzej-janczak

.codacy/codacy.yaml

@@ -4,5 +4,5 @@ runtimes:
 tools:
     - [email protected]
     - [email protected]
-    - [email protected]
     - [email protected]
+    - [email protected]

cmd/init.go

@@ -17,8 +17,6 @@ import (
 
 const CodacyApiBase = "https://app.codacy.com"
 
-var codacyRepositoryToken string
-
 func init() {
 	initCmd.Flags().StringVar(&codacyRepositoryToken, "repository-token", "", "optional codacy repository token, if defined configurations will be fetched from codacy")
 	rootCmd.AddCommand(initCmd)
@@ -29,9 +27,14 @@ var initCmd = &cobra.Command{
 	Short: "Bootstraps project configuration",
 	Long:  "Bootstraps project configuration, creates codacy configuration file",
 	Run: func(cmd *cobra.Command, args []string) {
-
+		// Initialize configuration without creating directories
 		config.Init()
 
+		// Create necessary directories
+		if err := config.EnsureDirectories(); err != nil {
+			log.Fatal(err)
+		}
+
 		if len(codacyRepositoryToken) == 0 {
 			fmt.Println("No project token was specified, skipping fetch configurations ")
 			noTools := []tools.Tool{}
@@ -48,10 +51,6 @@ var initCmd = &cobra.Command{
 			if err != nil {
 				log.Fatal(err)
 			}
-			err = buildRepositoryConfigurationFiles(codacyRepositoryToken)
-			if err != nil {
-				log.Fatal(err)
-			}
 		}
 		fmt.Println("Run install command to install dependencies.")
 	},
@@ -79,7 +78,7 @@ func configFileTemplate(tools []tools.Tool) string {
 	eslintVersion := "9.3.0"
 	trivyVersion := "0.59.1" // Latest stable version
 	pylintVersion := "3.3.6"
-
+	pmdVersion := "7.12.0"
 	for _, tool := range tools {
 		if tool.Uuid == "f8b29663-2cb2-498d-b923-a10c6a8c05cd" {
 			eslintVersion = tool.Version
@@ -99,7 +98,8 @@ tools:
     - eslint@%s
     - trivy@%s
     - pylint@%s
-`, eslintVersion, trivyVersion, pylintVersion)
+	- pmd@%s
+`, eslintVersion, trivyVersion, pylintVersion, pmdVersion)
 }
 
 func buildRepositoryConfigurationFiles(token string) error {

cmd/install.go

@@ -4,7 +4,6 @@ import (
 	cfg "codacy/cli-v2/config"
 	config_file "codacy/cli-v2/config-file"
 	"fmt"
-	"io"
 	"log"
 	"os"
 	"time"
@@ -15,9 +14,11 @@ import (
 )
 
 var registry string
+var codacyRepositoryToken string
 
 func init() {
 	installCmd.Flags().StringVarP(&registry, "registry", "r", "", "Registry to use for installing tools")
+	installCmd.Flags().StringVar(&codacyRepositoryToken, "repository-token", "", "Codacy repository token for fetching tool configurations")
 	rootCmd.AddCommand(installCmd)
 }
 
@@ -29,12 +30,16 @@ var installCmd = &cobra.Command{
 		bold := color.New(color.Bold)
 		green := color.New(color.FgGreen)
 
-		// Initialize config
+		// Initialize config global object
 		cfg.Init()
 
 		// Load config file
 		if err := config_file.ReadConfigFile(cfg.Config.ProjectConfigFile()); err != nil {
-			log.Fatalf("Failed to load config file: %v", err)
+			fmt.Println()
+			color.Red("⚠️  Warning: Could not find configuration file!")
+			fmt.Println("Please run 'codacy-cli init' first to create a configuration file.")
+			fmt.Println()
+			os.Exit(1)
 		}
 
 		// Check if anything needs to be installed
@@ -119,13 +124,7 @@ var installCmd = &cobra.Command{
 			}),
 		)
 
-		// Redirect all output to /dev/null during installation
-		oldStdout := os.Stdout
-		devNull, _ := os.Open(os.DevNull)
-		os.Stdout = devNull
-		log.SetOutput(io.Discard)
-
-		// Install runtimes
+		// Install runtimes first
 		for name, runtime := range cfg.Config.Runtimes() {
 			if !cfg.Config.IsRuntimeInstalled(name, runtime) {
 				progressBar.Describe(fmt.Sprintf("Installing runtime: %s v%s...", name, runtime.Version))
@@ -149,11 +148,6 @@ var installCmd = &cobra.Command{
 			}
 		}
 
-		// Restore output
-		os.Stdout = oldStdout
-		devNull.Close()
-		log.SetOutput(os.Stderr)
-
 		// Print completion status
 		fmt.Println()
 		for name, runtime := range cfg.Config.Runtimes() {

config/config.go

@@ -1,6 +1,7 @@
 package config
 
 import (
+	"fmt"
 	"log"
 	"os"
 	"path/filepath"
@@ -82,30 +83,11 @@ func (c *ConfigType) AddTools(configs []plugins.ToolConfig) error {
 	return nil
 }
 
-func (c *ConfigType) initCodacyDirs() {
+func (c *ConfigType) setupCodacyPaths() {
 	c.codacyDirectory = filepath.Join(c.homePath, ".cache", "codacy")
-	err := os.MkdirAll(c.codacyDirectory, 0777)
-	if err != nil {
-		log.Fatal(err)
-	}
-
 	c.runtimesDirectory = filepath.Join(c.codacyDirectory, "runtimes")
-	err = os.MkdirAll(c.runtimesDirectory, 0777)
-	if err != nil {
-		log.Fatal(err)
-	}
-
 	c.toolsDirectory = filepath.Join(c.codacyDirectory, "tools")
-	err = os.MkdirAll(c.toolsDirectory, 0777)
-	if err != nil {
-		log.Fatal(err)
-	}
-
 	c.localCodacyDirectory = ".codacy"
-	err = os.MkdirAll(c.localCodacyDirectory, 0777)
-	if err != nil {
-		log.Fatal(err)
-	}
 
 	yamlPath := filepath.Join(c.localCodacyDirectory, "codacy.yaml")
 	ymlPath := filepath.Join(c.localCodacyDirectory, "codacy.yml")
@@ -117,19 +99,43 @@ func (c *ConfigType) initCodacyDirs() {
 	}
 }
 
+func (c *ConfigType) createCodacyDirs() error {
+	if err := os.MkdirAll(c.codacyDirectory, 0777); err != nil {
+		return fmt.Errorf("failed to create codacy directory: %w", err)
+	}
+
+	if err := os.MkdirAll(c.runtimesDirectory, 0777); err != nil {
+		return fmt.Errorf("failed to create runtimes directory: %w", err)
+	}
+
+	if err := os.MkdirAll(c.toolsDirectory, 0777); err != nil {
+		return fmt.Errorf("failed to create tools directory: %w", err)
+	}
+
+	if err := os.MkdirAll(c.localCodacyDirectory, 0777); err != nil {
+		return fmt.Errorf("failed to create local codacy directory: %w", err)
+	}
+
+	return nil
+}
+
 func Init() {
 	homePath, err := os.UserHomeDir()
 	if err != nil {
 		log.Fatal(err)
 	}
 	Config.homePath = homePath
 
-	Config.initCodacyDirs()
-
+	Config.setupCodacyPaths()
 	Config.runtimes = make(map[string]*plugins.RuntimeInfo)
 	Config.tools = make(map[string]*plugins.ToolInfo)
 }
 
+// EnsureDirectories creates all necessary Codacy directories if they don't exist
+func EnsureDirectories() error {
+	return Config.createCodacyDirs()
+}
+
 // IsRuntimeInstalled checks if a runtime is already installed
 func (c *ConfigType) IsRuntimeInstalled(name string, runtime *plugins.RuntimeInfo) bool {
 	// If there are no binaries, check the install directory