fix toolname comparison during the analysis (#172)

* in analyse.go we now compare the tool name with the shortName (i.e. pmd 7.16.0 should be pmd-7 instead of pmd, which is version 6)

* we now translate the name of pmd according to the tool, the same as eslint: pmd 7.16.0 should be called as pmd-7 and pmd 6.55.0 should be called pmd

Author: DMarinhoCodacy

cmd/analyze.go

@@ -245,7 +245,7 @@ func loadsToolAndPatterns(toolName string, onlyEnabledPatterns bool) (domain.Too
 	}
 	var tool domain.Tool
 	for _, t := range toolsResponse {
-		if t.Name == toolName {
+		if t.ShortName == toolName {
 			tool = t
 			break
 		}
@@ -260,9 +260,8 @@ func loadsToolAndPatterns(toolName string, onlyEnabledPatterns bool) (domain.Too
 }
 
 func getToolName(toolName string, version string) string {
-
+	majorVersion := getMajorVersion(version)
 	if toolName == "eslint" {
-		majorVersion := getMajorVersion(version)
 		switch majorVersion {
 		case 7:
 			return "eslint"
@@ -271,7 +270,15 @@ func getToolName(toolName string, version string) string {
 		case 9:
 			return "eslint-9"
 		}
-
+	} else {
+		if toolName == "pmd" {
+			switch majorVersion {
+			case 6:
+				return "pmd"
+			case 7:
+				return "pmd-7"
+			}
+		}
 	}
 
 	return toolName

cmd/analyze_test.go

@@ -56,6 +56,39 @@ func TestGetFileExtension(t *testing.T) {
 	}
 }
 
+func TestGetToolName(t *testing.T) {
+	tests := []struct {
+		name     string
+		tool     string
+		version  string
+		expected string
+	}{
+		// ESLint cases
+		{"eslint v7", "eslint", "7.32.0", "eslint"},
+		{"eslint v8", "eslint", "8.15.0", "eslint-8"},
+		{"eslint v9", "eslint", "9.1.0", "eslint-9"},
+		{"eslint unknown version", "eslint", "10.0.0", "eslint"},
+
+		// PMD cases
+		{"pmd v6", "pmd", "6.55.0", "pmd"},
+		{"pmd v7", "pmd", "7.0.0", "pmd-7"},
+		{"pmd unknown version", "pmd", "8.0.0", "pmd"},
+
+		// Other tools should remain unchanged
+		{"unknown tool", "bandit", "1.7.4", "bandit"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := getToolName(tt.tool, tt.version)
+			if got != tt.expected {
+				t.Errorf("getToolName(%q, %q) = %q; want %q",
+					tt.tool, tt.version, got, tt.expected)
+			}
+		})
+	}
+}
+
 func TestIsToolSupportedForFile(t *testing.T) {
 	langConfig := &LanguagesConfig{
 		Tools: []struct {