refactor: change created files permission (#61)

-create reusable static for file permissons 
-align files and dirs creation with that permissons

Author: andrzej-janczak

cmd/init.go

@@ -313,12 +313,12 @@ func createToolFileConfigurations(tool tools.Tool, patternConfiguration []domain
 
 func createPMDConfigFile(config []domain.PatternConfiguration, toolsConfigDir string) error {
 	pmdConfigurationString := tools.CreatePmdConfig(config)
-	return os.WriteFile(filepath.Join(toolsConfigDir, "pmd-ruleset.xml"), []byte(pmdConfigurationString), utils.DefaultRW)
+	return os.WriteFile(filepath.Join(toolsConfigDir, "pmd-ruleset.xml"), []byte(pmdConfigurationString), utils.DefaultFilePerms)
 }
 
 func createDefaultPMDConfigFile(toolsConfigDir string) error {
 	content := tools.CreatePmdConfig([]domain.PatternConfiguration{})
-	return os.WriteFile(filepath.Join(toolsConfigDir, "pmd-ruleset.xml"), []byte(content), utils.DefaultRW)
+	return os.WriteFile(filepath.Join(toolsConfigDir, "pmd-ruleset.xml"), []byte(content), utils.DefaultFilePerms)
 }
 
 // createTrivyConfigFile creates a trivy.yaml configuration file based on the API configuration
@@ -327,7 +327,7 @@ func createTrivyConfigFile(config []domain.PatternConfiguration, toolsConfigDir
 	trivyConfigurationString := tools.CreateTrivyConfig(config)
 
 	// Write to file
-	return os.WriteFile(filepath.Join(toolsConfigDir, "trivy.yaml"), []byte(trivyConfigurationString), utils.DefaultRW)
+	return os.WriteFile(filepath.Join(toolsConfigDir, "trivy.yaml"), []byte(trivyConfigurationString), utils.DefaultFilePerms)
 }
 
 // createDefaultTrivyConfigFile creates a default trivy.yaml configuration file
@@ -337,7 +337,7 @@ func createDefaultTrivyConfigFile(toolsConfigDir string) error {
 	content := tools.CreateTrivyConfig(emptyConfig)
 
 	// Write to file
-	return os.WriteFile(filepath.Join(toolsConfigDir, "trivy.yaml"), []byte(content), utils.DefaultRW)
+	return os.WriteFile(filepath.Join(toolsConfigDir, "trivy.yaml"), []byte(content), utils.DefaultFilePerms)
 }
 
 // createDefaultEslintConfigFile creates a default eslint.config.mjs configuration file
@@ -347,7 +347,7 @@ func createDefaultEslintConfigFile(toolsConfigDir string) error {
 	content := tools.CreateEslintConfig(emptyConfig)
 
 	// Write to file
-	return os.WriteFile(filepath.Join(toolsConfigDir, "eslint.config.mjs"), []byte(content), utils.DefaultRW)
+	return os.WriteFile(filepath.Join(toolsConfigDir, "eslint.config.mjs"), []byte(content), utils.DefaultFilePerms)
 }
 
 const (

config/config.go

@@ -7,6 +7,7 @@ import (
 	"path/filepath"
 
 	"codacy/cli-v2/plugins"
+	"codacy/cli-v2/utils"
 )
 
 type ConfigType struct {
@@ -109,22 +110,22 @@ func (c *ConfigType) setupCodacyPaths() {
 }
 
 func (c *ConfigType) CreateCodacyDirs() error {
-	if err := os.MkdirAll(c.globalCacheDirectory, 0777); err != nil {
+	if err := os.MkdirAll(c.globalCacheDirectory, utils.DefaultDirPerms); err != nil {
 		return fmt.Errorf("failed to create codacy directory: %w", err)
 	}
 
-	if err := os.MkdirAll(c.runtimesDirectory, 0777); err != nil {
+	if err := os.MkdirAll(c.runtimesDirectory, utils.DefaultDirPerms); err != nil {
 		return fmt.Errorf("failed to create runtimes directory: %w", err)
 	}
 
-	if err := os.MkdirAll(c.toolsDirectory, 0777); err != nil {
+	if err := os.MkdirAll(c.toolsDirectory, utils.DefaultDirPerms); err != nil {
 		return fmt.Errorf("failed to create tools directory: %w", err)
 	}
 	return nil
 }
 
 func (c *ConfigType) CreateLocalCodacyDir() error {
-	if err := os.MkdirAll(c.localCodacyDirectory, 0777); err != nil {
+	if err := os.MkdirAll(c.localCodacyDirectory, utils.DefaultDirPerms); err != nil {
 		return fmt.Errorf("failed to create local codacy directory: %w", err)
 	}
 	return nil

config/runtimes-installer_test.go

@@ -2,6 +2,7 @@ package config
 
 import (
 	"codacy/cli-v2/plugins"
+	"codacy/cli-v2/utils"
 	"os"
 	"path/filepath"
 	"testing"
@@ -26,7 +27,7 @@ func TestIsRuntimeInstalled(t *testing.T) {
 	assert.False(t, isRuntimeInstalled(runtimeInfoNoBinaries))
 
 	// Create the install directory
-	err = os.MkdirAll(runtimeInfoNoBinaries.InstallDir, 0755)
+	err = os.MkdirAll(runtimeInfoNoBinaries.InstallDir, utils.DefaultDirPerms)
 	assert.NoError(t, err)
 
 	// Test when the install directory exists
@@ -52,4 +53,4 @@ func TestIsRuntimeInstalled(t *testing.T) {
 
 	// Test when the binary exists
 	assert.True(t, isRuntimeInstalled(runtimeInfoWithBinaries))
-}
+}

utils/extract.go

@@ -25,7 +25,7 @@ func ExtractTarGz(archive *os.File, targetDir string) error {
 		switch f.IsDir() {
 		case true:
 			// create a directory
-			err := os.MkdirAll(path, 0777)
+			err := os.MkdirAll(path, DefaultDirPerms)
 			if err != nil {
 				return err
 			}
@@ -37,9 +37,8 @@ func ExtractTarGz(archive *os.File, targetDir string) error {
 				return nil
 			}
 
-
 			// Ensure parent directory exists
-			err := os.MkdirAll(filepath.Dir(path), 0777)
+			err := os.MkdirAll(filepath.Dir(path), DefaultDirPerms)
 			if err != nil {
 				return err
 			}
@@ -74,7 +73,7 @@ func ExtractTarGz(archive *os.File, targetDir string) error {
 		os.Remove(path)
 
 		// Ensure parent directory exists
-		err := os.MkdirAll(filepath.Dir(path), 0777)
+		err := os.MkdirAll(filepath.Dir(path), DefaultDirPerms)
 		if err != nil {
 			return err
 		}
@@ -99,7 +98,7 @@ func ExtractZip(zipPath string, targetDir string) error {
 		switch f.IsDir() {
 		case true:
 			// create a directory
-			err := os.MkdirAll(path, 0777)
+			err := os.MkdirAll(path, DefaultDirPerms)
 			if err != nil {
 				return err
 			}
@@ -116,7 +115,7 @@ func ExtractZip(zipPath string, targetDir string) error {
 			}
 
 			// ensure parent directory exists
-			err := os.MkdirAll(filepath.Dir(path), 0777)
+			err := os.MkdirAll(filepath.Dir(path), DefaultDirPerms)
 			if err != nil {
 				return err
 			}

utils/files.go

@@ -7,7 +7,7 @@ const (
 	// - read/write (rw-) permissions to the owner
 	// - read-only (r--) permissions to the group
 	// - read-only (r--) permissions to others
-	DefaultRW = 0644
+	DefaultFilePerms = 0644
 
 	// DefaultDirPerms represents the default directory permission (rwxr-xr-x)
 	// This permission gives: