Drop akka dependency (#9)

Drop akka dependency

Author: mrfyda

build.sbt

@@ -6,7 +6,7 @@ name := """codacy-engine-scala-seed"""
 
 organization := "com.codacy"
 
-version := "2.7.0"
+version := "2.7.1"
 
 scalaVersion := "2.11.8"
 
@@ -19,7 +19,6 @@ resolvers += "Bintray Typesafe Repo" at "http://dl.bintray.com/typesafe/maven-re
 libraryDependencies ++= Seq(
   "com.typesafe.play" %% "play-json" % "2.4.8",
   "org.scalatest" %% "scalatest" % "2.2.4" % "test",
-  "com.typesafe.akka" %% "akka-actor" % "2.3.14",
   "com.codacy" %% "codacy-plugins-api" % "0.1.2" withSources(),
   "com.github.pathikrit" %% "better-files" % "2.14.0" withSources()
 )

circle.yml

@@ -2,9 +2,17 @@ machine:
   java:
     version: oraclejdk8
 
+dependencies:
+  pre:
+    - wget -q https://dl.bintray.com/sbt/debian/sbt-0.13.12.deb
+    - sudo dpkg -i sbt-0.13.12.deb
+  cache_directories:
+    - "~/.ivy2"
+    - "~/.sbt"
+
 test:
   override:
     - sbt clean coverage test
     - sbt coverageReport
     - sbt coverageAggregate
-    - sbt codacyCoverage
+    - sbt codacyCoverage

src/main/scala/codacy/dockerApi/DockerEngine.scala

@@ -2,31 +2,27 @@ package codacy.dockerApi
 
 import java.nio.file.Paths
 
-import akka.actor.ActorSystem
 import codacy.docker.api.{Source, Result => NewResult}
 import codacy.dockerApi.DockerEnvironment._
+import codacy.dockerApi.utils.Delayed
 import play.api.libs.json.{Json, Writes}
 
-import scala.concurrent.ExecutionContext
 import scala.concurrent.duration._
 import scala.util.{Failure, Success, Try}
 
-abstract class DockerEngine(Tool: codacy.docker.api.Tool) {
-
-  lazy val sys = ActorSystem("timeoutSystem")
+abstract class DockerEngine(Tool: codacy.docker.api.Tool) extends Delayed {
 
   def initTimeout(duration: FiniteDuration) = {
-    implicit val ct: ExecutionContext = sys.dispatcher
-    sys.scheduler.scheduleOnce(duration) {
+    delay(duration) {
       Runtime.getRuntime.halt(2)
     }
   }
 
-  lazy val timeout = Option(System.getProperty("timeout")).flatMap { case rawDuration =>
+  lazy val timeout = Option(System.getProperty("timeout")).flatMap { rawDuration =>
     Try(Duration(rawDuration)).toOption.collect { case d: FiniteDuration => d }
   }.getOrElse(10.minutes)
 
-  lazy val isDebug = Option(System.getProperty("debug")).flatMap { case rawDebug =>
+  lazy val isDebug = Option(System.getProperty("debug")).flatMap { rawDebug =>
     Try(rawDebug.toBoolean).toOption
   }.getOrElse(false)
 
@@ -57,13 +53,13 @@ abstract class DockerEngine(Tool: codacy.docker.api.Tool) {
         files <- config.files
       } yield {
         //TODO: i see a problem with the .toString here, also convert it to better-files ops please!
-        files.map { case file => file.copy(path = sourcePath.path.resolve(Paths.get(file.path)).toString) }
+        files.map { file => file.copy(path = sourcePath.path.resolve(Paths.get(file.path)).toString) }
       }
 
       log("tool started")
       // We need to catch Throwable here to avoid JVM crashes
       // Crashes can lead to docker not exiting properly
-      val res = (try {
+      val res = try {
         Tool.apply(
           source = Source.Directory(sourcePath.toString()),
           configuration = patternsOpt,
@@ -72,7 +68,7 @@ abstract class DockerEngine(Tool: codacy.docker.api.Tool) {
       } catch {
         case t: Throwable =>
           Failure(t)
-      })
+      }
 
       res match {
         case Success(results) =>

src/main/scala/codacy/dockerApi/utils/Delayed.scala

@@ -0,0 +1,22 @@
+package codacy.dockerApi.utils
+
+import java.util.{Timer, TimerTask}
+
+import scala.concurrent.{Future, Promise}
+import scala.concurrent.duration.Duration
+import scala.util.Try
+
+trait Delayed {
+
+  def delay[T](delay: Duration)(block: => T): Future[T] = {
+    val promise = Promise[T]()
+    val t = new Timer()
+    t.schedule(new TimerTask {
+      override def run(): Unit = {
+        promise.complete(Try(block))
+      }
+    }, delay.toMillis)
+    promise.future
+  }
+
+}

src/test/scala/codacy/dockerApi/utils/DelayedTest.scala

@@ -0,0 +1,28 @@
+package codacy.dockerApi.utils
+
+import org.scalatest._
+
+import scala.concurrent.duration._
+import scala.concurrent.{Await, TimeoutException}
+
+class DelayedTest extends FlatSpec with Matchers with Delayed {
+
+  "DelayedTest" should "should throw exception" in {
+    an[TimeoutException] should be thrownBy {
+      val f = delay(1.seconds) {
+        throw new TimeoutException("Execution timeout")
+      }
+
+      Await.result(f, Duration.Inf)
+    }
+  }
+
+  it should "shouldn't throw exception" in {
+    delay(2.seconds) {
+      fail("That expression shouldn't have thrown a MyExceptionType exception")
+    }
+  }
+
+}
+
+