fix: Remove apitoken from logs #45
Conversation
Codacy's Analysis Summary0 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
1 similar comment
Codacy's Analysis Summary0 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
There was a problem hiding this comment.
Pull request overview
This PR addresses a security concern by removing sensitive API token information from log statements. The change prevents the API token from being exposed in application logs, which could lead to unauthorized access if logs are compromised.
- Removed API token from the debug log statement in
Api.kt - Added
.DS_Storeto.gitignorefor better macOS compatibility
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/com/codacy/intellij/plugin/services/api/Api.kt | Removed API token from println statement while preserving the URL for debugging purposes |
| .gitignore | Added .DS_Store to ignore macOS system files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| config.init() | ||
| val url = URL("$baseUrl/$endpointUrl") | ||
| println("URL: $url TOKEN: $apiToken") | ||
| println("Request URL: $url") |
There was a problem hiding this comment.
Using println for logging in production code is not recommended. Consider using the Logger class (already imported in this file) instead:
Logger.info("Request URL: $url")This ensures consistent logging throughout the application and allows better control over log levels and output.
| println("Request URL: $url") | |
| Logger.info("Request URL: $url") |
No description provided.