gpt: Automated pattern documentation updates

Author: nicklem

docs/description/description.json

@@ -1,14 +1,14 @@
 [
   {
     "patternId": "rulesets-cleancode.xml-ElseExpression",
-    "title": "Avoid else expressions",
-    "description": "Use return statements instead of else expression",
+    "title": "Avoid Unnecessary Else Blocks Using Early Returns",
+    "description": "Replace else blocks with early return statements.",
     "timeToFix": 15
   },
   {
     "patternId": "rulesets-cleancode.xml-StaticAccess",
-    "title": "Avoid static access",
-    "description": "Static access leads to hard to test code",
+    "title": "Avoid Static Access to Class Members",
+    "description": "Use constructor injection for better testability and maintainability.",
     "timeToFix": 15,
     "parameters": [
       {
@@ -19,8 +19,8 @@
   },
   {
     "patternId": "rulesets-codesize.xml-CyclomaticComplexity",
-    "title": "Cyclomatic complexity",
-    "description": "This pattern reports methods with high cyclomatic complexity",
+    "title": "Measure and Control Cyclomatic Complexity",
+    "description": "Assess and reduce method decision points.",
     "parameters": [
       {
         "name": "reportLevel",

docs/description/rulesets-cleancode.xml-ElseExpression.md

@@ -1,30 +1,16 @@
-
-Instead of using an else block, you can use an early return statement:
-
-    class Foo
-    {
-        public function bar($flag)
-        {
-            if ($flag) {
-                // one branch
-            } else {
-                // another branch
-            }
-        }
-    }
-
-Rewrite without the else:
-
-    class Foo
-    {
-        public function bar($flag)
-        {
-            if ($flag) {
-                // one branch
-                return;
-            }
-
-            // another branch
-        }
-    }
-      
+Improves readability by removing else blocks when early returns suffice. Transform code like:
+```
+if ($flag) {
+    // one branch
+} else {
+    // another branch
+}
+```
+to:
+```
+if ($flag) {
+    // one branch
+    return;
+}
+// another branch
+```

docs/description/rulesets-cleancode.xml-StaticAccess.md

@@ -1,6 +1,23 @@
+Using static access increases dependencies and makes code hard to test. Instead, inject dependencies through the constructor. Example of the issue:
+```
+class Example {
+    public function doSomething() {
+        $dependency = Foo::getInstance(); // static access
+        // ...
+    }
+}
+```
+Solution:
+```
+class Example {
+    private $dependency;
+    
+    public function __construct(Foo $dependency) {
+        $this->dependency = $dependency;
+    }
 
- Static access increases dependencies and leads to hard to test code. You should instead
- inject dependencies through the constructor
-
- [Source](http://phpmd.org/rules/cleancode.html#staticaccess)
-      
+    public function doSomething() {
+        // Use $this->dependency
+    }
+}
+```

docs/description/rulesets-codesize.xml-CyclomaticComplexity.md

@@ -1,18 +1,12 @@
-
-Cyclomatic complexity is determined by the number of decision points in a method plus one for the method entry.
-The following keywords create new decision points: 'if', 'while', 'for', and 'case labels'. For example, this
-code has a cyclomatic complexity level of 2:
-
-    function foo()
-    {
-        $t=date("H");
-        if ($t<"20")
-        {
-            echo "Have a good day!";
-        }
+Cyclomatic complexity evaluates the number of decision points in a method. Keep complexity between 1-4 for low, 5-7 for moderate, 8-10 for high, and 11+ for very high complexity. Aim to refactor methods exceeding a complexity level of 10.
+
+Example:
+```
+function foo() {
+    $t = date("H");
+    if ($t < "20") {
+        echo "Have a good day!";
     }
-
-1-4 indicates low complexity, 5-7 medium complexity, 8-10 high complexity and 11+ indicates very high complexity.
-
-[Source](http://phpmd.org/rules/codesize.html#cyclomaticcomplexity)
-      
+}
+// Complexity: 2
+```

docs/patterns.json

@@ -5,16 +5,16 @@
     {
       "patternId": "rulesets-cleancode.xml-ElseExpression",
       "category": "CodeStyle",
-      "title": "Avoid else expressions",
-      "description": "Use return statements instead of else expression",
+      "title": "Avoid Unnecessary Else Blocks Using Early Returns",
+      "description": "Replace else blocks with early return statements.",
       "level": "Info",
       "enabled": true
     },
     {
       "patternId": "rulesets-cleancode.xml-StaticAccess",
       "category": "CodeStyle",
-      "title": "Avoid static access",
-      "description": "Static access leads to hard to test code",
+      "title": "Avoid Static Access to Class Members",
+      "description": "Use constructor injection for better testability and maintainability.",
       "level": "Info",
       "parameters": [
         {
@@ -75,8 +75,8 @@
     {
       "patternId": "rulesets-codesize.xml-CyclomaticComplexity",
       "category": "CodeStyle",
-      "title": "Cyclomatic complexity",
-      "description": "This pattern reports methods with high cyclomatic complexity",
+      "title": "Measure and Control Cyclomatic Complexity",
+      "description": "Assess and reduce method decision points.",
       "parameters": [
         {
           "name": "reportLevel",