fix: do not assume errors on the CLI (#81)

alerizzo · web-flow · commit c033fd117376 · 2025-05-13T13:50:11.000+01:00
diff --git a/src/commands/installAnalysisCLI.ts b/src/commands/installAnalysisCLI.ts
@@ -30,7 +30,7 @@ const execAsync = (command: string) => {
           return
         }
 
-        if (stderr && (!stdout || /error|fail|exception/i.test(stderr))) {
+        if (stderr && !stdout) {
           reject(new Error(stderr))
           return
         }
diff --git a/src/commands/runCodacyAnalyze.ts b/src/commands/runCodacyAnalyze.ts
@@ -50,7 +50,7 @@ export async function runCodacyAnalyze(filePath?: string) {
             return
           }
 
-          if (stderr && (!stdout || /error|fail|exception/i.test(stderr))) {
+          if (stderr && !stdout) {
             Logger.warn(`Codacy CLI V2 warnings: ${stderr}`)
           }
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ const execAsync = (command: string) => {`
`30`	`30`	`return`
`31`	`31`	`}`
`32`	`32`
`33`		`- if (stderr && (!stdout \|\| /error\|fail\|exception/i.test(stderr))) {`
	`33`	`+ if (stderr && !stdout) {`
`34`	`34`	`reject(new Error(stderr))`
`35`	`35`	`return`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ export async function runCodacyAnalyze(filePath?: string) {`
`50`	`50`	`return`
`51`	`51`	`}`
`52`	`52`
`53`		`- if (stderr && (!stdout \|\| /error\|fail\|exception/i.test(stderr))) {`
	`53`	`+ if (stderr && !stdout) {`
`54`	`54`	Logger.warn(`Codacy CLI V2 warnings: ${stderr}`)
`55`	`55`	`}`
`56`	`56`