Skip to content

Commit 4301d3b

Browse files
authored
Merge pull request #55 from codacy/avoid-printing-docker-login
fix: Avoid printing docker password to stdout
2 parents 0b43e24 + 0709ab2 commit 4301d3b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@ clean: ## clean target directories
3535

3636
.PHONY: push-docker-image
3737
push-docker-image: ## push the docker image to the registry (DOCKER_USER and DOCKER_PASS mandatory)
38-
docker login -u $(DOCKER_USER) -p $(DOCKER_PASS) &&\
38+
@docker login -u $(DOCKER_USER) -p $(DOCKER_PASS) &&\
3939
docker push codacy/git-version:${VERSION}
4040

4141
.PHONY: push-latest-docker-image
4242
push-latest-docker-image: ## push the docker image with the "latest" tag to the registry (DOCKER_USER and DOCKER_PASS mandatory)
43-
docker login -u $(DOCKER_USER) -p $(DOCKER_PASS) &&\
43+
@docker login -u $(DOCKER_USER) -p $(DOCKER_PASS) &&\
4444
docker tag codacy/git-version:${VERSION} codacy/git-version:latest &&\
4545
docker push codacy/git-version:latest
4646

0 commit comments

Comments
 (0)