-
Notifications
You must be signed in to change notification settings - Fork 48
Open
Labels
jira-issueIssue tracked on JIRAIssue tracked on JIRA
Description
see https://www.shellcheck.net/wiki/SC2155
so this command
export PREVIOUS_VERSION=$(git-version \
--previous-version \
--release-branch "${{ inputs.release-branch }}" \
--dev-branch "${{ inputs.dev-branch }}" \
--minor-identifier="${{ inputs.minor-identifier }}" \
--major-identifier="${{ inputs.major-identifier }}" \
--version-prefix "${{ inputs.prefix }}")
means that the step still succeeds even if the git-version
errors for whatever reason (in our case we forgot actions/checkout
step, which caused git-version
to fail with [ERROR] Command git describe --tags failed. (Exception)
).
In fact in this action there is no need for export
at all, as it's only used in subsequent bash commands so it would still work
Metadata
Metadata
Assignees
Labels
jira-issueIssue tracked on JIRAIssue tracked on JIRA