Skip to content

[TCE-1171] export command cause error to be swallowed #97

@jackie-linz

Description

@jackie-linz

see https://www.shellcheck.net/wiki/SC2155

so this command

        export PREVIOUS_VERSION=$(git-version \
            --previous-version \
            --release-branch "${{ inputs.release-branch }}" \
            --dev-branch "${{ inputs.dev-branch }}" \
            --minor-identifier="${{ inputs.minor-identifier }}" \
            --major-identifier="${{ inputs.major-identifier }}" \
            --version-prefix "${{ inputs.prefix }}")

means that the step still succeeds even if the git-version errors for whatever reason (in our case we forgot actions/checkout step, which caused git-version to fail with [ERROR] Command git describe --tags failed. (Exception)).

In fact in this action there is no need for export at all, as it's only used in subsequent bash commands so it would still work

Metadata

Metadata

Assignees

No one assigned

    Labels

    jira-issueIssue tracked on JIRA

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions