Removes ja_resource dependency from OrganizationInviteController (#1051)

Great work @lkoller 

I went ahead and merged this for you, so I can have an easier time rebasing a couple other branches.

Author: lkoller

lib/code_corps/policy/policy.ex

@@ -43,6 +43,8 @@ defmodule CodeCorps.Policy do
   defp can?(%User{} = current_user, :create, %ProjectUser{}, %{} = params), do: Policy.ProjectUser.create?(current_user, params)
   defp can?(%User{} = current_user, :update, %ProjectUser{} = project_user, %{} = params), do: Policy.ProjectUser.update?(current_user, project_user, params)
   defp can?(%User{} = current_user, :delete, %ProjectUser{} = project_user, %{}), do: Policy.ProjectUser.delete?(current_user, project_user)
+  defp can?(%User{} = current_user, :create, %OrganizationInvite{}, %{}), do: Policy.OrganizationInvite.create?(current_user)
+  defp can?(%User{} = current_user, :update, %OrganizationInvite{} = _invite, %{}), do: Policy.OrganizationInvite.update?(current_user)
   defp can?(%User{} = user, :delete,
     %OrganizationGithubAppInstallation{} = organization_github_app_installation, %{}),
       do: Policy.OrganizationGithubAppInstallation.delete?(user, organization_github_app_installation)
@@ -101,9 +103,6 @@ defmodule CodeCorps.Policy do
 
     def can?(%User{} = user, :create, %Changeset{data: %GithubAppInstallation{}} = changeset), do: Policy.GithubAppInstallation.create?(user, changeset)
 
-    def can?(%User{} = user, :create, OrganizationInvite), do: Policy.OrganizationInvite.create?(user)
-    def can?(%User{} = user, :update, %OrganizationInvite{}), do: Policy.OrganizationInvite.update?(user)
-
     def can?(%User{} = user, :create, %Changeset{data: %Preview{}} = changeset), do: Policy.Preview.create?(user, changeset)
 
     def can?(%User{} = user, :create, %Changeset{data: %ProjectCategory{}} = changeset), do: Policy.ProjectCategory.create?(user, changeset)

lib/code_corps_web/controllers/organization_invite_controller.ex

@@ -1,34 +1,53 @@
 defmodule CodeCorpsWeb.OrganizationInviteController do
   use CodeCorpsWeb, :controller
-  use JaResource
 
-  import CodeCorps.Helpers.Query, only: [id_filter: 2]
-  alias CodeCorps.{Emails, Mailer, OrganizationInvite}
+  alias CodeCorps.{Emails, Helpers.Query, Mailer, OrganizationInvite, User}
 
-  plug :load_and_authorize_resource, model: OrganizationInvite, only: [:create, :update]
-  plug JaResource
+  action_fallback CodeCorpsWeb.FallbackController
+  plug CodeCorpsWeb.Plug.DataToAttributes
+  plug CodeCorpsWeb.Plug.IdsToIntegers
 
-  @spec model :: module
-  def model, do: CodeCorps.OrganizationInvite
+  @spec index(Conn.t, map) :: Conn.t
+  def index(%Conn{} = conn, %{} = params) do
+    with organization_invites <- OrganizationInvite |> Query.id_filter(params) |> Repo.all do
+      conn |> render("index.json-api", data: organization_invites)
+    end
+  end
 
-  def filter(_conn, query, "id", id_list) do
-    query |> id_filter(id_list)
+  @spec show(Conn.t, map) :: Conn.t
+  def show(%Conn{} = conn, %{"id" => id}) do
+    with %OrganizationInvite{} = organization_invite <- OrganizationInvite |> Repo.get(id) do
+      conn |> render("show.json-api", data: organization_invite)
+    end
   end
 
-  def handle_create(_conn, attributes) do
-    OrganizationInvite.create_changeset(%OrganizationInvite{}, attributes)
+  @spec create(Plug.Conn.t, map) :: Conn.t
+  def create(%Conn{} = conn, %{} = params) do
+    with %User{} = current_user <- conn |> Guardian.Plug.current_resource,
+         {:ok, :authorized} <- current_user |> Policy.authorize(:create, %OrganizationInvite{}, params),
+         {:ok, %OrganizationInvite{} = organization_invite} <- %OrganizationInvite{} |> OrganizationInvite.create_changeset(params) |> Repo.insert do
+
+      send_email(organization_invite)
+
+      conn
+      |> put_status(:created)
+      |> render("show.json-api", data: organization_invite)
+    end
   end
 
-  def render_create(conn, model) do
-    send_email(model)
-    conn
-    |> put_status(:created)
-    |> Phoenix.Controller.render(:show, data: model)
+  @spec update(Conn.t, map) :: Conn.t
+  def update(%Conn{} = conn, %{"id" => id} = params) do
+    with %OrganizationInvite{} = organization_invite <- OrganizationInvite |> Repo.get(id),
+         %User{} = current_user <- conn |> Guardian.Plug.current_resource,
+         {:ok, :authorized} <- current_user |> Policy.authorize(:update, organization_invite),
+         {:ok, %OrganizationInvite{} = organization_invite} <- organization_invite |> OrganizationInvite.changeset(params) |> Repo.update do
+      conn |> render("show.json-api", data: organization_invite)
+    end
   end
 
   defp send_email(organization_invite) do
     organization_invite
     |> Emails.OrganizationInviteEmail.create()
     |> Mailer.deliver_later()
   end
-end
+end