Cleanup

Author: begedin

lib/code_corps/github/api/eager_api.ex

@@ -51,7 +51,7 @@ defmodule CodeCorps.GitHub.EagerAPI do
   end
 
   def retrieve_total_pages(headers) do
-    case headers |> IO.inspect |> List.keyfind("Link", 0, nil) do
+    case headers |> List.keyfind("Link", 0, nil) do
       nil -> 1
       {"Link", value} -> value |> extract_total_pages
     end
@@ -73,7 +73,6 @@ defmodule CodeCorps.GitHub.EagerAPI do
       |> URI.decode_query
       |> Map.get("page")
       |> String.to_integer
-      |> IO.inspect
   end
 
   defp process_page({nil, nil}, _, _) do

lib/code_corps/github/api/repository.ex

@@ -23,32 +23,35 @@ defmodule CodeCorps.GitHub.API.Repository do
   end
 
   defp fetch_issues(%GithubRepo{github_account_login: owner, name: repo}, access_token) do
+    path = "repos/#{owner}/#{repo}/issues"
+    opts = [access_token: access_token]
     # stream/lazy
 
     before_operation = Timex.now
-
-    results =
-      "repos/#{owner}/#{repo}/issues?per_page=8"
-      |> GitHub.lazy_get_all(%{}, [access_token: access_token])
-      |> Enum.to_list
-      |> List.flatten
-
+    results = path |> fetch_lazy(opts)
     after_operation = Timex.now
-
     IO.puts("Retrieving #{results |> Enum.count} took #{Timex.diff(after_operation, before_operation)} microseconds")
 
     # eager
 
     before_operation = Timex.now
+    results = path |> fetch_eager(opts)
+    after_operation = Timex.now
+    IO.puts("Retrieving #{results |> Enum.count} took #{Timex.diff(after_operation, before_operation)} microseconds")
 
-    results =
-      "repos/#{owner}/#{repo}/issues?per_page=8"
-      |> GitHub.eager_get_all(%{}, [access_token: access_token])
-      |> Enum.to_list
-      |> List.flatten
+    results
+  end
 
-    after_operation = Timex.now
+  defp fetch_lazy(path, opts) do
+    path
+    |> GitHub.lazy_get_all(%{}, opts)
+    |> Enum.to_list
+    |> List.flatten
+  end
 
-    IO.puts("Retrieving #{results |> Enum.count} took #{Timex.diff(after_operation, before_operation)} microseconds")
+  defp fetch_eager(path, opts) do
+    path
+    |> GitHub.eager_get_all(%{}, opts)
+    |> List.flatten
   end
 end