Add routes, abilities, controllers and tests for TaskSkills

Author: begedin

test/controllers/task_skill_controller_test.exs

@@ -0,0 +1,101 @@
+defmodule CodeCorps.TaskSkillControllerTest do
+  @moduledoc false
+
+  use CodeCorps.ApiCase, resource_name: :task_skill
+
+  describe "index" do
+    test "lists all entries on index", %{conn: conn} do
+      [task_skill_1, task_skill_2] = insert_pair(:task_skill)
+
+      conn
+      |> request_index
+      |> json_response(200)
+      |> assert_ids_from_response([task_skill_1.id, task_skill_2.id])
+    end
+
+    test "filters resources on index", %{conn: conn} do
+      [task_skill_1, task_skill_2 | _] = insert_list(3, :task_skill)
+
+      path = "task-skills/?filter[id]=#{task_skill_1.id},#{task_skill_2.id}"
+
+      conn
+      |> get(path)
+      |> json_response(200)
+      |> assert_ids_from_response([task_skill_1.id, task_skill_2.id])
+    end
+  end
+
+  describe "show" do
+    test "shows chosen resource", %{conn: conn} do
+      skill = insert(:skill)
+      task = insert(:task)
+      task_skill = insert(:task_skill, task: task, skill: skill)
+
+      conn
+      |> request_show(task_skill)
+      |> json_response(200)
+      |> Map.get("data")
+      |> assert_result_id(task_skill.id)
+    end
+
+    test "renders 404 error when id is nonexistent", %{conn: conn} do
+      assert conn |> request_show(:not_found) |> json_response(404)
+    end
+  end
+
+  describe "create" do
+    @tag :authenticated
+    test "creates and renders resource when data is valid", %{conn: conn, current_user: current_user} do
+      task = insert(:task, user: current_user)
+      skill = insert(:skill)
+
+      attrs = %{task: task, skill: skill}
+      assert conn |> request_create(attrs) |> json_response(201)
+    end
+
+    @tag :authenticated
+    test "renders 422 error when data is invalid", %{conn: conn, current_user: current_user} do
+      task = insert(:task, user: current_user)
+
+      invalid_attrs = %{task: task, skill: nil}
+      assert conn |> request_create(invalid_attrs) |> json_response(422)
+    end
+
+    test "renders 401 when unauthenticated", %{conn: conn} do
+      assert conn |> request_create |> json_response(401)
+    end
+
+    @tag :authenticated
+    test "renders 403 when not authorized", %{conn: conn} do
+      task = insert(:task)
+      skill = insert(:skill)
+      attrs = %{task: task, skill: skill}
+
+      assert conn |> request_create(attrs) |> json_response(403)
+    end
+  end
+
+  describe "delete" do
+    @tag :authenticated
+    test "deletes chosen resource", %{conn: conn, current_user: current_user} do
+      task = insert(:task, user: current_user)
+      task_skill = insert(:task_skill, task: task)
+
+      assert conn |> request_delete(task_skill) |> response(204)
+    end
+
+    test "renders 401 when unauthenticated", %{conn: conn} do
+      assert conn |> request_delete |> json_response(401)
+    end
+
+    @tag :authenticated
+    test "renders 403 when not authorized", %{conn: conn} do
+      assert conn |> request_delete |> json_response(403)
+    end
+
+    @tag :authenticated
+    test "renders 404 when id is nonexistent on delete", %{conn: conn} do
+      assert conn |> request_delete(:not_found) |> json_response(404)
+    end
+  end
+end

web/controllers/task_skill_controller.ex

@@ -0,0 +1,23 @@
+defmodule CodeCorps.TaskSkillController do
+  use CodeCorps.Web, :controller
+  use JaResource
+
+  import CodeCorps.Helpers.Query, only: [id_filter: 2]
+
+  alias CodeCorps.TaskSkill
+
+  plug :load_resource, model: TaskSkill, only: [:show], preload: [:task, :skill]
+  plug :load_and_authorize_changeset, model: TaskSkill, only: [:create]
+  plug :load_and_authorize_resource, model: TaskSkill, only: [:delete]
+  plug JaResource
+
+  @spec filter(Plug.Conn.t, Ecto.Query.t, String.t, list) :: Plug.Conn.t
+  def filter(_conn, query, "id", id_list) do
+    query |> id_filter(id_list)
+  end
+
+  @spec handle_create(Plug.Conn.t, map) :: Ecto.Changeset.t
+  def handle_create(_conn, attributes) do
+    %TaskSkill{} |> TaskSkill.create_changeset(attributes)
+  end
+end

web/models/abilities.ex

@@ -4,7 +4,6 @@ defmodule Canary.Abilities do
   alias CodeCorps.DonationGoal
   alias CodeCorps.Organization
   alias CodeCorps.OrganizationMembership
-  alias CodeCorps.Task
   alias CodeCorps.Preview
   alias CodeCorps.Project
   alias CodeCorps.ProjectCategory
@@ -17,6 +16,8 @@ defmodule Canary.Abilities do
   alias CodeCorps.StripeConnectSubscription
   alias CodeCorps.StripePlatformCard
   alias CodeCorps.StripePlatformCustomer
+  alias CodeCorps.Task
+  alias CodeCorps.TaskSkill
   alias CodeCorps.User
   alias CodeCorps.UserCategory
   alias CodeCorps.UserRole
@@ -28,7 +29,6 @@ defmodule Canary.Abilities do
   alias CodeCorps.DonationGoalPolicy
   alias CodeCorps.OrganizationPolicy
   alias CodeCorps.OrganizationMembershipPolicy
-  alias CodeCorps.TaskPolicy
   alias CodeCorps.PreviewPolicy
   alias CodeCorps.ProjectPolicy
   alias CodeCorps.ProjectCategoryPolicy
@@ -41,6 +41,8 @@ defmodule Canary.Abilities do
   alias CodeCorps.StripeConnectSubscriptionPolicy
   alias CodeCorps.StripePlatformCardPolicy
   alias CodeCorps.StripePlatformCustomerPolicy
+  alias CodeCorps.TaskPolicy
+  alias CodeCorps.TaskSkillPolicy
   alias CodeCorps.UserPolicy
   alias CodeCorps.UserCategoryPolicy
   alias CodeCorps.UserRolePolicy
@@ -78,9 +80,6 @@ defmodule Canary.Abilities do
     def can?(%User{} = user, :update, %Changeset{data: %OrganizationMembership{}} = changeset), do: OrganizationMembershipPolicy.update?(user, changeset)
     def can?(%User{} = user, :delete, %OrganizationMembership{} = membership), do: OrganizationMembershipPolicy.delete?(user, membership)
 
-    def can?(%User{} = user, :create, %Changeset{data: %Task{}} = changeset), do: TaskPolicy.create?(user, changeset)
-    def can?(%User{} = user, :update, %Task{} = task), do: TaskPolicy.update?(user, task)
-
     def can?(%User{} = user, :create, %Changeset{data: %Preview{}} = changeset), do: PreviewPolicy.create?(user, changeset)
 
     def can?(%User{} = user, :create, %Changeset{data: %Project{}} = changeset), do: ProjectPolicy.create?(user, changeset)
@@ -116,6 +115,12 @@ defmodule Canary.Abilities do
     def can?(%User{} = user, :create, %Changeset{data: %StripePlatformCustomer{}} = changeset), do: StripePlatformCustomerPolicy.create?(user, changeset)
     def can?(%User{} = user, :show, %StripePlatformCustomer{} = stripe_platform_customer), do: StripePlatformCustomerPolicy.show?(user, stripe_platform_customer)
 
+    def can?(%User{} = user, :create, %Changeset{data: %Task{}} = changeset), do: TaskPolicy.create?(user, changeset)
+    def can?(%User{} = user, :update, %Task{} = task), do: TaskPolicy.update?(user, task)
+
+    def can?(%User{} = user, :create, %Changeset{data: %TaskSkill{}} = changeset), do: TaskSkillPolicy.create?(user, changeset)
+    def can?(%User{} = user, :delete, %TaskSkill{} = task_skill), do: TaskSkillPolicy.delete?(user, task_skill)
+
     def can?(%User{} = user, :create, %Changeset{data: %UserCategory{}} = changeset), do: UserCategoryPolicy.create?(user, changeset)
     def can?(%User{} = user, :delete, %UserCategory{} = user_category), do: UserCategoryPolicy.delete?(user, user_category)
 

web/router.ex

@@ -74,6 +74,7 @@ defmodule CodeCorps.Router do
     resources "/stripe-platform-cards", StripePlatformCardController, only: [:show, :create]
     resources "/stripe-platform-customers", StripePlatformCustomerController, only: [:show, :create]
     resources "/tasks", TaskController, only: [:create, :update]
+    resources "/task-skills", TaskSkillController, only: [:create, :delete]
     resources "/users", UserController, only: [:update]
     resources "/user-categories", UserCategoryController, only: [:create, :delete]
     resources "/user-roles", UserRoleController, only: [:create, :delete]
@@ -105,6 +106,7 @@ defmodule CodeCorps.Router do
       resources "/tasks", TaskController, only: [:index, :show]
     end
     resources "/tasks", TaskController, only: [:index, :show]
+    resources "/task-skills", TaskSkillController, only: [:index, :show]
     get "/users/email_available", UserController, :email_available
     get "/users/username_available", UserController, :username_available
     resources "/users", UserController, only: [:index, :show, :create]