Skip to content

Commit 335d7dc

Browse files
feat: refactor. removes debug statement
1 parent 55e581e commit 335d7dc

File tree

3 files changed

+8
-12
lines changed

3 files changed

+8
-12
lines changed

lesson_26/api/java/api_app/src/main/java/com/codedifferently/lesson26/web/CreateMediaItemRequest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,5 @@
1414
@Builder
1515
public class CreateMediaItemRequest {
1616
@NotNull(message = "item is required") @Valid
17-
@JsonProperty("item")
1817
private MediaItemRequest item;
1918
}

lesson_26/api/java/api_app/src/main/java/com/codedifferently/lesson26/web/MediaItemRequest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,29 +19,21 @@
1919
@NoArgsConstructor
2020
@Builder
2121
public class MediaItemRequest {
22-
@JsonProperty("id")
2322
private UUID id;
2423

25-
@JsonProperty("type")
2624
private String type;
2725

28-
@JsonProperty("isbn")
2926
private String isbn;
3027

31-
@JsonProperty("title")
3228
@NotBlank(message = "Title is required")
3329
private String title;
3430

35-
@JsonProperty("authors")
3631
private String[] authors;
3732

38-
@JsonProperty("edition")
3933
private String edition;
4034

41-
@JsonProperty("pages")
4235
private int pages;
4336

44-
@JsonProperty("runtime")
4537
private int runtime;
4638

4739
public static MediaItem asMediaItem(MediaItemRequest request) {

lesson_26/api/java/api_app/src/main/java/com/codedifferently/lesson26/web/MediaItemsController.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import jakarta.validation.Valid;
88
import java.io.IOException;
99
import java.util.List;
10+
import java.util.Optional;
1011
import java.util.Set;
1112
import java.util.UUID;
1213
import org.springframework.http.ResponseEntity;
@@ -61,8 +62,6 @@ public CreateMediaItemResponse createMediaItem(@RequestBody @Valid CreateMediaIt
6162

6263
MediaItemRequest itemRequest = request.getItem();
6364

64-
System.out.println(request);
65-
6665
var item = MediaItemRequest.asMediaItem(itemRequest);
6766

6867
library.addMediaItem(item, librarian);
@@ -76,7 +75,13 @@ public CreateMediaItemResponse createMediaItem(@RequestBody @Valid CreateMediaIt
7675
@DeleteMapping("/items/{id}")
7776
public ResponseEntity<Void> deleteItem(@PathVariable("id") UUID id) {
7877

79-
if (getItemById(id).getBody() == null) {
78+
SearchCriteria query = new SearchCriteria();
79+
Set<MediaItem> items = library.search(query);
80+
Optional<MediaItem> item = items.stream()
81+
.filter(mediaItem -> mediaItem.getId().equals(id))
82+
.findFirst();
83+
84+
if (item.isEmpty()) {
8085
return ResponseEntity.notFound().build();
8186
}
8287

0 commit comments

Comments
 (0)