Skip to content

Commit 8cd4832

Browse files
author
AmiyahJo
committed
fix: fibonacciNumbers made , and comments for understanding
1 parent 2c2a9bc commit 8cd4832

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

lesson_07/conditionals/src/lesson7.ts

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export function convertGpaToLetterGrade(gpa: number): string {
7676
*/
7777
export function computeFactorial(n: number): number {
7878
if (n < 0){
79-
return -1
79+
return -1;
8080
} else if (n === 0){
8181
return 1;
8282
}
@@ -99,7 +99,7 @@ export function addNumbers(values: number[]): number {
9999
for (const value of values) {
100100
sum += value;
101101
}
102-
102+
103103
return sum;
104104
}
105105

@@ -110,10 +110,20 @@ export function addNumbers(values: number[]): number {
110110
* @return An array containing the first `n` Fibonacci values.
111111
*/
112112
export function getFirstNFibonacciNumbers(n: number): number[] {
113-
for (let i = 0; i < 9; i++) {
114-
console.log(n);
113+
const fibonacciNumbers: number[] = new Array(n); //New empty array with a list of n
114+
115+
for (let i = 0; i < n; i++) {
116+
if (i === 0){
117+
fibonacciNumbers[i] = 1; //1st number is 1
118+
} else if (i === 1){
119+
fibonacciNumbers[i] = 1; //2nd number is also 1
120+
} else {
121+
fibonacciNumbers[i] = fibonacciNumbers[i - 1] + fibonacciNumbers[i - 2];
122+
// current number = (previous number) + (number before that)
123+
}
115124
}
116-
return [];
125+
126+
return fibonacciNumbers;
117127
}
118128

119129
/**

0 commit comments

Comments
 (0)