fix: adds exception handling to files under the ecommerce folder for lesson_14 homework - Joseph Caballero #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on_14 homework - Joseph Caballero
…rors and seeking them in the right area. Lessons_14 ecommerce folder - Joseph Caballero
…ur specific application. lesson_14 - Joseph Caballero
…rocess for lesson_14 EcommerceSystem.java - Joseph Caballero
…4 -Joseph Caballero
anthonydmays
approved these changes
Oct 26, 2024
| * if the productId is matched up to the hashmap at all using get and if it doesnt exist then product will be null because no such key exists | ||
| * instead of trying to put it in every single instance we see an order id or product id our test cases check to see if the given | ||
| * input is even available for us to grab not if there is any input at all since that itself in my opinion would be front end and not us | ||
| * that would handle that sort of thing before it reaches this point |
There was a problem hiding this comment.
Think defensively. Don't assume that your consumers are always going to do the right thing. Throwing this exception will help consumers understand why the operation didn't work in case they did the wrong thing.
| Order order = orders.get(orderId); | ||
| // Since order is set at this exact moment all we need to do is check if the given id is in the |
There was a problem hiding this comment.
Use proper casing, grammar, and punctuation for your comments. Also, use shorter sentences for clarity. More importantly, I'd suggest that the code is clear enough on its own, so adding it just makes your reader have to do more work.
In general, only add comments to explain something that isn't immediately obvious in the code and that can't be made any simpler by rewriting the code itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added exception handling to files under the ecommerce folder for lesson_14 homework.