From c72933e9b6bf49bffe9846df5cdc11a9e51d3b72 Mon Sep 17 00:00:00 2001 From: "Anthony D. Mays" Date: Sat, 14 Dec 2024 19:10:36 +0000 Subject: [PATCH 1/7] chore: adds more build checks Signed-off-by: Anthony D. Mays --- .github/workflows/check_push.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/check_push.yml b/.github/workflows/check_push.yml index 92b5d99f8..dafc2ad55 100644 --- a/.github/workflows/check_push.yml +++ b/.github/workflows/check_push.yml @@ -4,6 +4,7 @@ on: push: branches: [ "main" ] paths: + - ".github/workflows/check_push.yml" - "lib/**" - "lesson_02/quiz/**" - "lesson_03/quiz/**" @@ -21,6 +22,9 @@ on: - "lesson_15/tdd/**" - "lesson_16/objects/**" - "lesson_17/bank/**" + - "lesson_26/api/**" +env: + CLERK_PERISHABLE_KEY: 12345 jobs: build: @@ -142,6 +146,16 @@ jobs: working-directory: ./lesson_17/bank run: ./gradlew check + - name: Build Lesson 26 with Java + working-directory: ./lesson_26/api/java + run: ./gradlew check + + - name: Build Lesson 26 with Node.js + working-directory: ./lesson_26/api/javascript/api_app + run: | + npm ci + npm run test + - name: Build Fullstack Demo with Java working-directory: ./lib/java/fullstack_demo run: ./gradlew check From 8f7a7d9d17fcaeb2ef2baba0a25e47c6f88aab48 Mon Sep 17 00:00:00 2001 From: "Anthony D. Mays" Date: Sat, 14 Dec 2024 19:11:39 +0000 Subject: [PATCH 2/7] chore: adds pr checks for fullstack demos. --- .../check_fullstack_demo_java_pr.yaml | 31 +++++++++++++++++++ .../workflows/check_fullstack_demo_ts_pr.yaml | 26 ++++++++++++++++ 2 files changed, 57 insertions(+) create mode 100644 .github/workflows/check_fullstack_demo_java_pr.yaml create mode 100644 .github/workflows/check_fullstack_demo_ts_pr.yaml diff --git a/.github/workflows/check_fullstack_demo_java_pr.yaml b/.github/workflows/check_fullstack_demo_java_pr.yaml new file mode 100644 index 000000000..a8bd9b25c --- /dev/null +++ b/.github/workflows/check_fullstack_demo_java_pr.yaml @@ -0,0 +1,31 @@ +name: Check Fullstack Demo Java Pull Request + +on: + pull_request: + branches: [ "main" ] + paths: + - "lib/java/fullstack_demo/**" + +env: + CLERK_PERISHABLE_KEY: 12345 + +jobs: + build: + + runs-on: ubuntu-latest + permissions: + contents: read + pull-requests: write + + steps: + - uses: actions/checkout@v4 + + - name: Set up JDK + uses: actions/setup-java@v4 + with: + java-version: '21' + distribution: 'temurin' + + - name: Build Fullstack Demo with Java + working-directory: ./lib/java/fullstack_demo + run: ./gradlew check \ No newline at end of file diff --git a/.github/workflows/check_fullstack_demo_ts_pr.yaml b/.github/workflows/check_fullstack_demo_ts_pr.yaml new file mode 100644 index 000000000..c90576cd8 --- /dev/null +++ b/.github/workflows/check_fullstack_demo_ts_pr.yaml @@ -0,0 +1,26 @@ +name: Check Fullstack Demo TS Pull Request + +on: + pull_request: + branches: [ "main" ] + paths: + - "lib/typescript/fullstack_demo/**" + +jobs: + build: + + runs-on: ubuntu-latest + permissions: + contents: read + + steps: + - uses: actions/checkout@v4 + + - name: Use Node.js + uses: actions/setup-node@v4 + with: + node-version: '20.x' + + - name: Build Fullstack Demo with Node.js + working-directory: ./lib/typescript/fullstack_demo + run: npm ci \ No newline at end of file From cf6f27ffae68d6a9aec72b93ed349e6e43964083 Mon Sep 17 00:00:00 2001 From: "Anthony D. Mays" Date: Sat, 14 Dec 2024 19:12:55 +0000 Subject: [PATCH 3/7] chore: ensures actions run when config is modded Signed-off-by: Anthony D. Mays --- .github/workflows/check_fullstack_demo_java_pr.yaml | 1 + .github/workflows/check_fullstack_demo_ts_pr.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/check_fullstack_demo_java_pr.yaml b/.github/workflows/check_fullstack_demo_java_pr.yaml index a8bd9b25c..1b12e831f 100644 --- a/.github/workflows/check_fullstack_demo_java_pr.yaml +++ b/.github/workflows/check_fullstack_demo_java_pr.yaml @@ -4,6 +4,7 @@ on: pull_request: branches: [ "main" ] paths: + - ".github/workflows/check_fullstack_demo_java_pr.yaml" - "lib/java/fullstack_demo/**" env: diff --git a/.github/workflows/check_fullstack_demo_ts_pr.yaml b/.github/workflows/check_fullstack_demo_ts_pr.yaml index c90576cd8..9d3a2207e 100644 --- a/.github/workflows/check_fullstack_demo_ts_pr.yaml +++ b/.github/workflows/check_fullstack_demo_ts_pr.yaml @@ -4,6 +4,7 @@ on: pull_request: branches: [ "main" ] paths: + - ".github/workflows/check_fullstack_demo_ts_pr.yaml" - "lib/typescript/fullstack_demo/**" jobs: From 1e831da73f90882198a893d136915c94c086a140 Mon Sep 17 00:00:00 2001 From: "Anthony D. Mays" Date: Sat, 14 Dec 2024 19:30:34 +0000 Subject: [PATCH 4/7] chore: adds env variables for build Signed-off-by: Anthony D. Mays --- .github/workflows/check_fullstack_demo_java_pr.yaml | 7 ++++--- .github/workflows/check_fullstack_demo_ts_pr.yaml | 9 +++++++-- .github/workflows/check_push.yml | 13 ++++++++----- 3 files changed, 19 insertions(+), 10 deletions(-) diff --git a/.github/workflows/check_fullstack_demo_java_pr.yaml b/.github/workflows/check_fullstack_demo_java_pr.yaml index 1b12e831f..b7161bfa0 100644 --- a/.github/workflows/check_fullstack_demo_java_pr.yaml +++ b/.github/workflows/check_fullstack_demo_java_pr.yaml @@ -7,9 +7,6 @@ on: - ".github/workflows/check_fullstack_demo_java_pr.yaml" - "lib/java/fullstack_demo/**" -env: - CLERK_PERISHABLE_KEY: 12345 - jobs: build: @@ -18,6 +15,10 @@ jobs: contents: read pull-requests: write + env: + CLERK_PERISHABLE_KEY: 12345 + CLERK_SECRET_KEY: 12345 + steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/check_fullstack_demo_ts_pr.yaml b/.github/workflows/check_fullstack_demo_ts_pr.yaml index 9d3a2207e..0a54507dd 100644 --- a/.github/workflows/check_fullstack_demo_ts_pr.yaml +++ b/.github/workflows/check_fullstack_demo_ts_pr.yaml @@ -9,11 +9,14 @@ on: jobs: build: - + environment: build runs-on: ubuntu-latest permissions: contents: read + env: + NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY=${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} + steps: - uses: actions/checkout@v4 @@ -24,4 +27,6 @@ jobs: - name: Build Fullstack Demo with Node.js working-directory: ./lib/typescript/fullstack_demo - run: npm ci \ No newline at end of file + run: | + npm ci + npm run build \ No newline at end of file diff --git a/.github/workflows/check_push.yml b/.github/workflows/check_push.yml index dafc2ad55..5e1c2ca47 100644 --- a/.github/workflows/check_push.yml +++ b/.github/workflows/check_push.yml @@ -23,16 +23,17 @@ on: - "lesson_16/objects/**" - "lesson_17/bank/**" - "lesson_26/api/**" -env: - CLERK_PERISHABLE_KEY: 12345 - jobs: build: - + environment: build runs-on: ubuntu-latest permissions: contents: read + env: + CLERK_PERISHABLE_KEY: 12345 + NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY=${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} + steps: - uses: actions/checkout@v4 - name: Set up JDK @@ -162,4 +163,6 @@ jobs: - name: Build Fullstack Demo with Node.js working-directory: ./lib/typescript/fullstack_demo - run: npm ci \ No newline at end of file + run: | + npm ci + npm run build \ No newline at end of file From 19962ae6544502040a2e79f2a85afc4d932f3a65 Mon Sep 17 00:00:00 2001 From: "Anthony D. Mays" Date: Sat, 14 Dec 2024 19:35:06 +0000 Subject: [PATCH 5/7] chore: fix build action Signed-off-by: Anthony D. Mays --- .github/workflows/check_fullstack_demo_ts_pr.yaml | 6 ++++-- .github/workflows/check_push.yml | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check_fullstack_demo_ts_pr.yaml b/.github/workflows/check_fullstack_demo_ts_pr.yaml index 0a54507dd..dcaea8573 100644 --- a/.github/workflows/check_fullstack_demo_ts_pr.yaml +++ b/.github/workflows/check_fullstack_demo_ts_pr.yaml @@ -9,13 +9,15 @@ on: jobs: build: - environment: build + runs-on: ubuntu-latest permissions: contents: read + environment: build + env: - NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY=${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} + NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/check_push.yml b/.github/workflows/check_push.yml index 5e1c2ca47..db6defac2 100644 --- a/.github/workflows/check_push.yml +++ b/.github/workflows/check_push.yml @@ -32,7 +32,7 @@ jobs: env: CLERK_PERISHABLE_KEY: 12345 - NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY=${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} + NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} steps: - uses: actions/checkout@v4 From 328d9b88615dc5f0132ffa03d6635976ca56d99d Mon Sep 17 00:00:00 2001 From: "Anthony D. Mays" Date: Sat, 14 Dec 2024 19:41:31 +0000 Subject: [PATCH 6/7] chore: tries to fix env vars Signed-off-by: Anthony D. Mays --- .github/workflows/check_fullstack_demo_java_pr.yaml | 7 +++---- .github/workflows/check_fullstack_demo_ts_pr.yaml | 6 ++---- .github/workflows/check_push.yml | 8 ++++---- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/.github/workflows/check_fullstack_demo_java_pr.yaml b/.github/workflows/check_fullstack_demo_java_pr.yaml index b7161bfa0..32ea1ff0d 100644 --- a/.github/workflows/check_fullstack_demo_java_pr.yaml +++ b/.github/workflows/check_fullstack_demo_java_pr.yaml @@ -15,10 +15,6 @@ jobs: contents: read pull-requests: write - env: - CLERK_PERISHABLE_KEY: 12345 - CLERK_SECRET_KEY: 12345 - steps: - uses: actions/checkout@v4 @@ -30,4 +26,7 @@ jobs: - name: Build Fullstack Demo with Java working-directory: ./lib/java/fullstack_demo + env: + CLERK_PERISHABLE_KEY: 12345 + CLERK_SECRET_KEY: 12345 run: ./gradlew check \ No newline at end of file diff --git a/.github/workflows/check_fullstack_demo_ts_pr.yaml b/.github/workflows/check_fullstack_demo_ts_pr.yaml index dcaea8573..9a7a20d5a 100644 --- a/.github/workflows/check_fullstack_demo_ts_pr.yaml +++ b/.github/workflows/check_fullstack_demo_ts_pr.yaml @@ -13,12 +13,8 @@ jobs: runs-on: ubuntu-latest permissions: contents: read - environment: build - env: - NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} - steps: - uses: actions/checkout@v4 @@ -29,6 +25,8 @@ jobs: - name: Build Fullstack Demo with Node.js working-directory: ./lib/typescript/fullstack_demo + env: + NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} run: | npm ci npm run build \ No newline at end of file diff --git a/.github/workflows/check_push.yml b/.github/workflows/check_push.yml index db6defac2..6d263dbd7 100644 --- a/.github/workflows/check_push.yml +++ b/.github/workflows/check_push.yml @@ -30,10 +30,6 @@ jobs: permissions: contents: read - env: - CLERK_PERISHABLE_KEY: 12345 - NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} - steps: - uses: actions/checkout@v4 - name: Set up JDK @@ -159,10 +155,14 @@ jobs: - name: Build Fullstack Demo with Java working-directory: ./lib/java/fullstack_demo + env: + CLERK_PERISHABLE_KEY: 12345 run: ./gradlew check - name: Build Fullstack Demo with Node.js working-directory: ./lib/typescript/fullstack_demo + env: + NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY: ${{ secrets.NEXT_PUBLIC_CLERK_PUBLISHABLE_KEY }} run: | npm ci npm run build \ No newline at end of file From 90842a260724caa8631a06bdec392d6c0d59564c Mon Sep 17 00:00:00 2001 From: "Anthony D. Mays" Date: Sat, 14 Dec 2024 19:48:23 +0000 Subject: [PATCH 7/7] chore: tries to fix env vars Signed-off-by: Anthony D. Mays --- .github/workflows/check_fullstack_demo_ts_pr.yaml | 1 - .github/workflows/check_push.yml | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/check_fullstack_demo_ts_pr.yaml b/.github/workflows/check_fullstack_demo_ts_pr.yaml index 9a7a20d5a..88db22176 100644 --- a/.github/workflows/check_fullstack_demo_ts_pr.yaml +++ b/.github/workflows/check_fullstack_demo_ts_pr.yaml @@ -13,7 +13,6 @@ jobs: runs-on: ubuntu-latest permissions: contents: read - environment: build steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/check_push.yml b/.github/workflows/check_push.yml index 6d263dbd7..b813adc68 100644 --- a/.github/workflows/check_push.yml +++ b/.github/workflows/check_push.yml @@ -25,7 +25,6 @@ on: - "lesson_26/api/**" jobs: build: - environment: build runs-on: ubuntu-latest permissions: contents: read