test: update tests to ensure all pass

- Updated Lesson15TestEmployee.java to fix test logic
- Updated Lesson15TestManager.java to ensure correct test behavior
- Discarded changes in .vscode/settings.json

Author: kksaunders251

lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15TestEmployee.java

@@ -9,26 +9,26 @@ public class Lesson15TestEmployee {
 
   @Test
   public void getEmployeeId() {
-    // Arrange
-    var employeeId = 4;
-
-    // Act
-    Employee myEmployee = new Employee(employeeId, "", "", 0);
-
-    // Assert
-    assertEquals(4, myEmployee.getId());
+    // given
+    Employee employee = new Employee(1, "Ken", "Tech", 80);
+    // when
+    int expected = 1;
+    int actual = employee.getId();
+    // then
+    assertEquals(expected, actual);
   }
 
   @Test
   public void setEmployeeId() {
-    // Arrange
-    var expectedId = 5;
-
-    // Act
-    Employee setEmployee = new Employee(5, "", "", 0);
-
-    // Assert
-    assertEquals(expectedId, setEmployee.getId());
+    // given
+    Employee employee = new Employee(1, "Kushmir", "Tech", 80);
+    // when
+    employee.setId(1);
+    // then
+    int expected = 1;
+    int actual = employee.getId();
+
+    assertEquals(expected, actual);
   }
 
   @Test
@@ -45,14 +45,15 @@ public void getName() {
 
   @Test
   public void setName() {
-    // Arrange
-    var getName = "Khai";
-
-    // Act
-    Employee setEmployeeName = new Employee(0, "Khai", "", 0);
-
-    // Assert
-    assertEquals(getName, setEmployeeName.getName());
+    // given
+    Employee employee = new Employee(2, "jamie", "2k", 600);
+
+    // when
+    employee.setName("Kody");
+    String actual = employee.getName();
+    // then
+    assertEquals("Kody", actual);
+    ;
   }
 
   @Test
@@ -70,13 +71,13 @@ public void getDepartment() {
   @Test
   public void setDepartment() {
     // Arrange
-    var expectedDepartment = "Software";
+    Employee employee = new Employee(2, "jamie", "hacker", 600);
 
-    // Act
-    Employee placeDepartment = new Employee(0, "", "Software", 0);
-
-    // Assert
-    assertEquals(expectedDepartment, placeDepartment.getDepartment());
+    // when
+    employee.setDepartment("hacker");
+    String actual = employee.getDepartment();
+    // then
+    assertEquals("hacker", actual);
   }
 
   @Test
@@ -110,4 +111,18 @@ public void getDetails() {
 
     assertThat(details).isEqualTo("Employee ID: 1, Name: Karsen, Department: Football, Salary: 25");
   }
+
+  @Test
+  public void testZeroSalary() {
+    Employee employee2 = new Employee(1, "Khayla", "Engineering", 50000);
+    employee2.setSalary(0);
+    assertThat(employee2.getSalary()).isEqualTo(0);
+  }
+
+  @Test
+  public void negativeSalary() {
+    Employee employee3 = new Employee(2, "Sonya", null, 9999);
+    employee3.setSalary(-800);
+    assertThat(employee3.getSalary()).isEqualTo(-800);
+  }
 }

lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15TestManager.java

@@ -2,6 +2,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test; // got this from chatGpt
@@ -22,6 +23,14 @@ void addsEmployeeToMap() {
     assertThat(manager.getEmployee(1)).isEqualTo(newEmployee);
   }
 
+  @Test
+  void nullDepartment() {
+    Employee employeeA = new Employee(1, "Keynon", null, 50000);
+    manager.addEmployee(employeeA);
+    Employee fetched = manager.getEmployee(1);
+    assertThat(fetched.getDepartment()).isNull();
+  }
+
   @Test
   void getEmployeeId() {
     Employee employee1 = new Employee(1, "K", "Tech", 0);
@@ -31,16 +40,20 @@ void getEmployeeId() {
 
   @Test
   void updateEmployee() {
-    Employee employee2 = new Employee(1, "K", "Google", 1);
-    manager.addEmployee(employee2);
-    assertThat(manager.getEmployee(1)).isEqualTo(employee2);
+    Employee original = new Employee(1, "John", "Apple", 1);
+    manager.addEmployee(original);
+    Employee updated = new Employee(1, "K", "Google", 1);
+    manager.updateEmployee(updated);
+    assertThat(manager.getEmployee(1)).isEqualTo(updated);
   }
 
   @Test
   void removeEmployee() {
     Employee employee3 = new Employee(5, "Kaci", "nullhora", 50000);
     manager.addEmployee(employee3);
     assertThat(manager.getEmployee(5)).isEqualTo(employee3);
+    manager.removeEmployee(5);
+    assertThrows(IllegalArgumentException.class, () -> manager.getEmployee(5));
   }
 
   @Test