Feat: Enhance withdrawal to not allow checks to be written from savings accoount

Author: Dlafferty251

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/BankAtm.java

@@ -73,9 +73,10 @@ public void depositFunds(String accountNumber, Check check) {
    * @param accountNumber
    * @param amount
    */
-  public void withdrawFunds(String accountNumber, double amount) {
+  public void withdrawFunds(String accountNumber, double amount, Check check) {
     CheckingAccount account = getAccountOrThrow(accountNumber);
     account.withdraw(amount);
+
     auditLog.log("Withdrew " + amount + " from account " + accountNumber);
   }
 

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/CheckingAccount.java

@@ -68,9 +68,11 @@ public void withdraw(double amount) throws InsufficientFundsException {
     if (isClosed()) {
       throw new IllegalStateException("Cannot withdraw from a closed account");
     }
+
     if (amount <= 0) {
       throw new IllegalStateException("Withdrawal amount must be positive");
     }
+
     if (balance < amount) {
       throw new InsufficientFundsException("Account does not have enough funds for withdrawal");
     }

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/SavingsAccount.java

@@ -2,6 +2,8 @@
 
 import java.util.Set;
 
+import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException;
+
 /**
  * The {@code SavingsAccount} class represents a savings account in a banking system. It extends the
  * {@code CheckingAccount} class and provides additional functionality specific to savings accounts.
@@ -49,12 +51,22 @@ && getBalance() == other.getBalance()
   /**
    * Will throw and exception if the user attempt to make a withdrawl while under the instance of
    * SavingsAccount.
+   * 
+   * And the makes a second withdrawl that will check if there 
+   * is a check and throw an error if one comes in.
    *
    * @param amount The amount to deposit.
    */
   @Override
-  public void withdraw(double amount) {
-    throw new RuntimeException("Cannot withdraw from a savings account using a check");
+  public void withdraw(double amount) throws InsufficientFundsException {
+    throw new IllegalStateException("you cannot write a check from the savings account");
+  }
+
+  public void withdraw(double amount, Check check) {
+    if (check != null) {
+      throw new IllegalStateException("Cannot withdraw from a savings account using a check");
+    }
+    withdraw(amount); // Call the original withdraw method
   }
 
   /**

lesson_17/bank/bank_app/src/test/java/com/codedifferently/lesson17/bank/BankAtmTest.java

@@ -1,14 +1,15 @@
 package com.codedifferently.lesson17.bank;
 
+import java.util.Set;
+import java.util.UUID;
+
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 import com.codedifferently.lesson17.bank.exceptions.AccountNotFoundException;
 import com.codedifferently.lesson17.bank.exceptions.CheckVoidedException;
-import java.util.Set;
-import java.util.UUID;
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
 
 class BankAtmTest {
 
@@ -92,7 +93,7 @@ void testDepositFunds_DoesntDepositCheckTwice() {
   @Test
   void testWithdrawFunds() {
     // Act
-    classUnderTest.withdrawFunds(account2.getAccountNumber(), 50.0);
+    classUnderTest.withdrawFunds(account2.getAccountNumber(), 50.0, null);
 
     // Assert
     assertThat(account2.getBalance()).isEqualTo(150.0);
@@ -104,7 +105,7 @@ void testWithdrawFunds_AccountNotFound() {
 
     // Act & Assert
     assertThatExceptionOfType(AccountNotFoundException.class)
-        .isThrownBy(() -> classUnderTest.withdrawFunds(nonExistingAccountNumber, 50.0))
+        .isThrownBy(() -> classUnderTest.withdrawFunds(nonExistingAccountNumber, 50.0, null))
         .withMessage("Account not found");
   }
 }

lesson_17/bank/bank_app/src/test/java/com/codedifferently/lesson17/bank/CheckingAccountTest.java

@@ -48,7 +48,8 @@ void deposit_withNegativeAmount() {
   }
 
   @Test
-  void withdraw() {
+  void withdraw() { // Assuming Check has a constructor with id and amount
+    // Assuming Check has a constructor with id and amount
     classUnderTest.withdraw(50.0);
     assertEquals(50.0, classUnderTest.getBalance());
   }

lesson_17/bank/bank_app/src/test/java/com/codedifferently/lesson17/bank/SavingsAccountTest.java

@@ -1,6 +1,7 @@
 package com.codedifferently.lesson17.bank;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import java.util.HashSet;
 import java.util.UUID;
@@ -34,4 +35,18 @@ void testEquals() {
     boolean actual = classUnderTest.equals(other);
     assertEquals(expected, actual);
   }
+
+  @Test
+  void testCheckWithdrawl() {
+    Check check = new Check("123456789", 1000.0, classUnderTest);
+
+    IllegalStateException exception =
+        assertThrows(
+            IllegalStateException.class,
+            () -> {
+              classUnderTest.withdraw(1000, check);
+            });
+
+    assertEquals("Cannot withdraw from a savings account using a check", exception.getMessage());
+  }
 }