Skip to content

Commit 5339835

Browse files
committed
fix: resolves 200!=404 error from getItemsById
1 parent cf93882 commit 5339835

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

lesson_26/api/java/api_app/src/main/java/com/codedifferently/lesson26/web/MediaItemsController.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
package com.codedifferently.lesson26.web;
22

3-
import com.codedifferently.lesson26.library.Librarian;
4-
import com.codedifferently.lesson26.library.Library;
5-
import com.codedifferently.lesson26.library.MediaItem;
6-
import com.codedifferently.lesson26.library.exceptions.MediaItemCheckedOutException;
7-
import com.codedifferently.lesson26.library.search.SearchCriteria;
83
import java.io.IOException;
94
import java.util.List;
105
import java.util.Set;
116
import java.util.UUID;
7+
128
import org.springframework.http.ResponseEntity;
139
import org.springframework.web.bind.annotation.CrossOrigin;
1410
import org.springframework.web.bind.annotation.DeleteMapping;
@@ -18,6 +14,12 @@
1814
import org.springframework.web.bind.annotation.RequestBody;
1915
import org.springframework.web.bind.annotation.RestController;
2016

17+
import com.codedifferently.lesson26.library.Librarian;
18+
import com.codedifferently.lesson26.library.Library;
19+
import com.codedifferently.lesson26.library.MediaItem;
20+
import com.codedifferently.lesson26.library.exceptions.MediaItemCheckedOutException;
21+
import com.codedifferently.lesson26.library.search.SearchCriteria;
22+
2123
@RestController
2224
@CrossOrigin
2325
public class MediaItemsController {
@@ -40,7 +42,7 @@ public ResponseEntity<GetMediaItemsResponse> getItems() {
4042

4143
@GetMapping("/items/{id}")
4244
public ResponseEntity<MediaItemResponse> getItemsById(@PathVariable("id") UUID id) {
43-
Set<MediaItem> items = library.search(SearchCriteria.builder().build());
45+
Set<MediaItem> items = library.search(SearchCriteria.builder().id(id.toString()).build());
4446

4547
if (items.isEmpty()) {
4648
return ResponseEntity.notFound().build();
@@ -51,15 +53,14 @@ public ResponseEntity<MediaItemResponse> getItemsById(@PathVariable("id") UUID i
5153
}
5254

5355
@PostMapping("/items")
54-
public ResponseEntity<CreateMediaItemResponse> postItem(
55-
@RequestBody CreateMediaItemRequest request) {
56+
public ResponseEntity<CreateMediaItemResponse> postItem(@RequestBody CreateMediaItemRequest request) {
5657
MediaItem newItem = MediaItemRequest.asMediaItem(request.getItem());
5758

5859
library.addMediaItem(newItem, librarian);
5960

6061
MediaItemResponse itemResponse = MediaItemResponse.from(newItem);
6162
CreateMediaItemResponse response = CreateMediaItemResponse.builder().item(itemResponse).build();
62-
63+
6364
return ResponseEntity.ok(response);
6465
}
6566

@@ -70,7 +71,7 @@ public ResponseEntity<Void> deleteItem(@PathVariable("id") UUID id) {
7071
if (items.isEmpty()) {
7172
return ResponseEntity.notFound().build();
7273
}
73-
74+
7475
MediaItem itemToDelete = items.iterator().next();
7576

7677
try {

0 commit comments

Comments
 (0)