feat: add BusinessCheckingAccount and MoneyOrder classes with unit tests; enhance Check and BankAccount classes

Author: bryanasb251

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/AuditLog.java

@@ -1,23 +1,43 @@
 package com.codedifferently.lesson17.bank;
 
+import java.time.LocalDateTime;
 import java.util.ArrayList;
 import java.util.List;
 
 public class AuditLog {
-    private List<String> logEntries;
+  private final List<String> logEntries = new ArrayList<>();
 
-    public AuditLog() {
-        logEntries = new ArrayList<>();
-    }
-
-    public void logTransaction(BankAccount account, double amount, String transactionType) {
-        String entry = String.format("%s transaction: %s | Amount: %.2f | Balance: %.2f",
+  public void logTransaction(BankAccount account, double amount, String transactionType) {
+    String entry =
+        String.format(
+            "%s transaction: %s | Amount: %.2f | Balance: %.2f",
             transactionType, account.getAccountNumber(), amount, account.getBalance());
-        logEntries.add(entry);
-        System.out.println(entry);  // You can remove this line if you prefer logging to a file or database
-    }
+    logEntries.add(entry);
+    System.out.println(
+        entry); // You can remove this line if you prefer logging to a file or database
+  }
 
-    public List<String> getLogEntries() {
-        return logEntries;
+  public List<String> getLogEntries() {
+    return logEntries;
+  }
+
+  public void record(String message) {
+    String timestampedEntry = LocalDateTime.now() + " | " + message;
+    logEntries.add(timestampedEntry);
+    System.out.println(timestampedEntry); // Optional: For real-time feedback
+  }
+
+  public void printLog() {
+    System.out.println("Audit Log:");
+    for (String entry : logEntries) {
+      System.out.println(entry);
     }
+  }
+
+  /**
+   * Records an audit log message.
+   *
+   * @param message The message to record.
+   */
+  // Removed duplicate method definition for record(String message)
 }

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/BankAccount.java

@@ -1,8 +1,7 @@
 package com.codedifferently.lesson17.bank;
 
-import java.util.Set;
-
 import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException;
+import java.util.Set;
 
 public class BankAccount {
   protected String accountNumber;
@@ -11,7 +10,7 @@ public class BankAccount {
   protected boolean isActive;
   private static final double LARGE_TRANSACTION_THRESHOLD = 5000.0;
 
- public BankAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
+  public BankAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
     this.accountNumber = accountNumber;
     this.owners = owners;
     this.balance = initialBalance;
@@ -54,9 +53,8 @@ public void deposit(double amount) throws IllegalStateException {
     balance += amount;
   }
 
-  
-    // Withdraws funds from the account.
-   
+  // Withdraws funds from the account.
+
   public void withdraw(double amount) throws InsufficientFundsException {
     if (isClosed()) {
       throw new IllegalStateException("Cannot withdraw from a closed account");
@@ -72,6 +70,7 @@ public void withdraw(double amount) throws InsufficientFundsException {
     }
     balance -= amount;
   }
+
   /**
    * Checks if the account is active.
    *
@@ -130,4 +129,3 @@ public String toString() {
         + '}';
   }
 }
-

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/BankAtm.java

@@ -1,12 +1,8 @@
 package com.codedifferently.lesson17.bank;
 
 import com.codedifferently.lesson17.bank.exceptions.AccountNotFoundException;
+import com.codedifferently.lesson17.bank.exceptions.CheckVoidedException;
 import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException;
-
-import main.java.com.codedifferently.lesson17.bank.AuditLog;
-import main.java.com.codedifferently.lesson17.bank.BankAccount;
-import main.java.com.codedifferently.lesson17.bank.MoneyOrder;
-
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Set;
@@ -59,10 +55,15 @@ public void depositFunds(String accountNumber, double amount) {
    * @param accountNumber The account number.
    * @param check The check to deposit.
    */
-  public void depositFunds(String accountNumber, Check check) {
+  public void depositFunds(String accountNumber, Check check) throws CheckVoidedException {
     BankAccount account = getAccountOrThrow(accountNumber);
+
+    if (check.getIsVoided()) {
+      throw new CheckVoidedException("Check is voided");
+    }
+
     check.depositFunds(account);
-    auditLog.record("Deposited check of $" + check.getAmount() + " into account " + accountNumber);
+    auditLog.record("Deposited check of $" + check.getAmount() + " to account " + accountNumber);
   }
 
   /**
@@ -76,15 +77,22 @@ public void withdrawFunds(String accountNumber, double amount) {
     account.withdraw(amount);
     auditLog.record("Withdrew $" + amount + " from account " + accountNumber);
   }
-   /**
-    * Handles a money order transaction.
-    * @param moneyOrder The money order to process.
-    */
+
+  /**
+   * Handles a money order transaction.
+   *
+   * @param moneyOrder The money order to process.
+   */
   public void handleMoneyOrder(MoneyOrder moneyOrder) throws InsufficientFundsException {
     BankAccount account = getAccountOrThrow(moneyOrder.getSourceAccount().getAccountNumber());
     moneyOrder.process();
-    auditLog.record("Processed money order of $" + moneyOrder.getAmount() + " from account " + account.getAccountNumber());
+    auditLog.record(
+        "Processed money order of $"
+            + moneyOrder.getAmount()
+            + " from account "
+            + account.getAccountNumber());
   }
+
   /**
    * Gets an account by its number or throws an exception if not found.
    *

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/BusinessCheckingAccount.java

@@ -2,29 +2,16 @@
 
 import java.util.Set;
 
-import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException;
-
 public class BusinessCheckingAccount extends BankAccount {
-    private boolean isBusiness;
-
-    public BusinessCheckingAccount(String accountNumber, Set<Customer> owners, double initialBalance, boolean isBusiness) {
-        super(accountNumber, owners, initialBalance);
-        this.isBusiness = isBusiness;
-    }
+  private final boolean isBusiness;
 
-    /**
-     * Business accounts may have special conditions for checks, etc.
-     */
-    @Override
-    public void withdraw(double amount) throws InsufficientFundsException {
-        // Business checking accounts can withdraw with more flexibility
-        if (amount > balance) {
-            throw new InsufficientFundsException("Insufficient funds in business checking account.");
-        }
-        balance -= amount;
-    }
+  public BusinessCheckingAccount(
+      String accountNumber, Set<Customer> owners, double initialBalance, boolean isBusiness) {
+    super(accountNumber, owners, initialBalance);
+    this.isBusiness = isBusiness;
+  }
 
-    public boolean isBusiness() {
-        return isBusiness;
-    }
-}
+  public boolean isBusiness() {
+    return isBusiness;
+  }
+}

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/Check.java

@@ -49,6 +49,9 @@ public void depositFunds(BankAccount account) {
     if (account instanceof SavingsAccount) {
       throw new UnsupportedOperationException("Cannot deposit checks into a savings account");
     }
+    if (account == null) {
+      throw new IllegalArgumentException("Account cannot be null");
+    }
     account.deposit(amount);
   }
 
@@ -77,4 +80,13 @@ public String toString() {
         + account.getAccountNumber()
         + '}';
   }
+
+  /**
+   * Gets the check number.
+   *
+   * @return The check number.
+   */
+  public double getAmount() {
+    return amount;
+  }
 }

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/CheckingAccount.java

@@ -1,10 +1,10 @@
- package com.codedifferently.lesson17.bank;
+package com.codedifferently.lesson17.bank;
 
 import java.util.Set;
 
 public class CheckingAccount extends BankAccount {
 
-    public CheckingAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
-        super(accountNumber, owners, initialBalance);
-      }
-    }
+  public CheckingAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
+    super(accountNumber, owners, initialBalance);
+  }
+}

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/MoneyOrder.java

@@ -3,26 +3,26 @@
 import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException;
 
 public class MoneyOrder {
-    private BankAccount sourceAccount;
-    private double amount;
+  private final BankAccount sourceAccount;
+  private final double amount;
 
-    public MoneyOrder(BankAccount sourceAccount, double amount) {
-        this.sourceAccount = sourceAccount;
-        this.amount = amount;
-    }
+  public MoneyOrder(BankAccount sourceAccount, double amount) {
+    this.sourceAccount = sourceAccount;
+    this.amount = amount;
+  }
 
-    public BankAccount getSourceAccount() {
-        return sourceAccount;
-    }
+  public BankAccount getSourceAccount() {
+    return sourceAccount;
+  }
 
-    public double getAmount() {
-        return amount;
-    }
+  public double getAmount() {
+    return amount;
+  }
 
-    public void process() throws InsufficientFundsException {
-        if (sourceAccount.getBalance() < amount) {
-            throw new InsufficientFundsException("Insufficient funds for money order.");
-        }
-        sourceAccount.withdraw(amount);
+  public void process() throws InsufficientFundsException {
+    if (sourceAccount.getBalance() < amount) {
+      throw new InsufficientFundsException("Insufficient funds for money order.");
     }
+    sourceAccount.withdraw(amount);
+  }
 }

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/SavingsAccount.java

@@ -1,26 +1,21 @@
 package com.codedifferently.lesson17.bank;
 
-import java.util.Set;
-
 import com.codedifferently.lesson17.bank.exceptions.InsufficientFundsException;
+import java.util.Set;
 
 public class SavingsAccount extends BankAccount {
 
-    public SavingsAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
-        super(accountNumber, owners, initialBalance);
-    }
+  public SavingsAccount(String accountNumber, Set<Customer> owners, double initialBalance) {
+    super(accountNumber, owners, initialBalance);
+  }
 
-    /**
-     * Override withdraw to restrict check withdrawals for savings accounts.
-     */
-    @Override
-    public void withdraw(double amount) throws InsufficientFundsException {
-        // Check for withdrawal via check (additional logic can be added here if needed)
-        if (amount > balance) {
-            throw new InsufficientFundsException("Insufficient funds in savings account.");
-        }
-        balance -= amount;
+  /** Override withdraw to restrict check withdrawals for savings accounts. */
+  @Override
+  public void withdraw(double amount) throws InsufficientFundsException {
+    // Check for withdrawal via check (additional logic can be added here if needed)
+    if (amount > balance) {
+      throw new InsufficientFundsException("Insufficient funds in savings account.");
     }
+    balance -= amount;
+  }
 }
-
-

lesson_17/bank/bank_app/src/test/java/com/codedifferently/lesson17/bank/AuditLogTest.java

@@ -0,0 +1,60 @@
+package com.codedifferently.lesson17.bank;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+
+class AuditLogTest {
+
+  private AuditLog auditLog;
+  private BankAccount account;
+
+  @BeforeEach
+  void setUp() {
+    auditLog = new AuditLog();
+    Customer customer = new Customer(UUID.randomUUID(), "Test User");
+    account = new CheckingAccount("123456789", Set.of(customer), 100.0);
+  }
+
+  @Test
+  void testLogTransaction_addsCorrectEntry() {
+    auditLog.logTransaction(account, 50.0, "Deposit");
+
+    List<String> entries = auditLog.getLogEntries();
+
+    assertThat(entries).hasSize(1);
+    assertThat(entries.get(0))
+        .contains("Deposit transaction: 123456789")
+        .contains("Amount: 50.00")
+        .contains("Balance: 100.00");
+  }
+
+  @Test
+  void testRecord_addsTimestampedEntry() {
+    auditLog.record("Custom event happened.");
+
+    List<String> entries = auditLog.getLogEntries();
+
+    assertThat(entries).hasSize(1);
+    assertThat(entries.get(0)).contains("Custom event happened.");
+    assertThat(entries.get(0)).contains("|"); // timestamp separator
+  }
+
+  @Test
+  void testMultipleEntries_loggedInOrder() {
+    auditLog.logTransaction(account, 25.0, "Withdrawal");
+    auditLog.record("Manual log entry.");
+    auditLog.logTransaction(account, 10.0, "Deposit");
+
+    List<String> entries = auditLog.getLogEntries();
+
+    assertThat(entries).hasSize(3);
+    assertThat(entries.get(0)).contains("Withdrawal");
+    assertThat(entries.get(1)).contains("Manual log entry.");
+    assertThat(entries.get(2)).contains("Deposit");
+  }
+}