From 70f7efcfa07b63a5b32dab8112750798ef440ff7 Mon Sep 17 00:00:00 2001 From: Dylan Date: Mon, 7 Apr 2025 21:09:33 +0000 Subject: [PATCH 1/8] feat: add getDetails method to Employee class and corresponding test --- .../java/com/codedifferently/lesson15/Employee.java | 4 ++++ .../com/codedifferently/lesson15/Lesson15Test.java | 13 ++++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java b/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java index 49aaabbd7..9eb5436df 100644 --- a/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java +++ b/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java @@ -22,6 +22,10 @@ public void setId(int id) { this.id = id; } + public String getDetails() { + return "The Employee's ID: " + id + " Name: " + name + " Department: " + department + " Salary: " + salary; + } + public String getName() { return name; } diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java index cd6ef511e..87d262299 100644 --- a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java @@ -1,7 +1,6 @@ package com.codedifferently.lesson15; import static org.assertj.core.api.Assertions.assertThat; - import org.junit.jupiter.api.Test; class Lesson15Test { @@ -13,7 +12,15 @@ public void testLesson15() { @Test public void testGetGreeting() { - // Act - Lesson15.main(null); + + } + + @Test + public void testGetDetails() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + + String result = employee.getDetails(); + String expected = "The Employee's ID: 1 Name: John Doe Department: Engineering Salary: 50000.0"; + assertThat(result).isEqualTo(expected); } } From 8df9809285687898de22a54eb23612c2a26759eb Mon Sep 17 00:00:00 2001 From: Dylan Date: Tue, 8 Apr 2025 12:09:17 +0000 Subject: [PATCH 2/8] Feat: Adds 14 Test Cases inside Lesson15 Test, Also adds getter and setter for details --- .../codedifferently/lesson15/Employee.java | 15 ++- .../lesson15/Lesson15Test.java | 109 +++++++++++++++++- 2 files changed, 122 insertions(+), 2 deletions(-) diff --git a/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java b/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java index 9eb5436df..c60bbee0f 100644 --- a/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java +++ b/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java @@ -23,7 +23,20 @@ public void setId(int id) { } public String getDetails() { - return "The Employee's ID: " + id + " Name: " + name + " Department: " + department + " Salary: " + salary; + return "The Employee's ID: " + + id + + " Name: " + + name + + " Department: " + + department + + " Salary: " + + salary; + } + + public void setDetails(String name, String department, double salary) { + this.name = name; + this.department = department; + this.salary = salary; } public String getName() { diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java index 87d262299..447980a29 100644 --- a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java @@ -12,7 +12,10 @@ public void testLesson15() { @Test public void testGetGreeting() { - + Lesson15 lesson15 = new Lesson15(); + String result = lesson15.getGreeting(); + String expected = "Hello, World!"; + assertThat(result).isEqualTo(expected); } @Test @@ -23,4 +26,108 @@ public void testGetDetails() { String expected = "The Employee's ID: 1 Name: John Doe Department: Engineering Salary: 50000.0"; assertThat(result).isEqualTo(expected); } + + @Test + public void testSetDetails() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setDetails("Jane Doe", "Marketing", 60000); + + String result = employee.getDetails(); + String expected = "The Employee's ID: 1 Name: Jane Doe Department: Marketing Salary: 60000.0"; + assertThat(result).isEqualTo(expected); + } + + @Test + public void testGetId() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + int result = employee.getId(); + assertThat(result).isEqualTo(1); + } + + @Test + public void testSetId() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setId(2); + int result = employee.getId(); + assertThat(result).isEqualTo(2); + } + + @Test + public void testGetName() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + String result = employee.getName(); + assertThat(result).isEqualTo("John Doe"); + } + @Test + public void testSetName() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setName("Jane Doe"); + String result = employee.getName(); + assertThat(result).isEqualTo("Jane Doe"); + } + + @Test + public void testGetDepartment() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + String result = employee.getDepartment(); + assertThat(result).isEqualTo("Engineering"); + } + + @Test + public void testSetDepartment() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setDepartment("Marketing"); + String result = employee.getDepartment(); + assertThat(result).isEqualTo("Marketing"); + } + @Test + public void testGetSalary() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + double result = employee.getSalary(); + assertThat(result).isEqualTo(50000); + } + @Test + public void testSetSalary() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setSalary(60000); + double result = employee.getSalary(); + assertThat(result).isEqualTo(60000); + } + @Test + public void testAddEmployee() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + assertThat(employeeManager.getEmployeeCount()).isEqualTo(1); + } + @Test + public void testGetEmployee() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + Employee result = employeeManager.getEmployee(1); + assertThat(result).isEqualTo(employee); + } + @Test + public void testUpdateEmployee() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + employee.setName("Jane Doe"); + employeeManager.updateEmployee(employee); + Employee result = employeeManager.getEmployee(1); + assertThat(result.getName()).isEqualTo("Jane Doe"); + } + + @Test + public void testRemoveEmployee() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + employeeManager.removeEmployee(1); + assertThat(employeeManager.getEmployeeCount()).isEqualTo(0); + } + + @Test + public void test } From a30c1870d4bf44118d103ad5fb06c9abbde0b976 Mon Sep 17 00:00:00 2001 From: Dylan Date: Tue, 8 Apr 2025 12:24:57 +0000 Subject: [PATCH 3/8] feat: add more tests to for the `input` command, Also adds comments to the code for easier reading --- .../codedifferently/lesson15/Employee.java | 2 + .../lesson15/Lesson15Test.java | 50 +++++++++++++++---- 2 files changed, 42 insertions(+), 10 deletions(-) diff --git a/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java b/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java index c60bbee0f..f80878b52 100644 --- a/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java +++ b/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java @@ -22,6 +22,7 @@ public void setId(int id) { this.id = id; } + // Method to get all details of an employee public String getDetails() { return "The Employee's ID: " + id @@ -33,6 +34,7 @@ public String getDetails() { + salary; } + // Method to set all employee details at once public void setDetails(String name, String department, double salary) { this.name = name; this.department = department; diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java index 447980a29..2fa9b8418 100644 --- a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java @@ -1,6 +1,7 @@ package com.codedifferently.lesson15; import static org.assertj.core.api.Assertions.assertThat; + import org.junit.jupiter.api.Test; class Lesson15Test { @@ -11,19 +12,19 @@ public void testLesson15() { } @Test - public void testGetGreeting() { - Lesson15 lesson15 = new Lesson15(); - String result = lesson15.getGreeting(); - String expected = "Hello, World!"; - assertThat(result).isEqualTo(expected); - } + public void testGetGreeting() {} + // ------------ + // Tests for Employee class @Test public void testGetDetails() { + // Create an instance of Employee by adding in temporary values Employee employee = new Employee(1, "John Doe", "Engineering", 50000); - + // This will call the getDetails method and store that in a variable called result String result = employee.getDetails(); + // This will create a string that we expect the getDetails method to return String expected = "The Employee's ID: 1 Name: John Doe Department: Engineering Salary: 50000.0"; + // This will compare the result of the getDetails method to the expected string assertThat(result).isEqualTo(expected); } @@ -52,12 +53,13 @@ public void testSetId() { assertThat(result).isEqualTo(2); } - @Test + @Test public void testGetName() { Employee employee = new Employee(1, "John Doe", "Engineering", 50000); String result = employee.getName(); assertThat(result).isEqualTo("John Doe"); } + @Test public void testSetName() { Employee employee = new Employee(1, "John Doe", "Engineering", 50000); @@ -80,12 +82,14 @@ public void testSetDepartment() { String result = employee.getDepartment(); assertThat(result).isEqualTo("Marketing"); } + @Test public void testGetSalary() { Employee employee = new Employee(1, "John Doe", "Engineering", 50000); double result = employee.getSalary(); assertThat(result).isEqualTo(50000); } + @Test public void testSetSalary() { Employee employee = new Employee(1, "John Doe", "Engineering", 50000); @@ -93,6 +97,9 @@ public void testSetSalary() { double result = employee.getSalary(); assertThat(result).isEqualTo(60000); } + + // ------- + // Tests for EmployeeManager class @Test public void testAddEmployee() { EmployeeManager employeeManager = new EmployeeManager(); @@ -100,6 +107,7 @@ public void testAddEmployee() { employeeManager.addEmployee(employee); assertThat(employeeManager.getEmployeeCount()).isEqualTo(1); } + @Test public void testGetEmployee() { EmployeeManager employeeManager = new EmployeeManager(); @@ -108,6 +116,7 @@ public void testGetEmployee() { Employee result = employeeManager.getEmployee(1); assertThat(result).isEqualTo(employee); } + @Test public void testUpdateEmployee() { EmployeeManager employeeManager = new EmployeeManager(); @@ -122,12 +131,33 @@ public void testUpdateEmployee() { @Test public void testRemoveEmployee() { EmployeeManager employeeManager = new EmployeeManager(); - Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); employeeManager.addEmployee(employee); employeeManager.removeEmployee(1); assertThat(employeeManager.getEmployeeCount()).isEqualTo(0); } @Test - public void test + public void testEmployeeCount() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee1 = new Employee(1, "John Doe", "Engineering", 50000); + Employee employee2 = new Employee(2, "Jane Doe", "Marketing", 60000); + employeeManager.addEmployee(employee1); + employeeManager.addEmployee(employee2); + int result = employeeManager.getEmployeeCount(); + assertThat(result).isEqualTo(2); + } + + @Test + public void assertEmployeeInCollection() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + try { + employeeManager.getEmployee(1); + } catch (IllegalArgumentException e) { + // This should not happen + assertThat(e.getMessage()).isEqualTo("Employee does not in collection with id 1"); + } + } } From 646073d2f88cb48be3adb02a15d0f1cf1a1b7c02 Mon Sep 17 00:00:00 2001 From: Dylan Date: Tue, 8 Apr 2025 20:13:45 +0000 Subject: [PATCH 4/8] feat: update setDetails method in Employee class to include employee ID --- .../src/main/java/com/codedifferently/lesson15/Employee.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java b/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java index f80878b52..63c5d11d0 100644 --- a/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java +++ b/lesson_15/tdd/tdd_app/src/main/java/com/codedifferently/lesson15/Employee.java @@ -35,7 +35,8 @@ public String getDetails() { } // Method to set all employee details at once - public void setDetails(String name, String department, double salary) { + public void setDetails(String name, String department, double salary, int id) { + this.id = id; this.name = name; this.department = department; this.salary = salary; From 3536d93060b59d1c22bd9a79a43aad7188c2a953 Mon Sep 17 00:00:00 2001 From: Dylan Date: Tue, 8 Apr 2025 20:18:25 +0000 Subject: [PATCH 5/8] feat: update setDetails method to include employee ID in Lesson15Test --- .../test/java/com/codedifferently/lesson15/Lesson15Test.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java index 2fa9b8418..4a4baada5 100644 --- a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java @@ -31,7 +31,7 @@ public void testGetDetails() { @Test public void testSetDetails() { Employee employee = new Employee(1, "John Doe", "Engineering", 50000); - employee.setDetails("Jane Doe", "Marketing", 60000); + employee.setDetails("Jane Doe", "Marketing", 60000, 1); String result = employee.getDetails(); String expected = "The Employee's ID: 1 Name: Jane Doe Department: Marketing Salary: 60000.0"; From 2e5d63a3fbceb705942ff279700f60fd33993a7b Mon Sep 17 00:00:00 2001 From: Dylan Date: Wed, 9 Apr 2025 14:31:47 +0000 Subject: [PATCH 6/8] feat: Move unit tests for Employee and EmployeeManager into specified classes --- .../lesson15/EmployeeManagerTest.java | 69 ++++++++++++++ .../lesson15/EmployeeTest.java | 89 +++++++++++++++++++ .../lesson15/Lesson15Test.java | 60 ------------- 3 files changed, 158 insertions(+), 60 deletions(-) create mode 100644 lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/EmployeeManagerTest.java create mode 100644 lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/EmployeeTest.java diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/EmployeeManagerTest.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/EmployeeManagerTest.java new file mode 100644 index 000000000..209ea0810 --- /dev/null +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/EmployeeManagerTest.java @@ -0,0 +1,69 @@ +package com.codedifferently.lesson15; + +import static org.assertj.core.api.Assertions.assertThat; + +import org.junit.jupiter.api.Test; + +public class EmployeeManagerTest { + + @Test + public void testAddEmployee() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + assertThat(employeeManager.getEmployeeCount()).isEqualTo(1); + } + + @Test + public void testGetEmployee() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + Employee result = employeeManager.getEmployee(1); + assertThat(result).isEqualTo(employee); + } + + @Test + public void testUpdateEmployee() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + employee.setName("Jane Doe"); + employeeManager.updateEmployee(employee); + Employee result = employeeManager.getEmployee(1); + assertThat(result.getName()).isEqualTo("Jane Doe"); + } + + @Test + public void testRemoveEmployee() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + employeeManager.removeEmployee(1); + assertThat(employeeManager.getEmployeeCount()).isEqualTo(0); + } + + @Test + public void testEmployeeCount() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee1 = new Employee(1, "John Doe", "Engineering", 50000); + Employee employee2 = new Employee(2, "Jane Doe", "Marketing", 60000); + employeeManager.addEmployee(employee1); + employeeManager.addEmployee(employee2); + int result = employeeManager.getEmployeeCount(); + assertThat(result).isEqualTo(2); + } + + @Test + public void assertEmployeeInCollection() { + EmployeeManager employeeManager = new EmployeeManager(); + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employeeManager.addEmployee(employee); + try { + employeeManager.getEmployee(1); + } catch (IllegalArgumentException e) { + // This should not happen + assertThat(e.getMessage()).isEqualTo("Employee does not exist in collection with id 1"); + } + } +} diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/EmployeeTest.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/EmployeeTest.java new file mode 100644 index 000000000..2327de1f7 --- /dev/null +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/EmployeeTest.java @@ -0,0 +1,89 @@ +import static org.assertj.core.api.Assertions.assertThat; + +import com.codedifferently.lesson15.Employee; +import org.junit.jupiter.api.Test; + +public class EmployeeTest { + + @Test + public void testGetDetails() { + // Create an instance of Employee by adding in temporary values + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + // This will call the getDetails method and store that in a variable called result + String result = employee.getDetails(); + // This will create a string that we expect the getDetails method to return + String expected = "The Employee's ID: 1 Name: John Doe Department: Engineering Salary: 50000.0"; + // This will compare the result of the getDetails method to the expected string + assertThat(result).isEqualTo(expected); + } + + @Test + public void testSetDetails() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setDetails("Jane Doe", "Marketing", 60000, 1); + + String result = employee.getDetails(); + String expected = "The Employee's ID: 1 Name: Jane Doe Department: Marketing Salary: 60000.0"; + assertThat(result).isEqualTo(expected); + } + + @Test + public void testGetId() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + int result = employee.getId(); + assertThat(result).isEqualTo(1); + } + + @Test + public void testSetId() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setId(2); + int result = employee.getId(); + assertThat(result).isEqualTo(2); + } + + @Test + public void testGetName() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + String result = employee.getName(); + assertThat(result).isEqualTo("John Doe"); + } + + @Test + public void testSetName() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setName("Jane Doe"); + String result = employee.getName(); + assertThat(result).isEqualTo("Jane Doe"); + } + + @Test + public void testGetDepartment() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + String result = employee.getDepartment(); + assertThat(result).isEqualTo("Engineering"); + } + + @Test + public void testSetDepartment() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setDepartment("Marketing"); + String result = employee.getDepartment(); + assertThat(result).isEqualTo("Marketing"); + } + + @Test + public void testGetSalary() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + double result = employee.getSalary(); + assertThat(result).isEqualTo(50000); + } + + @Test + public void testSetSalary() { + Employee employee = new Employee(1, "John Doe", "Engineering", 50000); + employee.setSalary(60000); + double result = employee.getSalary(); + assertThat(result).isEqualTo(60000); + } +} diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java index 4a4baada5..a046a79ae 100644 --- a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java @@ -99,65 +99,5 @@ public void testSetSalary() { } // ------- - // Tests for EmployeeManager class - @Test - public void testAddEmployee() { - EmployeeManager employeeManager = new EmployeeManager(); - Employee employee = new Employee(1, "John Doe", "Engineering", 50000); - employeeManager.addEmployee(employee); - assertThat(employeeManager.getEmployeeCount()).isEqualTo(1); - } - - @Test - public void testGetEmployee() { - EmployeeManager employeeManager = new EmployeeManager(); - Employee employee = new Employee(1, "John Doe", "Engineering", 50000); - employeeManager.addEmployee(employee); - Employee result = employeeManager.getEmployee(1); - assertThat(result).isEqualTo(employee); - } - - @Test - public void testUpdateEmployee() { - EmployeeManager employeeManager = new EmployeeManager(); - Employee employee = new Employee(1, "John Doe", "Engineering", 50000); - employeeManager.addEmployee(employee); - employee.setName("Jane Doe"); - employeeManager.updateEmployee(employee); - Employee result = employeeManager.getEmployee(1); - assertThat(result.getName()).isEqualTo("Jane Doe"); - } - @Test - public void testRemoveEmployee() { - EmployeeManager employeeManager = new EmployeeManager(); - Employee employee = new Employee(1, "John Doe", "Engineering", 50000); - employeeManager.addEmployee(employee); - employeeManager.removeEmployee(1); - assertThat(employeeManager.getEmployeeCount()).isEqualTo(0); - } - - @Test - public void testEmployeeCount() { - EmployeeManager employeeManager = new EmployeeManager(); - Employee employee1 = new Employee(1, "John Doe", "Engineering", 50000); - Employee employee2 = new Employee(2, "Jane Doe", "Marketing", 60000); - employeeManager.addEmployee(employee1); - employeeManager.addEmployee(employee2); - int result = employeeManager.getEmployeeCount(); - assertThat(result).isEqualTo(2); - } - - @Test - public void assertEmployeeInCollection() { - EmployeeManager employeeManager = new EmployeeManager(); - Employee employee = new Employee(1, "John Doe", "Engineering", 50000); - employeeManager.addEmployee(employee); - try { - employeeManager.getEmployee(1); - } catch (IllegalArgumentException e) { - // This should not happen - assertThat(e.getMessage()).isEqualTo("Employee does not in collection with id 1"); - } - } } From 85e73cd0d8fd2b3080c8906781a143eccb3b2459 Mon Sep 17 00:00:00 2001 From: Dylan Date: Fri, 11 Apr 2025 18:55:04 +0000 Subject: [PATCH 7/8] feat: remove redundant test for setDetails method in Lesson15Test --- .../com/codedifferently/lesson15/Lesson15Test.java | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java index a046a79ae..6acea20c8 100644 --- a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java @@ -1,7 +1,6 @@ package com.codedifferently.lesson15; import static org.assertj.core.api.Assertions.assertThat; - import org.junit.jupiter.api.Test; class Lesson15Test { @@ -28,15 +27,6 @@ public void testGetDetails() { assertThat(result).isEqualTo(expected); } - @Test - public void testSetDetails() { - Employee employee = new Employee(1, "John Doe", "Engineering", 50000); - employee.setDetails("Jane Doe", "Marketing", 60000, 1); - - String result = employee.getDetails(); - String expected = "The Employee's ID: 1 Name: Jane Doe Department: Marketing Salary: 60000.0"; - assertThat(result).isEqualTo(expected); - } @Test public void testGetId() { From 260f5eaf42e4c5d14a06e1facf93fb01208d5643 Mon Sep 17 00:00:00 2001 From: Dylan Date: Fri, 11 Apr 2025 18:55:19 +0000 Subject: [PATCH 8/8] feat: remove unused test method for getGreeting in Lesson15Test --- .../test/java/com/codedifferently/lesson15/Lesson15Test.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java index 6acea20c8..ac2385f38 100644 --- a/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java +++ b/lesson_15/tdd/tdd_app/src/test/java/com/codedifferently/lesson15/Lesson15Test.java @@ -10,9 +10,6 @@ public void testLesson15() { assertThat(new Lesson15()).isNotNull(); } - @Test - public void testGetGreeting() {} - // ------------ // Tests for Employee class @Test