Skip to content

Commit 399c67e

Browse files
author
calvin
committed
fix: made changes to BankAtm to resolve PR comments
1 parent d003e12 commit 399c67e

File tree

1 file changed

+10
-4
lines changed
  • lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank

1 file changed

+10
-4
lines changed

lesson_17/bank/bank_app/src/main/java/com/codedifferently/lesson17/bank/BankAtm.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,15 +60,21 @@ public void depositFunds(String accountNumber, double amount) {
6060
*/
6161
public void depositFunds(String accountNumber, Check check) {
6262
Account account = getAccountOrThrow(accountNumber);
63-
check.depositFunds(account);
64-
auditLog.logDeposit(accountNumber, check.getAmount());
63+
if (!(account instanceof CheckingAccount)) {
64+
throw new IllegalArgumentException("Checks can only be deposited into checking accounts");
65+
}
66+
double balanceBefore = account.getBalance();
67+
check.depositFunds((CheckingAccount) account);
68+
double balanceAfter = account.getBalance();
69+
double depositAmount = balanceAfter - balanceBefore;
70+
auditLog.logDeposit(accountNumber, depositAmount);
6571
}
6672

6773
/**
6874
* Withdraws funds from an account.
6975
*
70-
* @param accountNumber
71-
* @param amount
76+
* @param accountNumber The account number.
77+
* @param amount The amount to withdraw.
7278
*/
7379
public void withdrawFunds(String accountNumber, double amount) {
7480
Account account = getAccountOrThrow(accountNumber);

0 commit comments

Comments
 (0)