Skip to content

Commit a7a7d12

Browse files
profile thumbnail removed, with minor UI updates and fixes
1 parent fe850f6 commit a7a7d12

File tree

42 files changed

+37
-122
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+37
-122
lines changed

app/src/main/java/com/github/code/gambit/helper/auth/AuthData.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@ data class AuthData(
44
var fullname: String,
55
var email: String,
66
var password: String,
7-
var thumbnail: String?,
87
var confirmationCode: String?
98
)

app/src/main/java/com/github/code/gambit/ui/activity/main/MainActivity.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import com.github.code.gambit.databinding.ActivityMainBinding
2424
import com.github.code.gambit.helper.file.FileUploadState
2525
import com.github.code.gambit.ui.OnItemClickListener
2626
import com.github.code.gambit.ui.fragment.BottomNavController
27+
import com.github.code.gambit.ui.fragment.auth.AuthFragment
2728
import com.github.code.gambit.ui.fragment.home.main.HomeFragment
2829
import com.github.code.gambit.utility.SystemManager
2930
import com.github.code.gambit.utility.extention.bottomNavHide
@@ -212,6 +213,12 @@ class MainActivity : AppCompatActivity(), BottomNavController {
212213

213214
override fun onBackPressed() {
214215
if (!userManager.isAuthenticated()) {
216+
val fragment =
217+
supportFragmentManager.findFragmentById(R.id.nav_host_fragment_container)?.childFragmentManager?.fragments?.first()
218+
if (fragment is AuthFragment && fragment.currentPage != 0) {
219+
fragment.setPage(0)
220+
return
221+
}
215222
super.onBackPressed()
216223
return
217224
}

app/src/main/java/com/github/code/gambit/ui/fragment/auth/AuthFragment.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ class AuthFragment : Fragment(R.layout.fragment_auth) {
2727
private lateinit var _binding: FragmentAuthBinding
2828
private val binding get() = _binding
2929

30-
private val currentPage get() = binding.fragmentContainer.currentItem
30+
val currentPage get() = binding.fragmentContainer.currentItem
3131

3232
private val viewModel: AuthViewModel by viewModels()
3333

@@ -171,4 +171,10 @@ class AuthFragment : Fragment(R.layout.fragment_auth) {
171171
private fun enableInteraction() {
172172
binding.buttonSubmit.isEnabled = true
173173
}
174+
175+
fun setPage(page: Int) {
176+
if (page == 0 || page == 1) {
177+
binding.tabLayout.getTabAt(page)?.select()
178+
}
179+
}
174180
}

app/src/main/java/com/github/code/gambit/ui/fragment/auth/AuthViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ constructor(
101101
}
102102

103103
private suspend fun resetForgotPassword(userEmail: String, newPassword: String, confirmationCode: String) {
104-
when (val res = authRepository.resetForgotPassword(AuthData("", userEmail, newPassword, null, confirmationCode))) {
104+
when (val res = authRepository.resetForgotPassword(AuthData("", userEmail, newPassword, confirmationCode))) {
105105
is ServiceResult.Error -> {
106106
if (res.exception.cause is CodeMismatchException) {
107107
postValue(AuthState.CodeMissMatch)

app/src/main/java/com/github/code/gambit/ui/fragment/auth/LoginFragment.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class LoginFragment : Fragment(R.layout.fragment_login) {
9696
if (error) {
9797
return null
9898
}
99-
return AuthData("", username, password, null, null)
99+
return AuthData("", username, password, null)
100100
}
101101

102102
// validates the input fields
@@ -122,6 +122,6 @@ class LoginFragment : Fragment(R.layout.fragment_login) {
122122
binding.root.snackbar("Validation error!!")
123123
return null
124124
}
125-
return AuthData("", username, password, null, null)
125+
return AuthData("", username, password, null)
126126
}
127127
}

app/src/main/java/com/github/code/gambit/ui/fragment/auth/SignUpFragment.kt

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
package com.github.code.gambit.ui.fragment.auth
22

3-
import android.content.Intent
4-
import android.net.Uri
53
import android.os.Bundle
6-
import android.provider.MediaStore
74
import android.view.View
8-
import androidx.activity.result.ActivityResultLauncher
95
import androidx.fragment.app.Fragment
106
import com.github.code.gambit.R
117
import com.github.code.gambit.databinding.FragmentSignUpBinding
128
import com.github.code.gambit.helper.auth.AuthData
139
import com.github.code.gambit.utility.SystemManager
1410
import com.github.code.gambit.utility.extention.snackbar
1511
import dagger.hilt.android.AndroidEntryPoint
16-
import timber.log.Timber
1712
import javax.inject.Inject
1813

1914
@AndroidEntryPoint
@@ -30,31 +25,9 @@ class SignUpFragment : Fragment(R.layout.fragment_sign_up) {
3025
@Inject
3126
lateinit var systemManager: SystemManager
3227

33-
lateinit var launcher: ActivityResultLauncher<Intent>
34-
var profileImage: Uri? = null
35-
3628
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
3729
super.onViewCreated(view, savedInstanceState)
3830
_binding = FragmentSignUpBinding.bind(view)
39-
40-
binding.dpContainer.setOnClickListener {
41-
systemManager.launchActivity(launcher, Intent(Intent.ACTION_PICK, MediaStore.Images.Media.EXTERNAL_CONTENT_URI))
42-
}
43-
}
44-
45-
override fun onCreate(savedInstanceState: Bundle?) {
46-
super.onCreate(savedInstanceState)
47-
registerCallback()
48-
}
49-
50-
private fun registerCallback() {
51-
launcher = systemManager.requestImage(this) {
52-
if (it != null) {
53-
binding.profileImage.setImageURI(it)
54-
Timber.i(it.toString())
55-
profileImage = it
56-
}
57-
}
5831
}
5932

6033
// validates the input fields
@@ -106,6 +79,6 @@ class SignUpFragment : Fragment(R.layout.fragment_sign_up) {
10679
binding.root.snackbar("Validation error!!")
10780
return null
10881
}
109-
return AuthData(fullName, userEmail, password, profileImage.toString(), null)
82+
return AuthData(fullName, userEmail, password, null)
11083
}
11184
}

app/src/main/java/com/github/code/gambit/utility/extention/extension.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ fun AuthSignUpOptions.Builder<*>.defaultBuilder(authData: AuthData): AuthSignUpO
3434
mutableListOf
3535
(
3636
AuthUserAttribute(AuthUserAttributeKey.email(), authData.email),
37-
AuthUserAttribute(AuthUserAttributeKey.custom(AppConstant.AUTH_ATTRIBUTE_CUSTOM_PROFILE), authData.thumbnail),
37+
AuthUserAttribute(AuthUserAttributeKey.custom(AppConstant.AUTH_ATTRIBUTE_CUSTOM_PROFILE), ""),
3838
AuthUserAttribute(AuthUserAttributeKey.name(), authData.fullname)
3939
)
4040
).build()
-568 Bytes
Binary file not shown.
-922 Bytes
Binary file not shown.
-247 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)