Skip to content

Commit e48fa74

Browse files
committed
Remove preset param from mdx steps
1 parent 42b4273 commit e48fa74

File tree

4 files changed

+114
-14
lines changed

4 files changed

+114
-14
lines changed

packages/scrollycoding/src/mdx-steps.tsx

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import React from "react"
22
import {
33
CodeFiles,
44
CodeProps,
5-
Preset,
65
PreviewProps,
76
} from "./hike-context"
87

@@ -31,8 +30,7 @@ const defaultFilename = "App.js"
3130
function useMdxSteps(
3231
mdx: React.ReactNode,
3332
previewProps: PreviewProps,
34-
codeProps: CodeProps,
35-
preset?: Partial<Preset>
33+
codeProps: CodeProps
3634
) {
3735
const steps: Step[] = []
3836
React.Children.forEach(mdx, (child: any) => {
@@ -44,8 +42,7 @@ function useMdxSteps(
4442
content: [],
4543
previewProps: getPreviewProps(
4644
stepHeadProps,
47-
previewProps,
48-
preset
45+
previewProps
4946
),
5047
codeProps: getCodeProps(
5148
stepHeadProps,
@@ -85,12 +82,10 @@ function getFiles(stepHeadProps: StepHeadProps) {
8582

8683
function getPreviewProps(
8784
stepHeadProps: StepHeadProps,
88-
hikePreviewProps: PreviewProps,
89-
hikePreset: Partial<Preset> | undefined
85+
hikePreviewProps: PreviewProps
9086
): PreviewProps {
9187
return {
9288
...hikePreviewProps,
93-
preset: hikePreset,
9489
...stepHeadProps.previewProps,
9590
}
9691
}
File renamed without changes.
Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
# Hello
2+
3+
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed sed euismod libero. Quisque vehicula ante sapien, vel imperdiet ipsum tempor et. Fusce sit amet turpis ullamcorper, porta magna et, vehicula velit. Pellentesque quis dui ac lacus mollis lobortis non ut nibh. Nulla ac lorem sit amet nulla sollicitudin rhoncus. Duis aliquet sed est vitae auctor. Nullam faucibus, ipsum ut tristique efficitur, est nulla vestibulum purus, ut aliquam risus turpis sit amet nulla. Pellentesque vestibulum id ex id venenatis.
4+
5+
<Hike>
6+
7+
<StepHead>
8+
9+
```jsx
10+
import { BasisCurve } from "react-svg-curve"
11+
12+
export default function App() {
13+
return (
14+
<svg width="100" height="40">
15+
<BasisCurve
16+
data={[
17+
[0, 10],
18+
[50, 35],
19+
[100, 0],
20+
]}
21+
/>
22+
</svg>
23+
)
24+
}
25+
```
26+
27+
</StepHead>
28+
29+
## Step 1
30+
31+
Sed quis ipsum nisl. Ut eget turpis id justo lobortis molestie sed in turpis. Pellentesque maximus erat ut eleifend rutrum. Nulla lectus sem, pulvinar eu tortor at, lacinia auctor felis. Aenean semper, quam a pellentesque laoreet, ex diam vehicula urna, eget ornare nulla enim vitae massa. Nulla lacus sem, sodales non felis quis, tincidunt porta turpis. Donec suscipit vulputate purus eu elementum.
32+
33+
<CodeSlot style={{ height: 200 }} />
34+
35+
<PreviewSlot style={{ height: 200 }} />
36+
37+
Morbi mauris urna, luctus at ligula sit amet, gravida tempor
38+
libero. Curabitur convallis tincidunt est ac facilisis. Aliquam
39+
rutrum molestie vestibulum. Nunc vel lorem vel ante faucibus
40+
dictum. Morbi at neque hendrerit, maximus lacus nec, luctus lacus.
41+
Quisque tincidunt sed ante at gravida.
42+
43+
<StepHead>
44+
45+
```jsx
46+
export default function App() {
47+
return <h1>Ho</h1>
48+
}
49+
```
50+
51+
</StepHead>
52+
53+
# Step 2
54+
55+
<CodeSlot style={{ height: 200 }} />
56+
57+
Nullam ut massa ut tortor pellentesque fringilla at ut massa. Nunc ut suscipit ipsum. Curabitur eu nunc lobortis, gravida sem ac, aliquet lorem. Vestibulum semper urna in erat placerat dictum. Nulla posuere odio sed accumsan accumsan. Integer aliquet lectus sit amet turpis feugiat, vel elementum velit condimentum. Proin sit amet augue rutrum, auctor risus aliquam, varius quam. Praesent turpis nunc, dictum quis placerat vel, tempor ac tortor. Aenean sollicitudin tortor efficitur, volutpat ligula id, semper lectus. Curabitur vel nibh maximus, sodales erat id, consectetur ex. Fusce convallis vitae quam vitae venenatis.
58+
59+
<StepHead focus="1[16:29]">
60+
61+
```jsx
62+
export default function App() {
63+
return <h1>Ho</h1>
64+
}
65+
```
66+
67+
</StepHead>
68+
69+
# Step 3
70+
71+
<CodeSlot style={{ height: 200 }} />
72+
73+
Nullam ut massa ut tortor pellentesque fringilla at ut massa. Nunc ut suscipit ipsum. Curabitur eu nunc lobortis, gravida sem ac, aliquet lorem. Vestibulum semper urna in erat placerat dictum. Nulla posuere odio sed accumsan accumsan. <Focus on="2" >Integer aliquet</Focus> lectus sit amet turpis feugiat, vel elementum velit condimentum. Proin sit amet augue rutrum, auctor risus aliquam, varius quam. Praesent turpis nunc, dictum quis placerat vel, tempor ac tortor. <Focus on="3" >Aenean `sollicitudin`</Focus> tortor efficitur, volutpat ligula id, semper lectus. Curabitur vel nibh maximus, sodales erat id, consectetur ex. Fusce convallis vitae quam vitae venenatis.
74+
75+
</Hike>
76+
77+
# Goodbye
78+
79+
Integer porta tincidunt dolor ut consequat. Ut eu justo viverra, condimentum massa vel, varius neque. Curabitur lectus nibh, semper in arcu ac, sagittis fermentum lectus. Vivamus quis purus odio. Nullam placerat, lorem non condimentum vehicula, erat turpis lacinia tortor, quis vulputate metus ipsum sit amet nunc. Integer gravida hendrerit massa. Aenean condimentum ac ante in tincidunt. Duis auctor dictum eleifend. Ut sed nisl iaculis, imperdiet dui in, porttitor mi. Sed quis lorem ac dolor efficitur egestas quis eu magna. Quisque dignissim accumsan pulvinar. Curabitur sit amet lacus dictum purus rutrum volutpat. Interdum et malesuada fames ac ante ipsum primis in faucibus. Duis mattis condimentum porttitor. Donec id risus eu tortor elementum volutpat. Morbi vel diam eget velit bibendum consequat.

packages/storybook/src/scrollycoding.story.js

Lines changed: 32 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import {
99
useMdxSteps,
1010
} from "@code-hike/scrollycoding"
1111
import "@code-hike/scrollycoding/dist/index.css"
12-
import Content from "./assets/scrollycoding.mdx"
12+
import Basic from "./assets/scrollycoding.basic.mdx"
13+
import WithDeps from "./assets/scrollycoding.deps.mdx"
1314
import { MDXProvider } from "@mdx-js/react"
1415

1516
export default {
@@ -25,7 +26,21 @@ export function basic() {
2526
}}
2627
>
2728
<MDXProvider components={components}>
28-
<Content />
29+
<Basic />
30+
</MDXProvider>
31+
</Page>
32+
)
33+
}
34+
35+
export function withDeps() {
36+
return (
37+
<Page
38+
style={{
39+
maxWidth: 800,
40+
}}
41+
>
42+
<MDXProvider components={components}>
43+
<WithDeps />
2944
</MDXProvider>
3045
</Page>
3146
)
@@ -45,10 +60,21 @@ function Hike({
4560
codeProps,
4661
...props
4762
}) {
48-
const steps = useMdxSteps(children, previewProps, {
49-
minColumns: 46,
50-
...codeProps,
51-
})
63+
const steps = useMdxSteps(
64+
children,
65+
{
66+
...previewProps,
67+
preset: {
68+
customSetup: {
69+
dependencies: { "react-svg-curve": "latest" },
70+
},
71+
},
72+
},
73+
{
74+
minColumns: 46,
75+
...codeProps,
76+
}
77+
)
5278

5379
return <HikeComponent steps={steps} {...props} />
5480
}

0 commit comments

Comments
 (0)