Revert "Fix null created by" (#347)

* Revert "Fix `null` created by (#344)"

This reverts commit d60bc0d.

* chore: update submodules

Author: andhreljaKern

alembic/versions/58c0e071db99_adds_deleted_user.py

@@ -8,7 +8,6 @@
 from urllib.parse import quote
 
 from controller.user import manager
-from submodules.model import DELETED_USER_ID, DELETED_USER_EMAIL
 
 
 logging.basicConfig(level=logging.INFO)
@@ -76,24 +75,6 @@ def __refresh_identity_cache(update_db_users: bool = True) -> None:
     else:
         KRATOS_IDENTITY_CACHE = {}
 
-    # dummy identity for deleted users
-    # this identity should not be in kratos but in db only
-    # note that deleted users usually SET_NULL on foreign keys so the id is not in use anymore
-    KRATOS_IDENTITY_CACHE[DELETED_USER_ID] = {
-        "identity": {
-            "id": DELETED_USER_ID,
-            "traits": {
-                "email": DELETED_USER_EMAIL,
-                "name": {"first": "Deleted", "last": "User"},
-            },
-        },
-        "simple": {
-            "id": DELETED_USER_ID,
-            "mail": DELETED_USER_EMAIL,
-            "firstName": "Deleted",
-            "lastName": "User",
-        },
-    }
     if update_db_users:
         manager.migrate_kratos_users()
 

controller/auth/kratos.py

@@ -2,15 +2,13 @@
 from submodules.model.business_objects import monitor as task_monitor
 from controller.auth import kratos
 from submodules.model.util import sql_alchemy_to_dict
-from submodules.model import DELETED_USER_ID
 
 
 def monitor_all_tasks(page: int, limit: int) -> List[Any]:
     tasks = task_monitor.get_all_tasks(page, limit)
     tasks_dict = sql_alchemy_to_dict(tasks)
     user_ids = {str(t["created_by"]) for t in tasks}  # set comprehension
     name_lookup = {u_id: kratos.resolve_user_name_by_id(u_id) for u_id in user_ids}
-    name_lookup[DELETED_USER_ID] = {"first": "Deleted", "last": "User"}
 
     for t in tasks_dict:
         created_by_first_last = name_lookup[str(t["created_by"])]

controller/monitor/manager.py

@@ -1,5 +1,5 @@
 from typing import Dict, Optional, Any
-from submodules.model import User, daemon, enums, DELETED_USER_ID
+from submodules.model import User, daemon, enums
 from submodules.model.business_objects import user, general
 from controller.auth import kratos
 from submodules.model.exceptions import EntityNotFoundException
@@ -138,11 +138,7 @@ def __migrate_kratos_users():
 
     for user_database in users_database:
         user_id = str(user_database.id)
-        if (
-            user_id not in users_kratos
-            or users_kratos[user_id] is None
-            or user_id == DELETED_USER_ID
-        ):
+        if user_id not in users_kratos or users_kratos[user_id] is None:
             continue
         user_identity = users_kratos[user_id]["identity"]
         if user_database.email != user_identity["traits"]["email"]: