Control the visibility of attributes (#86)

* New column for visibility of the attributes

* Field visibility added on mutation

* Adds field visibility to project im/export

* Submodules change

Co-authored-by: SirDeGraf <[email protected]>

Author: lumburovskalina

alembic/versions/da902ad27b4a_add_column_for_attribute_visibility.py

@@ -0,0 +1,28 @@
+"""Add column for attribute visibility
+
+Revision ID: da902ad27b4a
+Revises: f803a0c4343c
+Create Date: 2022-12-02 09:36:36.431815
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+
+# revision identifiers, used by Alembic.
+revision = "da902ad27b4a"
+down_revision = "f803a0c4343c"
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.add_column("attribute", sa.Column("visibility", sa.String(), nullable=True))
+    # ### end Alembic commands ###
+
+
+def downgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_column("attribute", "visibility")
+    # ### end Alembic commands ###

controller/attribute/manager.py

@@ -88,6 +88,7 @@ def update_attribute(
     is_primary_key: bool,
     name: str,
     source_code: str,
+    visibility: str,
 ) -> None:
 
     attribute_item: Attribute = attribute.update(
@@ -98,6 +99,7 @@ def update_attribute(
         name,
         source_code,
         with_commit=True,
+        visibility=visibility,
     )
 
     notification.send_organization_update(

controller/transfer/project_transfer_manager.py

@@ -208,6 +208,7 @@ def import_file(
             source_code=attribute_item.get(
                 "source_code",
             ),
+            visibility=attribute_item.get("visibility"),
             project_id=project_id,
         )
         attribute_ids_by_old_id[
@@ -984,6 +985,7 @@ def get_project_export_dump(
             "source_code": attribute_item.source_code,
             "state": attribute_item.state,
             "logs": attribute_item.logs,
+            "visibility": attribute_item.visibility,
         }
         for attribute_item in attributes
     ]

graphql_api/mutation/attribute.py

@@ -28,6 +28,7 @@ class Arguments:
         is_primary_key = graphene.Boolean()
         name = graphene.String()
         source_code = graphene.String()
+        visibility = graphene.String()
 
     ok = graphene.Boolean()
 
@@ -40,11 +41,18 @@ def mutate(
         is_primary_key: Optional[bool] = None,
         name: Optional[str] = None,
         source_code: Optional[str] = None,
+        visibility: Optional[str] = None,
     ):
         auth.check_demo_access(info)
         auth.check_project_access(info, project_id)
         manager.update_attribute(
-            project_id, attribute_id, data_type, is_primary_key, name, source_code
+            project_id,
+            attribute_id,
+            data_type,
+            is_primary_key,
+            name,
+            source_code,
+            visibility,
         )
         return UpdateAttribute(ok=True)