Skip to content

Commit 51835f9

Browse files
Smaller fixes on comments and ac
1 parent a1c408e commit 51835f9

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

src/components/projects/projectId/attributes/attributeId/AttributeCalculations.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ export default function AttributeCalculation() {
107107
if (currentAttribute.saveSourceCode) {
108108
updateSourceCode(currentAttribute.sourceCode);
109109
}
110-
if (currentAttribute.state == AttributeState.USABLE) {
110+
if (currentAttribute.state == AttributeState.USABLE || currentAttribute.state == AttributeState.RUNNING) {
111111
setEditorOptions({ ...EDITOR_OPTIONS, readOnly: true });
112112
setCheckUnsavedChanges(false);
113113
}

src/components/shared/comments/DisplayComments.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ export default function DisplayComments(props: DisplayCommentsProps) {
142142
onBlur={(event: any) => {
143143
if (props.editComments[index]) props.editComment(event, comment.id, 'comment', event.target.value, index);
144144
}}
145+
onKeyUp={(e: any) => e.stopPropagation()}
145146
onKeyDown={(event: any) => { checkIfKeyShiftEnterUpdate(event, comment.id, event.target.value, index); }}
146147
value={props.commentTexts[index]}
147148
></textarea>

src/util/components/projects/projectId/data-browser/filter-parser-helper.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,11 @@ function appendBlackAndWhiteListLabelingTask(appendTo, searchElement, labelingTa
105105
appendTo.push(appendBlackAndWhiteListLabelingTaskForArray(appendTo, searchElement.values.weakSupervisionLabels, LabelSource.WEAK_SUPERVISION, drillDown));
106106
appendTo.push(appendBlackAndWhiteListLabelingTaskForArray(appendTo, searchElement.values.modelCallbackLabels, LabelSource.MODEL_CALLBACK, drillDown));
107107
appendTo.push(appendBlackAndWhiteListLabelingTaskForArray(appendTo, searchElement.values.heuristics, LabelSource.INFORMATION_SOURCE, drillDown));
108-
appendTo.push(appendBlackAndWhiteListLabelingTaskForConfidence(appendTo, searchElement.values.weakSupervisionConfidence, labelingTask.labels.map(l => l.id), true));
109-
appendTo.push(appendBlackAndWhiteListLabelingTaskForConfidence(appendTo, searchElement.values.modelCallbackConfidence, labelingTask.labels.map(l => l.id), false));
108+
if (labelingTask) {
109+
appendTo.push(appendBlackAndWhiteListLabelingTaskForConfidence(appendTo, searchElement.values.weakSupervisionConfidence, labelingTask.labels.map(l => l.id), true));
110+
appendTo.push(appendBlackAndWhiteListLabelingTaskForConfidence(appendTo, searchElement.values.modelCallbackConfidence, labelingTask.labels.map(l => l.id), false));
111+
}
112+
110113
if (!appendTo) return;
111114

112115
const isMixed = searchElement.values.isWithDifferentResults
@@ -279,7 +282,7 @@ function appendBlackAndWhiteListUserForArray(
279282
return JSON.stringify(whitelist);
280283
if (blacklist.SUBQUERIES.length > 0)
281284
return JSON.stringify(blacklist);
282-
return appendTo;
285+
return null;
283286
}
284287

285288

0 commit comments

Comments
 (0)