PR comments

Author: lumburovskalina

src/components/projects/projectId/attributes/attributeId/AttributeCalculations.tsx

@@ -315,17 +315,14 @@ export default function AttributeCalculation() {
         router.push(`/projects/${projectId}/settings`);
     }, []);
 
-    const copyToClipboardFunc = useCallback(
-        (name: string) => () => copyToClipboard(name),
-        []
-    );
+    const copyToClipboardFunc = useCallback((name: string) => copyToClipboard(name), []);
 
     const usableAttributesFinal = useMemo(() => usableAttributes.map((attribute) => (
-        { ...attribute, onClick: copyToClipboardFunc(attribute.name) }
+        { ...attribute, onClick: () => copyToClipboardFunc(attribute.name) }
     )), [usableAttributes]);
 
     const lookupListsFinal = useMemo(() => lookupLists.map((lookupList) => (
-        { ...lookupList, onClick: copyToClipboardFunc("from knowledge import " + lookupList.pythonVariable) }
+        { ...lookupList, onClick: () => copyToClipboardFunc("from knowledge import " + lookupList.pythonVariable) }
     )), [lookupLists]);
 
     const disabledOptions = useMemo(() => {

src/components/projects/projectId/settings/embeddings/Embeddings.tsx

@@ -71,13 +71,10 @@ export default function Embeddings(props: { refetchEmbeddings: () => void }) {
     const orgId = useSelector(selectOrganizationId);
     useWebsocket(orgId, Application.REFINERY, CurrentPage.PROJECT_SETTINGS, handleWebsocketNotification, projectId, CurrentPageSubKey.EMBEDDINGS);
 
-    const openFilterAttributesModal = useCallback((embedding: Embedding) => () => {
-        embedding.onQdrant ? dispatch(setModalStates(ModalEnum.FILTERED_ATTRIBUTES, { embeddingId: embedding.id, open: true, attributeNames: prepareAttributeDataByNames(embedding.filterAttributes), showEditOption: showEditOption })) : null;
-    }, [showEditOption]);
 
     const embeddingsFinal = useMemo(() => embeddings.map((embedding) => (
-        { ...embedding, onIconNotesClick: openFilterAttributesModal(embedding) }
-    )), [embeddings]);
+        { ...embedding, onIconNotesClick: () => embedding.onQdrant ? dispatch(setModalStates(ModalEnum.FILTERED_ATTRIBUTES, { embeddingId: embedding.id, open: true, attributeNames: prepareAttributeDataByNames(embedding.filterAttributes), showEditOption: showEditOption })) : null }
+    )), [embeddings, showEditOption]);
 
     return (<div className="mt-8">
         <div className="text-lg leading-6 text-gray-900 font-medium inline-block w-full">

src/components/projects/projectId/settings/labeling-tasks/LabelingTasks.tsx

@@ -88,8 +88,6 @@ export default function LabelingTasks() {
         return prepareNewArray;
     }
 
-    const deleteLabelingTask = useCallback((task) => () => dispatch(setModalStates(ModalEnum.DELETE_LABELING_TASK, { taskId: task.id, open: true })), [])
-
     const deleteLabel = useCallback((task: LabelingTask, label: LabelType) => () => {
         dispatch(setModalStates(ModalEnum.DELETE_LABEL, { taskId: task.id, label: label, open: true }));
     }, []);
@@ -103,7 +101,7 @@ export default function LabelingTasks() {
         return labelingTasksSchema.map((labelingTask) => (
             {
                 ...labelingTask,
-                onDelete: deleteLabelingTask(labelingTask),
+                onDelete: () => dispatch(setModalStates(ModalEnum.DELETE_LABELING_TASK, { taskId: labelingTask.id, open: true })),
                 labels: labelingTask.labels.map((label) => ({ ...label, onDelete: deleteLabel(labelingTask, label), onChangeColor: changeColorLabel(labelingTask, label) })),
             }
         ))