Fix all phpstan reported issues

Author: williamdes

src/ErrorFormatter/CheckstyleErrorFormatter.php

@@ -132,6 +132,9 @@ private function groupByFile(AnalysisResult $analysisResult): array
 		/** @var \CodeLts\CliTools\Error $fileSpecificError */
 		foreach ($analysisResult->getFileSpecificErrors() as $fileSpecificError) {
 			$absolutePath = $fileSpecificError->getFile();
+			if ($absolutePath === null) {
+				continue;
+			}
 			$relativeFilePath = $this->relativePathHelper->getRelativePath(
 				$absolutePath
 			);

src/ErrorFormatter/GithubErrorFormatter.php

@@ -63,7 +63,7 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
 
 		foreach ($analysisResult->getFileSpecificErrors() as $fileSpecificError) {
 			$metas = [
-				'file' => $this->relativePathHelper->getRelativePath($fileSpecificError->getFile()),
+				'file' => $fileSpecificError->getFile() !== null ? $this->relativePathHelper->getRelativePath($fileSpecificError->getFile()) : '?',
 				'line' => $fileSpecificError->getLine(),
 				'col' => 0,
 			];

src/ErrorFormatter/GitlabErrorFormatter.php

@@ -52,20 +52,24 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
 		$errorsArray = [];
 
 		foreach ($analysisResult->getFileSpecificErrors() as $fileSpecificError) {
+			$file = $fileSpecificError->getFile();
+			if ($file === null) {
+				continue;
+			}
 			$error = [
 				'description' => $fileSpecificError->getMessage(),
 				'fingerprint' => hash(
 					'sha256',
 					implode(
 						[
-							$fileSpecificError->getFile(),
+							$file,
 							$fileSpecificError->getLine(),
 							$fileSpecificError->getMessage(),
 						]
 					)
 				),
 				'location' => [
-					'path' => $this->relativePathHelper->getRelativePath($fileSpecificError->getFile()),
+					'path' => $this->relativePathHelper->getRelativePath($file),
 					'lines' => [
 						'begin' => $fileSpecificError->getLine(),
 					],
@@ -94,7 +98,7 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
 
 		$json = json_encode($errorsArray, JSON_PRETTY_PRINT | JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES);
 
-		$output->writeRaw($json);
+		$output->writeRaw((string) $json);
 
 		return $analysisResult->hasErrors() ? 1 : 0;
 	}

src/ErrorFormatter/JsonErrorFormatter.php

@@ -56,6 +56,9 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
 
 		foreach ($analysisResult->getFileSpecificErrors() as $fileSpecificError) {
 			$file = $fileSpecificError->getFile();
+			if ($file === null) {
+				continue;
+			}
 			if (!array_key_exists($file, $errorsArray['files'])) {
 				$errorsArray['files'][$file] = [
 					'errors' => 0,
@@ -77,7 +80,7 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
 
 		$json = json_encode($errorsArray, $this->pretty ? JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES | JSON_PRETTY_PRINT : JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES);
 
-		$output->writeRaw($json);
+		$output->writeRaw((string) $json);
 
 		return $analysisResult->hasErrors() ? 1 : 0;
 	}

src/ErrorFormatter/JunitErrorFormatter.php

@@ -58,7 +58,12 @@ public function formatErrors(
 		);
 
 		foreach ($analysisResult->getFileSpecificErrors() as $fileSpecificError) {
-			$fileName = $this->relativePathHelper->getRelativePath($fileSpecificError->getFile());
+			$file = $fileSpecificError->getFile();
+			if ($file === null) {
+				continue;
+			}
+
+			$fileName = $this->relativePathHelper->getRelativePath($file);
 			$result .= $this->createTestCase(
 				sprintf('%s:%s', $fileName, (string) $fileSpecificError->getLine()),
 				'ERROR',

src/ErrorFormatter/TeamcityErrorFormatter.php

@@ -69,7 +69,7 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
 			$result .= $this->createTeamcityLine('inspection', [
 				'typeId' => 'cli-tools',
 				'message' => $fileSpecificError->getMessage(),
-				'file' => $this->relativePathHelper->getRelativePath($fileSpecificError->getFile()),
+				'file' => $fileSpecificError->getFile() !== null ? $this->relativePathHelper->getRelativePath($fileSpecificError->getFile()) : '?',
 				'line' => $fileSpecificError->getLine(),
 				// additional attributes
 				'SEVERITY' => 'ERROR',

tests/ErrorFormatter/CheckstyleErrorFormatterTest.php

@@ -36,6 +36,9 @@
 class CheckstyleErrorFormatterTest extends ErrorFormatterTestCase
 {
 
+	/**
+	 * @return iterable<array>
+	 */
 	public function dataFormatterOutputProvider(): iterable
 	{
 		yield [

tests/ErrorFormatter/GithubErrorFormatterTest.php

@@ -36,6 +36,9 @@
 class GithubErrorFormatterTest extends ErrorFormatterTestCase
 {
 
+	/**
+	 * @return iterable<array>
+	 */
 	public function dataFormatterOutputProvider(): iterable
 	{
 		yield [
@@ -192,7 +195,7 @@ public function testFormatErrors(
 		$relativePathHelper = new FuzzyRelativePathHelper(new NullRelativePathHelper(), self::DIRECTORY_PATH);
 		$formatter = new GithubErrorFormatter(
 			$relativePathHelper,
-			new TableErrorFormatter($relativePathHelper, false)
+			new TableErrorFormatter($relativePathHelper)
 		);
 
 		$this->assertSame($exitCode, $formatter->formatErrors(

tests/ErrorFormatter/GitlabFormatterTest.php

@@ -34,6 +34,9 @@
 class GitlabFormatterTest extends ErrorFormatterTestCase
 {
 
+	/**
+	 * @return iterable<array>
+	 */
 	public function dataFormatterOutputProvider(): iterable
 	{
 		yield [

tests/ErrorFormatter/JsonErrorFormatterTest.php

@@ -33,6 +33,9 @@
 class JsonErrorFormatterTest extends ErrorFormatterTestCase
 {
 
+	/**
+	 * @return iterable<array>
+	 */
 	public function dataFormatterOutputProvider(): iterable
 	{
 		yield [