feat: GitLab 13.x expects severity field in code quality reports

Ref: phpstan/phpstan-src@a00eb3f
Ref: phpstan/phpstan-src#504

Author: williamdes

src/ErrorFormatter/GitlabErrorFormatter.php

@@ -69,6 +69,7 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
                         ]
                     )
                 ),
+                'severity' => $fileSpecificError->canBeIgnored() ? 'major' : 'blocker',
                 'location' => [
                     'path' => $this->relativePathHelper->getRelativePath($file),
                     'lines' => [
@@ -77,17 +78,14 @@ public function formatErrors(AnalysisResult $analysisResult, Output $output): in
                 ],
             ];
 
-            if (!$fileSpecificError->canBeIgnored()) {
-                $error['severity'] = 'blocker';
-            }
-
             $errorsArray[] = $error;
         }
 
         foreach ($analysisResult->getNotFileSpecificErrors() as $notFileSpecificError) {
             $errorsArray[] = [
                 'description' => $notFileSpecificError,
                 'fingerprint' => hash('sha256', $notFileSpecificError),
+                'severity' => 'major',
                 'location' => [
                     'path' => '',
                     'lines' => [

tests/ErrorFormatter/GitlabFormatterTest.php

@@ -57,6 +57,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Foo",
         "fingerprint": "e82b7e1f1d4255352b19ecefa9116a12f129c7edb4351cf2319285eccdb1565e",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode 😃/project/folder with unicode 😃/file name with \"spaces\" and unicode 😃.php",
             "lines": {
@@ -76,6 +77,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "first generic error",
         "fingerprint": "53ed216d77c9a9b21d9535322457ca7d7b037d6596d76484b3481f161adfd96f",
+        "severity": "major",
         "location": {
             "path": "",
             "lines": {
@@ -95,6 +97,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Bar\nBar2",
         "fingerprint": "034b4afbfb347494c14e396ed8327692f58be4cd27e8aff5f19f4194934db7c9",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode 😃/project/folder with unicode 😃/file name with \"spaces\" and unicode 😃.php",
             "lines": {
@@ -105,6 +108,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Foo",
         "fingerprint": "e82b7e1f1d4255352b19ecefa9116a12f129c7edb4351cf2319285eccdb1565e",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode 😃/project/folder with unicode 😃/file name with \"spaces\" and unicode 😃.php",
             "lines": {
@@ -115,6 +119,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Foo",
         "fingerprint": "93c79740ed8c6fbaac2087e54d6f6f67fc0918e3ff77840530f32e19857ef63c",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode \ud83d\ude03/project/foo.php",
             "lines": {
@@ -125,6 +130,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Bar\nBar2",
         "fingerprint": "829f6c782152fdac840b39208c5b519d18e51bff2c601b6197812fffb8bcd9ed",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode \ud83d\ude03/project/foo.php",
             "lines": {
@@ -207,6 +213,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "first generic error",
         "fingerprint": "53ed216d77c9a9b21d9535322457ca7d7b037d6596d76484b3481f161adfd96f",
+        "severity": "major",
         "location": {
             "path": "",
             "lines": {
@@ -217,6 +224,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "second generic error",
         "fingerprint": "f49870714e8ce889212aefb50f718f88ae63d00dd01c775b7bac86c4466e96f0",
+        "severity": "major",
         "location": {
             "path": "",
             "lines": {
@@ -236,6 +244,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Bar\nBar2",
         "fingerprint": "034b4afbfb347494c14e396ed8327692f58be4cd27e8aff5f19f4194934db7c9",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode \ud83d\ude03/project/folder with unicode \ud83d\ude03/file name with \"spaces\" and unicode \ud83d\ude03.php",
             "lines": {
@@ -246,6 +255,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Foo",
         "fingerprint": "e82b7e1f1d4255352b19ecefa9116a12f129c7edb4351cf2319285eccdb1565e",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode \ud83d\ude03/project/folder with unicode \ud83d\ude03/file name with \"spaces\" and unicode \ud83d\ude03.php",
             "lines": {
@@ -256,6 +266,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Foo",
         "fingerprint": "93c79740ed8c6fbaac2087e54d6f6f67fc0918e3ff77840530f32e19857ef63c",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode \ud83d\ude03/project/foo.php",
             "lines": {
@@ -266,6 +277,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "Bar\nBar2",
         "fingerprint": "829f6c782152fdac840b39208c5b519d18e51bff2c601b6197812fffb8bcd9ed",
+        "severity": "major",
         "location": {
             "path": "with space/and unicode \ud83d\ude03/project/foo.php",
             "lines": {
@@ -276,6 +288,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "first generic error",
         "fingerprint": "53ed216d77c9a9b21d9535322457ca7d7b037d6596d76484b3481f161adfd96f",
+        "severity": "major",
         "location": {
             "path": "",
             "lines": {
@@ -286,6 +299,7 @@ public function dataFormatterOutputProvider(): iterable
     {
         "description": "second generic error",
         "fingerprint": "f49870714e8ce889212aefb50f718f88ae63d00dd01c775b7bac86c4466e96f0",
+        "severity": "major",
         "location": {
             "path": "",
             "lines": {