fix: some error formatter tests and also for old PHP 7.1

This reverts commit 4b6111b.

Author: williamdes

tests/ErrorFormatter/GithubErrorFormatterTest.php

@@ -64,8 +64,7 @@ public function dataFormatterOutputProvider(): iterable
   Line   folder with unicode 😃/file name with "spaces" and unicode 😃.php
  ' . $dashLine . '
   4      Foo
- ' . $dashLine . '
-
+ ' . $dashLine . $this->getEndTable() . '
 
  [ERROR] Found 1 error
 
@@ -83,8 +82,7 @@ public function dataFormatterOutputProvider(): iterable
  -- ---------------------
      first generic error
  -- ---------------------
-
-
+' . $this->getEndTable() . '
  [ERROR] Found 1 error
 
 ::error ::first generic error
@@ -132,8 +130,7 @@ public function dataFormatterOutputProvider(): iterable
      first generic error
      second generic error
  -- ----------------------
-
-
+'  . $this->getEndTable() . '
  [ERROR] Found 2 errors
 
 ::error ::first generic error

tests/ErrorFormatter/TableErrorFormatterTest.php

@@ -63,8 +63,7 @@ public function dataFormatterOutputProvider(): iterable
   Line   folder with unicode 😃/file name with "spaces" and unicode 😃.php
  ' . $dashLine . '
   4      Foo
- ' . $dashLine . '
-
+ ' . $dashLine . $this->getEndTable() . '
 
  [ERROR] Found 1 error
 
@@ -81,8 +80,7 @@ public function dataFormatterOutputProvider(): iterable
  -- ---------------------
      first generic error
  -- ---------------------
-
-
+' . $this->getEndTable() . '
  [ERROR] Found 1 error
 
 ',
@@ -125,8 +123,7 @@ public function dataFormatterOutputProvider(): iterable
      first generic error
      second generic error
  -- ----------------------
-
-
+' . $this->getEndTable() . '
  [ERROR] Found 2 errors
 
 ',

tests/ErrorFormatterTestCase.php

@@ -49,6 +49,15 @@ abstract class ErrorFormatterTestCase extends \CodeLts\CliTools\Tests\AbstractTe
     /** @var Output|null */
     private $output = null;
 
+    protected function getEndTable(): string
+    {
+        if (PHP_MAJOR_VERSION === 7 && PHP_MINOR_VERSION === 1) {
+            return '';
+        }
+
+        return "\n";
+    }
+
     protected function getTableDecoration(): string
     {
         if (PHP_MAJOR_VERSION === 7 && PHP_MINOR_VERSION === 1) {