Security fix n°2 - make chunk names safe too

williamdes · williamdes · commit 7e7697f60f10 · 2023-12-16T01:56:06.000+01:00
See: b61c252
diff --git a/src/Resumable.php b/src/Resumable.php
@@ -344,7 +344,7 @@ public function tmpChunkDir(string $identifier): string
      */
     public function tmpChunkFilename(string $filename, int $chunkNumber): string
     {
-        return $filename . '.' . str_pad((string) $chunkNumber, 4, '0', STR_PAD_LEFT);
+        return $this->createSafeName($filename) . '.' . str_pad((string) $chunkNumber, 4, '0', STR_PAD_LEFT);
     }
 
     public function createFileFromChunks(array $chunkFiles, string $destFile): bool

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ public function tmpChunkDir(string $identifier): string`
`344`	`344`	`*/`
`345`	`345`	`public function tmpChunkFilename(string $filename, int $chunkNumber): string`
`346`	`346`	`{`
`347`		`- return $filename . '.' . str_pad((string) $chunkNumber, 4, '0', STR_PAD_LEFT);`
	`347`	`+ return $this->createSafeName($filename) . '.' . str_pad((string) $chunkNumber, 4, '0', STR_PAD_LEFT);`
`348`	`348`	`}`
`349`	`349`
`350`	`350`	`public function createFileFromChunks(array $chunkFiles, string $destFile): bool`