Skip to content

Commit 0092439

Browse files
authored
docs: run typecheck (#1084)
1 parent d726633 commit 0092439

File tree

5 files changed

+7
-3
lines changed

5 files changed

+7
-3
lines changed

apps/docs/app.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ export default defineConfig({
1717
}),
1818
enforce: 'pre',
1919
},
20+
// @ts-expect-error errors due to transitive type only deps
2021
tsConfigPaths({
2122
projects: ['./tsconfig.json'],
2223
}),

apps/docs/app/routes/_docs/ikoner.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,9 @@ function IconCard({ iconName, Icon }) {
8888
<span className="block text-center text-sm">{iconName}</span>
8989
<Button
9090
variant="tertiary"
91+
// @ts-expect-error how can we make this work when we've augmented grunnmuren with tanstack's router?
92+
// In that case we don't want TSR's typesafty, because it's an external link. See https://github.com/adobe/react-spectrum/issues/6397
9193
href={downloadSvgLink}
92-
// @ts-expect-error fix in Grunnmuren so we're allowed to pass download when href is set
9394
download
9495
className="ml-auto w-[44px]"
9596
>

apps/docs/app/routes/_docs/komponenter/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ function Page() {
2929
{components.map((component) => (
3030
<Card key={component._id} variant="outlined">
3131
<Heading level={2}>
32-
{/* @ts-expect-error figure out how to make this typesafe. Seems like routerOptions doesn't accept params */}
32+
{/* @ts-expect-error figure out how to make this typesafe. Seems like routerOptions doesn't accept params. See https://github.com/adobe/react-spectrum/issues/6587 */}
3333
<CardLink href={`/komponenter/${component.slug}`}>
3434
{component.name}
3535
</CardLink>

apps/docs/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@
66
"license": "MIT",
77
"type": "module",
88
"scripts": {
9-
"build": "pnpm build:assets && pnpm build:docgen && pnpm build:app",
9+
"build": "pnpm build:docgen && pnpm build:tsc && pnpm build:assets && pnpm build:app",
1010
"build:app": "vinxi build",
1111
"build:assets": "mkdir -p public/resources/icons && cp -r node_modules/@obosbbl/grunnmuren-icons-svg/src/ public/resources/icons",
1212
"build:docgen": "node build-docs.js && prettier --write docgen.ts --ignore-path",
13+
"build:tsc": "tsc",
1314
"dev": "vinxi dev",
1415
"start": "vinxi start",
1516
"typegen:extract": "sanity schema extract",

apps/docs/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
"skipLibCheck": true,
88
"strictNullChecks": true,
99
"baseUrl": "./",
10+
"noEmit": true,
1011
"paths": {
1112
"@/*": ["app/*"]
1213
}

0 commit comments

Comments
 (0)