Fix href types (#1082)

Author: oscarcarlstrom

.changeset/lazy-ducks-roll.md

@@ -0,0 +1,5 @@
+---
+'@obosbbl/grunnmuren-react': patch
+---
+
+Base `href` prop on `<Backlink>`, `<Breadcrumb>` and `<Button>` to enable type safe routes.

packages/react/src/backlink/backlink.tsx

@@ -1,14 +1,19 @@
 import { ChevronLeft } from '@obosbbl/grunnmuren-icons-react';
 import { cx } from 'cva';
 import { type Ref, forwardRef } from 'react';
-import { Button, type ButtonProps, Link } from 'react-aria-components';
+import {
+  Button,
+  type ButtonProps,
+  Link,
+  type LinkProps as RACLinkProps,
+} from 'react-aria-components';
 
 type ButtonOrLinkProps = {
   children?: React.ReactNode;
   /** Additional CSS className for the element. */
   className?: string;
   /** Determines whether to use an anchor or a button for the Backlink */
-  href?: string;
+  href?: RACLinkProps['href'];
   /** To add a permanent underline on the link (not only on hover)
    * @default false
    */

packages/react/src/breadcrumbs/breadcrumb.tsx

@@ -5,6 +5,7 @@ import {
   Link,
   Breadcrumb as RACBreadcrumb,
   type BreadcrumbProps as RACBreadcrumbProps,
+  type LinkProps as RACLinkProps,
 } from 'react-aria-components';
 
 type BreadcrumbProps = {
@@ -16,7 +17,7 @@ type BreadcrumbProps = {
   style?: React.CSSProperties;
 
   /** The URL to navigate to when clicking the breadcrumb. */
-  href?: string;
+  href?: RACLinkProps['href'];
 } & Omit<RACBreadcrumbProps, 'className' | 'style'>;
 
 function Breadcrumb(props: BreadcrumbProps, ref: Ref<HTMLLIElement>) {

packages/react/src/button/button.tsx

@@ -115,7 +115,7 @@ const buttonVariants = cva({
 
 type ButtonOrLinkProps = VariantProps<typeof buttonVariants> & {
   children?: React.ReactNode;
-  href?: string;
+  href?: RACLinkProps['href'];
   /**
    * Display the button in a loading state
    * @deprecated Use isPending instead.