Remove isLoading prop (#1366)

* Remove isLoading prop

* Remove isLoading prop

* Update .changeset/public-loops-give.md

Author: oscarcarlstrom

.changeset/public-loops-give.md

@@ -0,0 +1,5 @@
+---
+"@obosbbl/grunnmuren-react": major
+---
+
+Removes the deprecated `isLoading` prop from `<Button>` and `<Combobox>`, it is now fully replaced by the `isPending` prop.

packages/react/src/button/button.tsx

@@ -119,12 +119,6 @@ const buttonVariants = cva({
 type ButtonOrLinkProps = VariantProps<typeof buttonVariants> & {
   children?: React.ReactNode;
   href?: RACLinkProps['href'];
-  /**
-   * Display the button in a loading state
-   * @deprecated Use isPending instead.
-   * @default false
-   */
-  isLoading?: boolean;
   /** Additional style properties for the element. */
   style?: React.CSSProperties;
   /** Ref to the element. */
@@ -149,14 +143,11 @@ function Button({ ref = null, ...props }: ButtonProps) {
     children: _children,
     color,
     isIconOnly,
-    isLoading,
     variant,
-    isPending: _isPending,
+    isPending,
     ...restProps
   } = props;
 
-  const isPending = _isPending || isLoading;
-
   const className = buttonVariants({
     className: props.className,
     color,

packages/react/src/combobox/combobox.tsx

@@ -30,11 +30,6 @@ type ComboboxProps<T extends object> = {
   description?: React.ReactNode;
   /** Error message for the form control. Automatically sets `isInvalid` to true */
   errorMessage?: React.ReactNode;
-  /**
-   * Display the dropdown button trigger in a pending state
-   * @deprecated Use isPending instead.
-   */
-  isLoading?: boolean;
   /**
    * Display the dropdown button trigger in a pending state
    * @default false
@@ -59,16 +54,13 @@ function Combobox<T extends object>(props: ComboboxProps<T>) {
     children,
     description,
     errorMessage,
-    isLoading,
-    isPending: _isPending,
+    isPending,
     label,
     isInvalid: _isInvalid,
     ref,
     ...restProps
   } = props;
 
-  const isPending = _isPending || isLoading;
-
   // the order of the conditions matter here, because providing a value for isInvalid makes the validation state "controlled",
   // which will override any built in validation
   const isInvalid = !!errorMessage || _isInvalid;