add validation package #17
Merged
+445
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * https://www.brreg.no/om-oss/registrene-vare/om-enhetsregisteret/organisasjonsnummeret/ | ||
| * https://no.wikipedia.org/wiki/Organisasjonsnummer | ||
| */ | ||
| return mod11(value, [3, 2, 7, 6, 5, 4, 3, 2]); |
gabrielwallin
approved these changes
Feb 10, 2025
packages/validation/src/se.ts
Outdated
| } | ||
|
|
||
| if (options.mobileOnly) { | ||
| const isMobileNumber = /^07\d{8}$/.test(value); |
There was a problem hiding this comment.
Evt check på riktnummer för mobil (07X)
Contributor
Author
There was a problem hiding this comment.
Har forbedret valideringen på svensk mobiltelefon. Sjekker nå etter følgende format:
Swedish mobile phone numbers only have 5 area codes, so we can validate these for further correctness
aulonm
approved these changes
Feb 10, 2025
Tollefsen
reviewed
Feb 10, 2025
| return false; | ||
| } | ||
|
|
||
| let sum = 0; |
Contributor
Author
There was a problem hiding this comment.
Det skal sies at var opprinnelig en reduce faktisk, men reduce er en av de tingene jeg har sluttet å bruke. 9/10 ganger er ikke-reduce varianten mer lesbar, imo.
There was a problem hiding this comment.
Hehe, må nok si meg uenig her ja 😆
16 år etter at reduce ble introdusert til js så er ikkje det noe "magisk" eller uleselige greier lenger 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Denne PRen legger til ny pakke
@obosbbl/validation.Tanken er at den skal inneholde en samling med forskjellige valideringsmetoder som vi har nytte av i OBOS, og at den skal støtte både no og se, på lik linje med @obosbbl/format.
Det vil si at denne pakken blir deprecated etter hvert https://github.com/code-obos/frontend-modules/tree/main/packages/validation.
For nå kommer den innebygget med følgende valideringsmetoder:
Alle metodene tillater en optional param hvor man kan bestemme om formatering skal være tillatt under validering. Merk at dette ikke er tillat by default. Men i noen tilfeller kan det være fornuftig å tillatte dette, feks når brukeren skal fylle ut et skjema og man har lyst til å validere at dataen er riktig, men også lar brukeren bruke sin foretrukne formatering på feks telefonnnummer.