chore(fc/chat/list): apply nav bar padding to find room button conditionally

Signed-off-by: Brandon McAnsh <[email protected]>

Author: bmc08gt

flipchatApp/src/main/kotlin/xyz/flipchat/app/features/chat/list/ChatListScreen.kt

@@ -7,6 +7,7 @@ import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.PaddingValues
 import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.fillMaxWidth
+import androidx.compose.foundation.layout.navigationBarsPadding
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.foundation.lazy.rememberLazyListState
@@ -15,11 +16,13 @@ import androidx.compose.material.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
 import androidx.compose.runtime.SideEffect
+import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue
 import androidx.compose.runtime.mutableStateOf
 import androidx.compose.runtime.rememberCoroutineScope
 import androidx.compose.runtime.saveable.rememberSaveable
 import androidx.compose.runtime.setValue
+import androidx.compose.runtime.snapshots.Snapshot
 import androidx.compose.ui.Alignment.Companion.CenterHorizontally
 import androidx.compose.ui.Alignment.Companion.CenterVertically
 import androidx.compose.ui.Modifier
@@ -45,6 +48,7 @@ import com.getcode.ui.theme.ButtonState
 import com.getcode.ui.theme.CodeButton
 import com.getcode.ui.theme.CodeCircularProgressIndicator
 import com.getcode.ui.theme.CodeScaffold
+import com.getcode.ui.utils.addIf
 import io.grpc.Status.Code
 import kotlinx.coroutines.flow.filter
 import kotlinx.coroutines.flow.filterIsInstance
@@ -110,21 +114,14 @@ private fun ChatListScreenContent(
 ) {
     val navigator = LocalCodeNavigator.current
     val context = LocalContext.current
+    val state by viewModel.stateFlow.collectAsState()
     val chats = viewModel.chats.collectAsLazyPagingItems()
     val isLoading = chats.loadState.refresh is LoadState.Loading
     var isInitialLoad by rememberSaveable { mutableStateOf(true) }
     val listState = rememberLazyListState()
     val composeScope = rememberCoroutineScope()
 
     CodeScaffold { padding ->
-        SideEffect {
-            if (!listState.canScrollBackward) {
-                composeScope.launch {
-                    listState.scrollToItem(0)
-                }
-            }
-        }
-
         LazyColumn(
             modifier = Modifier.fillMaxSize().padding(padding),
             contentPadding = PaddingValues(bottom = CodeTheme.dimens.inset),
@@ -178,7 +175,8 @@ private fun ChatListScreenContent(
                             modifier = Modifier
                                 .fillMaxWidth()
                                 .padding(top = CodeTheme.dimens.grid.x6)
-                                .padding(horizontal = CodeTheme.dimens.inset),
+                                .padding(horizontal = CodeTheme.dimens.inset)
+                                .addIf(!state.isLoggedIn) { Modifier.navigationBarsPadding() },
                             buttonState = ButtonState.Filled,
                             text = stringResource(R.string.action_findRoom)
                         ) {
@@ -191,6 +189,15 @@ private fun ChatListScreenContent(
                     }
                 }
             }
+
+            // opts out of the list maintaining
+            // scroll position when adding elements before the first item
+            Snapshot.withoutReadObservation {
+                listState.requestScrollToItem(
+                    index = listState.firstVisibleItemIndex,
+                    scrollOffset = listState.firstVisibleItemScrollOffset
+                )
+            }
         }
     }
 

flipchatApp/src/main/kotlin/xyz/flipchat/app/features/chat/list/ChatListViewModel.kt

@@ -13,7 +13,6 @@ import com.getcode.view.BaseViewModel2
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.flow.Flow
-import kotlinx.coroutines.flow.SharingStarted
 import kotlinx.coroutines.flow.distinctUntilChanged
 import kotlinx.coroutines.flow.filter
 import kotlinx.coroutines.flow.filterIsInstance
@@ -24,7 +23,6 @@ import kotlinx.coroutines.flow.launchIn
 import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.flow.mapNotNull
 import kotlinx.coroutines.flow.onEach
-import kotlinx.coroutines.flow.stateIn
 import kotlinx.coroutines.flow.take
 import xyz.flipchat.app.R
 import xyz.flipchat.app.features.chat.conversation.ConversationViewModel.Event
@@ -59,11 +57,13 @@ class ChatListViewModel @Inject constructor(
         val showFullscreenSpinner: Boolean = false,
         val networkConnected: Boolean = true,
         val chatTapCount: Int = 0,
+        val isLoggedIn: Boolean = false,
         val isLogOutEnabled: Boolean = false,
     )
 
     sealed interface Event {
         data class OnSelfIdChanged(val id: ID?) : Event
+        data class OnLoggedInStateChanged(val loggedIn: Boolean): Event
         data class ShowFullScreenSpinner(
             val showScrim: Boolean = true,
             val showSpinner: Boolean = true
@@ -87,9 +87,14 @@ class ChatListViewModel @Inject constructor(
         userManager.state
             .map { it.userId }
             .distinctUntilChanged()
-            .onEach {
-                dispatchEvent(Event.OnSelfIdChanged(it))
-            }.launchIn(viewModelScope)
+            .onEach { dispatchEvent(Event.OnSelfIdChanged(it)) }
+            .launchIn(viewModelScope)
+
+        userManager.state
+            .map { it.authState }
+            .distinctUntilChanged()
+            .onEach { dispatchEvent(Event.OnLoggedInStateChanged(it is AuthState.LoggedIn)) }
+            .launchIn(viewModelScope)
 
         networkObserver.state
             .map { it.connected }
@@ -246,6 +251,8 @@ class ChatListViewModel @Inject constructor(
 
                 is Event.OnSelfIdChanged -> { state -> state.copy(selfId = event.id) }
 
+                is Event.OnLoggedInStateChanged -> { state -> state.copy(isLoggedIn = event.loggedIn) }
+
                 is Event.NeedsAccountCreated,
                 is Event.OnAccountCreated,
                 is Event.OnOpen,