chore(flipcash/pools): internally fetch latest pool when resolving

Signed-off-by: Brandon McAnsh <[email protected]>

Author: bmc08gt

apps/flipcash/features/pools/src/main/kotlin/com/flipcash/app/pools/internal/betting/PoolBettingViewModel.kt

@@ -421,12 +421,7 @@ internal class PoolBettingViewModel @Inject constructor(
                     ).fold(
                         onSuccess = {
                             poolsCoordinator.resolvePool(
-                                // ensure the pool metadata is as up-to-date as possible
-                                // ensuring there is no race condition possibility w/ observe
-                                pool = stateFlow.value.metadata.copy(
-                                    isOpen = false,
-                                    closedAt = it
-                                ),
+                                poolId = stateFlow.value.metadata.id,
                                 rendezvous = rendezvous,
                                 resolution = resolution,
                             )

apps/flipcash/shared/pools/src/main/kotlin/com/flipcash/app/pools/PoolsCoordinator.kt

@@ -146,18 +146,21 @@ class PoolsCoordinator @Inject constructor(
     }
 
     suspend fun resolvePool(
-        pool: Pool,
+        poolId: ID,
         resolution: PoolResolution.DecisionMade,
         rendezvous: KeyPair
     ): Result<Unit> {
-        val metadata = domainToNetworkMapper.map(pool)
-        return controller.resolvePool(
-            pool = metadata,
-            rendezvous = rendezvous,
-            resolution = PoolResolutionConverter.toPoolResolution(resolution as PoolResolution),
-        ).onSuccess {
-            dataSource.resolvePool(pool.id, resolution)
-        }
+        return controller.getPool(poolId)
+            .fold(
+                onSuccess = {
+                    controller.resolvePool(
+                        pool = it.metadata,
+                        rendezvous = rendezvous,
+                        resolution = PoolResolutionConverter.toPoolResolution(resolution as PoolResolution),
+                    )
+                },
+                onFailure = { Result.failure(it) }
+            )
     }
 
     suspend fun placeBet(