chore: consolidate usdc valueExchange amount internally

Signed-off-by: Brandon McAnsh <[email protected]>

Author: bmc08gt

apps/flipcash/features/cash/src/main/kotlin/com/flipcash/app/cash/internal/CashScreenViewModel.kt

@@ -152,18 +152,11 @@ internal class CashScreenViewModel @Inject constructor(
 
                             val localizedAmount = Fiat(amount, rate.currency)
                             val token = stateFlow.value.token!!.token
-                            val amountFiat = if (token.address == Mint.usdc) {
-                                 LocalFiat(
-                                    usdc = localizedAmount.convertingTo(exchange.rateToUsd(rate.currency)!!),
-                                    nativeAmount = localizedAmount,
-                                )
-                            } else {
-                                LocalFiat.valueExchangeIn(
-                                    localizedAmount,
-                                    token = token,
-                                    rate = rate,
-                                )
-                            }
+                            val amountFiat = LocalFiat.valueExchangeIn(
+                                amount =  Fiat(amount, rate.currency),
+                                token = token,
+                                rate = rate,
+                            )
 
                             val neededAmount = amountFiat.underlyingTokenAmount - tokenBalance
 
@@ -312,20 +305,11 @@ internal class CashScreenViewModel @Inject constructor(
                     }
                 }
 
-                val localizedAmount = Fiat(data.amountData.amount, rate.currency)
-                // TOD is there a way to consolidate all of this into valueExchangeIn?
-                val amountFiat = if (token.address == Mint.usdc) {
-                    LocalFiat(
-                        usdc = localizedAmount.convertingTo(exchange.rateToUsd(rate.currency)!!),
-                        nativeAmount = localizedAmount,
-                    )
-                } else {
-                    LocalFiat.valueExchangeIn(
-                        amount = localizedAmount,
-                        token = token,
-                        rate = rate,
-                    )
-                }
+                val amountFiat = LocalFiat.valueExchangeIn(
+                    amount = Fiat(data.amountData.amount, rate.currency),
+                    token = token,
+                    rate = rate,
+                )
 
                 val bill = Bill.Cash(
                     token = stateFlow.value.token!!.token,

apps/flipcash/features/withdrawal/src/main/kotlin/com/flipcash/app/withdrawal/WithdrawalViewModel.kt

@@ -284,20 +284,12 @@ internal class WithdrawalViewModel @Inject constructor(
                     exchange.fetchRatesIfNeeded()
                 }
 
-                val localizedAmount = Fiat(data.amountData.amount, rate.currency)
                 val token = stateFlow.value.token!!.token
-                val amountFiat = if (token.address == Mint.usdc) {
-                    LocalFiat(
-                        usdc = localizedAmount.convertingTo(exchange.rateToUsd(rate.currency)!!),
-                        nativeAmount = localizedAmount,
-                    )
-                } else {
-                    LocalFiat.valueExchangeIn(
-                        localizedAmount,
-                        token = token,
-                        rate = rate,
-                    )
-                }
+                val amountFiat = LocalFiat.valueExchangeIn(
+                    amount = Fiat(data.amountData.amount, rate.currency),
+                    token = token,
+                    rate = rate,
+                )
 
                 dispatchEvent(Event.UpdateConfirmingAmountState(loading = false, success = true))
                 dispatchEvent(Event.OnAmountAccepted(amountFiat))
@@ -433,15 +425,11 @@ internal class WithdrawalViewModel @Inject constructor(
                 val sendingVault = owner.withTimelockForToken(token)
 
                 val feeInMint = feeInUsd?.let { fee ->
-                    if (token.address != Mint.usdc) {
-                        LocalFiat.valueExchangeIn(
-                            fee,
-                            token = token,
-                            rate = exchange.rateToUsd(CurrencyCode.USD)!!
-                        ).underlyingTokenAmount
-                    } else {
-                        feeInUsd
-                    }
+                    LocalFiat.valueExchangeIn(
+                        fee,
+                        token = token,
+                        rate = exchange.rateToUsd(CurrencyCode.USD)!!
+                    ).underlyingTokenAmount
                 }
 
                 transactionController.withdraw(

services/opencode/src/main/kotlin/com/getcode/opencode/model/financial/LocalFiat.kt

@@ -71,6 +71,20 @@ data class LocalFiat(
                 amount
             }
 
+            if (token.address == Mint.usdc) {
+                // this doesn't need a calcuated value exchange since we are USDC
+               return if (rate.currency != CurrencyCode.USD) {
+                   LocalFiat(
+                       usdc = usdValue,
+                       nativeAmount = amount
+                   )
+               } else {
+                   LocalFiat(usdc = usdValue)
+               }
+            }
+
+
+
             // determine quarks to exchange for the desired amount
             val quarks = Estimator.valueExchangeAsQuarks(
                 valueInQuarks = usdValue.quarks,