WIP

Author: Jeff Yanta

go.mod

@@ -6,7 +6,7 @@ require (
 	filippo.io/edwards25519 v1.1.0
 	github.com/aws/aws-sdk-go-v2 v0.17.0
 	github.com/bits-and-blooms/bloom/v3 v3.1.0
-	github.com/code-payments/code-protobuf-api v1.19.1-0.20250610140050-4cadbcc86f16
+	github.com/code-payments/code-protobuf-api v1.19.1-0.20250618155621-c66659ab4ff5
 	github.com/code-payments/code-vm-indexer v0.1.11-0.20241028132209-23031e814fba
 	github.com/emirpasic/gods v1.12.0
 	github.com/envoyproxy/protoc-gen-validate v1.2.1

go.sum

@@ -80,8 +80,8 @@ github.com/cncf/udpa/go v0.0.0-20200629203442-efcf912fb354/go.mod h1:WmhPx2Nbnht
 github.com/cncf/udpa/go v0.0.0-20201120205902-5459f2c99403/go.mod h1:WmhPx2Nbnhtbo57+VJT5O0JRkEi1Wbu0z5j0R8u5Hbk=
 github.com/cockroachdb/apd v1.1.0 h1:3LFP3629v+1aKXU5Q37mxmRxX/pIu1nijXydLShEq5I=
 github.com/cockroachdb/apd v1.1.0/go.mod h1:8Sl8LxpKi29FqWXR16WEFZRNSz3SoPzUzeMeY4+DwBQ=
-github.com/code-payments/code-protobuf-api v1.19.1-0.20250610140050-4cadbcc86f16 h1:drAMKRdbyObW8E4H6xc1pKIDxoFYgpaTdMlEnIKBIJ0=
-github.com/code-payments/code-protobuf-api v1.19.1-0.20250610140050-4cadbcc86f16/go.mod h1:ee6TzKbgMS42ZJgaFEMG3c4R3dGOiffHSu6MrY7WQvs=
+github.com/code-payments/code-protobuf-api v1.19.1-0.20250618155621-c66659ab4ff5 h1:fsZBRUCPGSZQngq/1rsJcEwhiYrZokr0wketRRTgGmI=
+github.com/code-payments/code-protobuf-api v1.19.1-0.20250618155621-c66659ab4ff5/go.mod h1:ee6TzKbgMS42ZJgaFEMG3c4R3dGOiffHSu6MrY7WQvs=
 github.com/code-payments/code-vm-indexer v0.1.11-0.20241028132209-23031e814fba h1:Bkp+gmeb6Y2PWXfkSCTMBGWkb2P1BujRDSjWeI+0j5I=
 github.com/code-payments/code-vm-indexer v0.1.11-0.20241028132209-23031e814fba/go.mod h1:jSiifpiBpyBQ8q2R0MGEbkSgWC6sbdRTyDBntmW+j1E=
 github.com/containerd/continuity v0.0.0-20190827140505-75bee3e2ccb6 h1:NmTXa/uVnDyp0TY5MKi197+3HWcnYWfnHGyaFthlnGw=

pkg/code/aml/guard.go

@@ -63,6 +63,9 @@ func (g *Guard) AllowMoneyMovement(ctx context.Context, intentRecord *intent.Rec
 	case intent.ReceivePaymentsPublicly:
 		// Public receives are always allowed
 		return true, nil
+	case intent.PublicDistribution:
+		// Public distributions are always allowed
+		return true, nil
 	default:
 		err := errors.New("intent record must be a send or receive payment")
 		tracer.OnError(err)

pkg/code/antispam/guard.go

@@ -3,6 +3,8 @@ package antispam
 import (
 	"context"
 
+	transactionpb "github.com/code-payments/code-protobuf-api/generated/go/transaction/v2"
+
 	"github.com/code-payments/code-server/pkg/code/common"
 	"github.com/code-payments/code-server/pkg/metrics"
 )
@@ -15,11 +17,11 @@ func NewGuard(integration Integration) *Guard {
 	return &Guard{integration: integration}
 }
 
-func (g *Guard) AllowOpenAccounts(ctx context.Context, owner *common.Account) (bool, error) {
+func (g *Guard) AllowOpenAccounts(ctx context.Context, owner *common.Account, accountSet transactionpb.OpenAccountsMetadata_AccountSet) (bool, error) {
 	tracer := metrics.TraceMethodCall(ctx, metricsStructName, "AllowOpenAccounts")
 	defer tracer.End()
 
-	allow, reason, err := g.integration.AllowOpenAccounts(ctx, owner)
+	allow, reason, err := g.integration.AllowOpenAccounts(ctx, owner, accountSet)
 	if err != nil {
 		return false, err
 	}
@@ -70,3 +72,17 @@ func (g *Guard) AllowReceivePayments(ctx context.Context, owner *common.Account,
 	}
 	return allow, nil
 }
+
+func (g *Guard) AllowDistribution(ctx context.Context, owner *common.Account, isPublic bool) (bool, error) {
+	tracer := metrics.TraceMethodCall(ctx, metricsStructName, "AllowDistribution")
+	defer tracer.End()
+
+	allow, reason, err := g.integration.AllowDistribution(ctx, owner, isPublic)
+	if err != nil {
+		return false, err
+	}
+	if !allow {
+		recordDenialEvent(ctx, actionDistribution, reason)
+	}
+	return allow, nil
+}

pkg/code/antispam/integration.go

@@ -3,19 +3,23 @@ package antispam
 import (
 	"context"
 
+	transactionpb "github.com/code-payments/code-protobuf-api/generated/go/transaction/v2"
+
 	"github.com/code-payments/code-server/pkg/code/common"
 )
 
 // Integration is an antispam guard integration that apps can implement to check
 // whether operations of interest are allowed to be performed.
 type Integration interface {
-	AllowOpenAccounts(ctx context.Context, owner *common.Account) (bool, string, error)
+	AllowOpenAccounts(ctx context.Context, owner *common.Account, accountSet transactionpb.OpenAccountsMetadata_AccountSet) (bool, string, error)
 
 	AllowWelcomeBonus(ctx context.Context, owner *common.Account) (bool, string, error)
 
 	AllowSendPayment(ctx context.Context, owner, destination *common.Account, isPublic bool) (bool, string, error)
 
 	AllowReceivePayments(ctx context.Context, owner *common.Account, isPublic bool) (bool, string, error)
+
+	AllowDistribution(ctx context.Context, owner *common.Account, isPublic bool) (bool, string, error)
 }
 
 type allowEverythingIntegration struct {
@@ -26,7 +30,7 @@ func NewAllowEverything() Integration {
 	return &allowEverythingIntegration{}
 }
 
-func (i *allowEverythingIntegration) AllowOpenAccounts(ctx context.Context, owner *common.Account) (bool, string, error) {
+func (i *allowEverythingIntegration) AllowOpenAccounts(ctx context.Context, owner *common.Account, accountSet transactionpb.OpenAccountsMetadata_AccountSet) (bool, string, error) {
 	return true, "", nil
 }
 
@@ -41,3 +45,7 @@ func (i *allowEverythingIntegration) AllowSendPayment(ctx context.Context, owner
 func (i *allowEverythingIntegration) AllowReceivePayments(ctx context.Context, owner *common.Account, isPublic bool) (bool, string, error) {
 	return true, "", nil
 }
+
+func (i *allowEverythingIntegration) AllowDistribution(ctx context.Context, owner *common.Account, isPublic bool) (bool, string, error) {
+	return true, "", nil
+}

pkg/code/antispam/metrics.go

@@ -14,6 +14,7 @@ const (
 	actionOpenAccounts    = "OpenAccounts"
 	actionSendPayment     = "SendPayment"
 	actionReceivePayments = "ReceivePayments"
+	actionDistribution    = "Distribution"
 
 	actionWelcomeBonus = "WelcomeBonus"
 )

pkg/code/async/sequencer/intent_handler.go

@@ -125,6 +125,37 @@ func (h *ReceivePaymentsPubliclyIntentHandler) OnActionUpdated(ctx context.Conte
 	return nil
 }
 
+type PublicDistributionIntentHandler struct {
+	data code_data.Provider
+}
+
+func NewPublicDistributionIntentHandler(data code_data.Provider) IntentHandler {
+	return &PublicDistributionIntentHandler{
+		data: data,
+	}
+}
+
+func (h *PublicDistributionIntentHandler) OnActionUpdated(ctx context.Context, intentId string) error {
+	actionRecords, err := h.data.GetAllActionsByIntent(ctx, intentId)
+	if err != nil {
+		return err
+	}
+
+	for _, actionRecord := range actionRecords {
+		// Intent is failed if at least one transfer or withdraw action fails
+		if actionRecord.State == action.StateFailed {
+			return markIntentFailed(ctx, h.data, intentId)
+		}
+
+		if actionRecord.State != action.StateConfirmed {
+			return nil
+		}
+	}
+
+	// Intent is confirmed when all transfer and withdraw actions are confirmed
+	return markIntentConfirmed(ctx, h.data, intentId)
+}
+
 func validateIntentState(record *intent.Record, states ...intent.State) error {
 	for _, validState := range states {
 		if record.State == validState {
@@ -176,5 +207,6 @@ func getIntentHandlers(data code_data.Provider) map[intent.Type]IntentHandler {
 	handlersByType[intent.OpenAccounts] = NewOpenAccountsIntentHandler(data)
 	handlersByType[intent.SendPublicPayment] = NewSendPublicPaymentIntentHandler(data)
 	handlersByType[intent.ReceivePaymentsPublicly] = NewReceivePaymentsPubliclyIntentHandler(data)
+	handlersByType[intent.PublicDistribution] = NewPublicDistributionIntentHandler(data)
 	return handlersByType
 }

pkg/code/data/account/acccount_info.go

@@ -180,6 +180,10 @@ func (r *Record) Validate() error {
 		if r.OwnerAccount == r.AuthorityAccount {
 			return errors.New("owner cannot be authority for swap account")
 		}
+	case commonpb.AccountType_POOL:
+		if r.OwnerAccount == r.AuthorityAccount {
+			return errors.New("owner cannot be authority pool account")
+		}
 	default:
 		return errors.Errorf("unhandled account type: %s", r.AccountType.String())
 	}

pkg/code/data/intent/intent.go

@@ -33,6 +33,7 @@ const (
 	ReceivePaymentsPublicly
 	EstablishRelationship // Deprecated privacy flow
 	Login                 // Deprecated login flow
+	PublicDistribution
 )
 
 type Record struct {
@@ -47,6 +48,7 @@ type Record struct {
 	ExternalDepositMetadata         *ExternalDepositMetadata
 	SendPublicPaymentMetadata       *SendPublicPaymentMetadata
 	ReceivePaymentsPubliclyMetadata *ReceivePaymentsPubliclyMetadata
+	PublicDistributionMetadata      *PublicDistributionMetadata
 
 	ExtendedMetadata []byte
 
@@ -58,7 +60,7 @@ type Record struct {
 }
 
 type OpenAccountsMetadata struct {
-	// Nothing yet
+	// todo: What should be stored here given different flows?
 }
 
 type ExternalDepositMetadata struct {
@@ -96,6 +98,12 @@ type ReceivePaymentsPubliclyMetadata struct {
 	UsdMarketValue float64
 }
 
+type PublicDistributionMetadata struct {
+	Source         string
+	Quantity       uint64
+	UsdMarketValue float64
+}
+
 func (r *Record) IsCompleted() bool {
 	return r.State == StateConfirmed
 }
@@ -125,6 +133,12 @@ func (r *Record) Clone() Record {
 		receivePaymentsPubliclyMetadata = &cloned
 	}
 
+	var publicDistributionMetadata *PublicDistributionMetadata
+	if r.PublicDistributionMetadata != nil {
+		cloned := r.PublicDistributionMetadata.Clone()
+		publicDistributionMetadata = &cloned
+	}
+
 	return Record{
 		Id: r.Id,
 
@@ -137,6 +151,7 @@ func (r *Record) Clone() Record {
 		ExternalDepositMetadata:         externalDepositMetadata,
 		SendPublicPaymentMetadata:       sendPublicPaymentMetadata,
 		ReceivePaymentsPubliclyMetadata: receivePaymentsPubliclyMetadata,
+		PublicDistributionMetadata:      publicDistributionMetadata,
 
 		ExtendedMetadata: r.ExtendedMetadata,
 
@@ -160,6 +175,7 @@ func (r *Record) CopyTo(dst *Record) {
 	dst.ExternalDepositMetadata = r.ExternalDepositMetadata
 	dst.SendPublicPaymentMetadata = r.SendPublicPaymentMetadata
 	dst.ReceivePaymentsPubliclyMetadata = r.ReceivePaymentsPubliclyMetadata
+	dst.PublicDistributionMetadata = r.PublicDistributionMetadata
 
 	dst.ExtendedMetadata = r.ExtendedMetadata
 
@@ -227,6 +243,17 @@ func (r *Record) Validate() error {
 		}
 	}
 
+	if r.IntentType == PublicDistribution {
+		if r.PublicDistributionMetadata == nil {
+			return errors.New("public distribution metadata must be present")
+		}
+
+		err := r.PublicDistributionMetadata.Validate()
+		if err != nil {
+			return err
+		}
+	}
+
 	return nil
 }
 
@@ -388,6 +415,32 @@ func (m *ReceivePaymentsPubliclyMetadata) Validate() error {
 	return nil
 }
 
+func (m *PublicDistributionMetadata) Clone() PublicDistributionMetadata {
+	return PublicDistributionMetadata{
+		Source:         m.Source,
+		Quantity:       m.Quantity,
+		UsdMarketValue: m.UsdMarketValue,
+	}
+}
+
+func (m *PublicDistributionMetadata) CopyTo(dst *PublicDistributionMetadata) {
+	dst.Source = m.Source
+	dst.Quantity = m.Quantity
+	dst.UsdMarketValue = m.UsdMarketValue
+}
+
+func (m *PublicDistributionMetadata) Validate() error {
+	if len(m.Source) == 0 {
+		return errors.New("source is required")
+	}
+
+	if m.Quantity == 0 {
+		return errors.New("quantity is required")
+	}
+
+	return nil
+}
+
 func (s State) IsTerminal() bool {
 	switch s {
 	case StateConfirmed:
@@ -439,6 +492,8 @@ func (t Type) String() string {
 		return "establish_relationship"
 	case Login:
 		return "login"
+	case PublicDistribution:
+		return "public_distribution"
 	}
 
 	return "unknown"

pkg/code/data/intent/memory/store.go

@@ -110,22 +110,6 @@ func (s *store) findBySource(source string) []*intent.Record {
 	return res
 }
 
-func (s *store) findByInitiatorAndType(intentType intent.Type, owner string) []*intent.Record {
-	res := make([]*intent.Record, 0)
-	for _, item := range s.records {
-		if item.IntentType != intentType {
-			continue
-		}
-
-		if item.InitiatorOwnerAccount != owner {
-			continue
-		}
-
-		res = append(res, item)
-	}
-	return res
-}
-
 func (s *store) findByOwnerSinceTimestamp(owner string, since time.Time) []*intent.Record {
 	res := make([]*intent.Record, 0)
 	for _, item := range s.records {
@@ -318,25 +302,6 @@ func (s *store) GetAllByOwner(ctx context.Context, owner string, cursor query.Cu
 	return nil, intent.ErrIntentNotFound
 }
 
-func (s *store) GetLatestByInitiatorAndType(ctx context.Context, intentType intent.Type, owner string) (*intent.Record, error) {
-	s.mu.Lock()
-	defer s.mu.Unlock()
-
-	items := s.findByInitiatorAndType(intentType, owner)
-	if len(items) == 0 {
-		return nil, intent.ErrIntentNotFound
-	}
-
-	latest := items[0]
-	for _, item := range items {
-		if item.CreatedAt.After(latest.CreatedAt) {
-			latest = item
-		}
-	}
-
-	return latest, nil
-}
-
 func (s *store) GetOriginalGiftCardIssuedIntent(ctx context.Context, giftCardVault string) (*intent.Record, error) {
 	s.mu.Lock()
 	defer s.mu.Unlock()