Add more edge case tests

Author: Jeff Yanta

pkg/code/transaction/nonce_pool.go

@@ -284,17 +284,15 @@ func NewLocalNoncePool(
 		refreshPoolCh: make(chan struct{}),
 	}
 
-	np.workerCtx, np.cancelWorkerCtx = context.WithCancel(context.Background())
-
 	for _, o := range opts {
 		o(&np.opts)
 	}
-
 	if err := np.opts.validate(); err != nil {
-		np.cancelWorkerCtx()
 		return nil, err
 	}
 
+	np.workerCtx, np.cancelWorkerCtx = context.WithCancel(context.Background())
+
 	_, err := np.load(np.workerCtx, np.opts.desiredPoolSize)
 	switch err {
 	case nil, nonce.ErrNonceNotFound:

pkg/code/transaction/nonce_pool_test.go

@@ -234,6 +234,22 @@ func testLocalNoncePoolReserveWithSignatureEdgeCases(nt *localNoncePoolTest) {
 	require.NoError(nt.t, err)
 	require.Equal(nt.t, actual.State, nonce.StateReserved)
 	require.Equal(nt.t, actual.Signature, "signature1")
+
+	n, err = nt.pool.GetNonce(ctx)
+	require.NoError(nt.t, err)
+	require.NotNil(nt.t, n)
+
+	n.record.State = nonce.StateUnknown
+	n.record.ClaimNodeID = nil
+	n.record.ClaimExpiresAt = nil
+	require.NoError(nt.t, nt.data.SaveNonce(ctx, n.record))
+
+	require.Error(nt.t, n.MarkReservedWithSignature(ctx, "signature3"))
+
+	actual, err = nt.data.GetNonce(ctx, n.record.Address)
+	require.NoError(nt.t, err)
+	require.Equal(nt.t, actual.State, nonce.StateUnknown)
+	require.Empty(nt.t, actual.Signature)
 }
 
 type localNoncePoolTest struct {