all: add bodyclose linter

Author: mfycheng

.golangci-lint.yaml

@@ -1,3 +1,7 @@
+linters:
+  enable:
+    - bodyclose
+
 issues:
   exclude-rules:
     - path: '(.+)_test\.go'

pkg/code/webhook/execution.go

@@ -13,11 +13,11 @@ import (
 
 	messagingpb "github.com/code-payments/code-protobuf-api/generated/go/messaging/v1"
 
-	"github.com/code-payments/code-server/pkg/metrics"
 	"github.com/code-payments/code-server/pkg/code/common"
 	code_data "github.com/code-payments/code-server/pkg/code/data"
 	"github.com/code-payments/code-server/pkg/code/data/webhook"
 	"github.com/code-payments/code-server/pkg/code/server/grpc/messaging"
+	"github.com/code-payments/code-server/pkg/metrics"
 )
 
 const (
@@ -95,7 +95,10 @@ func Execute(
 		resp, err := http.DefaultClient.Do(webhookReq)
 		if err != nil {
 			return errors.Wrap(err, "error executing http post request")
-		} else if resp.StatusCode != http.StatusOK {
+		}
+		defer resp.Body.Close()
+	
+		if resp.StatusCode != http.StatusOK {
 			return errors.Errorf("%d status code returned", resp.StatusCode)
 		}
 

pkg/currency/coingecko/client.go

@@ -89,7 +89,9 @@ func (c *client) submitRequest(ctx context.Context, url string, body io.Reader,
 	var httpResp *http.Response
 	_, err = c.retrier.Retry(
 		func() error {
-			httpResp, err = c.httpClient.Do(req)
+			// Retry only occurs if err != nil, in which case the body does not need to be closed.
+			// The body itself is closed below
+			httpResp, err = c.httpClient.Do(req) //nolint:bodyclose
 			return err
 		},
 	)

pkg/currency/fixer/client.go

@@ -113,7 +113,9 @@ func (c *client) submitRequest(ctx context.Context, url string, resp interface{}
 	var httpResp *http.Response
 	_, err = c.retrier.Retry(
 		func() error {
-			httpResp, err = c.httpClient.Do(req)
+			// Retry only occurs if err != nil, in which case the body does not need to be closed.
+			// The body itself is closed below
+			httpResp, err = c.httpClient.Do(req) //nolint:bodyclose
 			return err
 		},
 	)

pkg/netutil/url.go

@@ -51,7 +51,9 @@ func ValidateHttpUrl(
 		var resp *http.Response
 		_, err = retry.Retry(
 			func() error {
-				resp, err = http.Get(value)
+				// Retry only occurs if err != nil, in which case the body does not need to be closed.
+				// The body itself is closed below
+				resp, err = http.Get(value) //nolint:bodyclose
 				return err
 			},
 			retry.Limit(5),
@@ -60,6 +62,7 @@ func ValidateHttpUrl(
 		if err != nil {
 			return err
 		}
+		defer resp.Body.Close()
 
 		if resp.StatusCode != http.StatusOK {
 			return errors.Errorf("%d status code fetching content", resp.StatusCode)